Re: Review Request: Proton-223: Need system-level and soak tests to exercise Proton

2013-03-28 Thread Philip Harvey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9903/#review18460 --- Ship it! Looks good to me. I highlighted a few TODOs in the code,

Re: Review Request: Proton-223: Need system-level and soak tests to exercise Proton

2013-03-25 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9903/ --- (Updated March 25, 2013, 9:39 p.m.) Review request for qpid, Rafael Schloming,

Re: Review Request: Proton-223: Need system-level and soak tests to exercise Proton

2013-03-21 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9903/ --- (Updated March 21, 2013, 12:36 p.m.) Review request for qpid, Rafael Schloming,

Re: Review Request: Proton-223: Need system-level and soak tests to exercise Proton

2013-03-18 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9903/ --- (Updated March 18, 2013, 10:11 p.m.) Review request for qpid, Rafael Schloming

Re: Review Request: Proton-223: Need system-level and soak tests to exercise Proton

2013-03-14 Thread Philip Harvey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9903/#review17868 --- I generally like what you're doing here. My only real concern is

Re: Review Request: Proton-223: Need system-level and soak tests to exercise Proton

2013-03-14 Thread Kenneth Giusti
On March 14, 2013, 9:20 a.m., Philip Harvey wrote: I generally like what you're doing here. My only real concern is that the tests folder is starting to look rather complicated. To some extent this is unavoidable. However, I do have some suggestions about how to mitigate this: - To my

Review Request: Proton-223: Need system-level and soak tests to exercise Proton

2013-03-13 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9903/ --- Review request for qpid, Rafael Schloming and Justin Ross. Description ---

Re: Review Request: Proton-223: Need system-level and soak tests to exercise Proton

2013-03-13 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9903/#review17807 --- /proton/trunk/tests/python/common.py