Re: Review Request: QPID-4555: HA Add QueueSettings::declaredExclusive for exclusive queues.

2013-02-07 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9258/ --- (Updated Feb. 7, 2013, 6:50 p.m.) Review request for qpid, Gordon Sim, Kenneth G

Re: Review Request: QPID-4555: HA Add QueueSettings::declaredExclusive for exclusive queues.

2013-02-07 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9258/#review16284 --- Ship it! I can certainly live with this. I think I would have made

Re: Review Request: QPID-4555: HA Add QueueSettings::declaredExclusive for exclusive queues.

2013-02-07 Thread Alan Conway
> On Feb. 7, 2013, 6:59 p.m., Gordon Sim wrote: > > I can certainly live with this. I think I would have made > > QueueSettings::declaredExclusive be QueueSettings::replicate, again just to > > be very clear about what it means. However its slightly less an issue when > > its not actually exp

Re: Review Request: QPID-4555: HA Add QueueSettings::declaredExclusive for exclusive queues.

2013-02-07 Thread Alan Conway
> On Feb. 7, 2013, 6:59 p.m., Gordon Sim wrote: > > I can certainly live with this. I think I would have made > > QueueSettings::declaredExclusive be QueueSettings::replicate, again just to > > be very clear about what it means. However its slightly less an issue when > > its not actually exp

Re: Review Request: QPID-4555: HA Add QueueSettings::declaredExclusive for exclusive queues.

2013-02-07 Thread Gordon Sim
> On Feb. 7, 2013, 6:59 p.m., Gordon Sim wrote: > > I can certainly live with this. I think I would have made > > QueueSettings::declaredExclusive be QueueSettings::replicate, again just to > > be very clear about what it means. However its slightly less an issue when > > its not actually exp

Re: Review Request: QPID-4555: HA Add QueueSettings::declaredExclusive for exclusive queues.

2013-02-07 Thread Alan Conway
> On Feb. 7, 2013, 6:59 p.m., Gordon Sim wrote: > > I can certainly live with this. I think I would have made > > QueueSettings::declaredExclusive be QueueSettings::replicate, again just to > > be very clear about what it means. However its slightly less an issue when > > its not actually exp

Re: Review Request: QPID-4555: HA Add QueueSettings::declaredExclusive for exclusive queues.

2013-02-08 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9258/#review16344 --- /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp

Re: Review Request: QPID-4555: HA Add QueueSettings::declaredExclusive for exclusive queues.

2013-02-08 Thread Alan Conway
> On Feb. 8, 2013, 9:35 a.m., Gordon Sim wrote: > > /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp, line 297 > > > > > > Ok, how about the following change: > > > > settings.isTemporary = exclusive && autod