Review Request 13328: structured content over AMQP 1.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13328/ --- Review request for qpid. Bugs: QPID-5040 https://issues.apache.org/jira/bro

Re: Review Request 13328: structured content over AMQP 1.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13328/ --- (Updated Aug. 7, 2013, 3:31 p.m.) Review request for qpid. Changes --- T

Re: Review Request 13328: structured content over AMQP 1.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13328/#review24810 --- /trunk/qpid/cpp/include/qpid/messaging/Message.h

Re: Review Request 13328: structured content over AMQP 1.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13328/ --- (Updated Aug. 7, 2013, 7:17 p.m.) Review request for qpid. Changes --- A

Re: Review Request 13328: structured content over AMQP 1.0

> On Aug. 7, 2013, 5:22 p.m., Chug Rolke wrote: > > /trunk/qpid/cpp/include/qpid/messaging/Message.h, line 167 > > > > > > Please extend your commenting to these new methods. > > > > This will require addition

Re: Review Request 13328: structured content over AMQP 1.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13328/#review24805 --- Nice work - I think this will make using structured data significant

Re: Review Request 13328: structured content over AMQP 1.0

> On Aug. 7, 2013, 7:22 p.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/include/qpid/messaging/Message.h, line 45 > > > > > > To be consistent with the other constructors there should be one that > > takes a Variant n

Re: Review Request 13328: structured content over AMQP 1.0

> On Aug. 7, 2013, 7:22 p.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/include/qpid/messaging/Message.h, line 167 > > > > > > I wonder if the API convention here is misused. The API is pretty > > consistent in using

Re: Review Request 13328: structured content over AMQP 1.0

> On Aug. 7, 2013, 7:22 p.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/include/qpid/messaging/Message.h, line 167 > > > > > > I wonder if the API convention here is misused. The API is pretty > > consistent in using

Re: Review Request 13328: structured content over AMQP 1.0

> On Aug. 7, 2013, 7:22 p.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/src/qpid/types/encodings.h, line 26 > > > > > > I'm not sure a namespace is best here, maybe a struct with statics > > would be better here - in

Re: Review Request 13328: structured content over AMQP 1.0

> On Aug. 7, 2013, 7:22 p.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/src/qpid/types/encodings.h, line 26 > > > > > > I'm not sure a namespace is best here, maybe a struct with statics > > would be better here - in

Re: Review Request 13328: structured content over AMQP 1.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13328/#review24825 --- /trunk/qpid/cpp/src/qpid/types/encodings.h

Re: Review Request 13328: structured content over AMQP 1.0

> On Aug. 7, 2013, 7:22 p.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/include/qpid/messaging/Message.h, line 45 > > > > > > To be consistent with the other constructors there should be one that > > takes a Variant n

Re: Review Request 13328: structured content over AMQP 1.0

> On Aug. 7, 2013, 7:22 p.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/include/qpid/messaging/Message.h, line 45 > > > > > > To be consistent with the other constructors there should be one that > > takes a Variant n

Re: Review Request 13328: structured content over AMQP 1.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13328/ --- (Updated Aug. 8, 2013, 11:39 a.m.) Review request for qpid. Changes ---

Re: Review Request 13328: structured content over AMQP 1.0

> On Aug. 7, 2013, 7:22 p.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/include/qpid/messaging/Message.h, line 45 > > > > > > To be consistent with the other constructors there should be one that > > takes a Variant n

Re: Review Request 13328: structured content over AMQP 1.0

> On Aug. 7, 2013, 7:22 p.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/include/qpid/messaging/Message.h, line 45 > > > > > > To be consistent with the other constructors there should be one that > > takes a Variant n