On June 23, 2014, 3:31 p.m., Alan Conway wrote:
/trunk/qpid/python/qpid/messaging/endpoints.py, line 134
https://reviews.apache.org/r/22864/diff/2/?file=614978#file614978line134
You are no longer setting all the attribute to None at the outset. I
think that means attribute not
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22864/#review46611
---
All the automated test failures were due to a bug in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22864/#review46623
---
Ship it!
Two comments, otherwise it is good to go.
On June 25, 2014, 8:48 a.m., Pavel Moravec wrote:
All the automated test failures were due to a bug in
cpp/src/tests/brokertest.py that allowed connection option protocol to be
set to amqp1.0 even for native / 0-10 client. Below patch makes all tests
passing:
Index:
On June 23, 2014, 3:31 p.m., Alan Conway wrote:
/trunk/qpid/python/qpid/messaging/endpoints.py, line 169
https://reviews.apache.org/r/22864/diff/2/?file=614978#file614978line169
Missing self. on reconnect_interval
This if statement is long. May I suggest something
On June 23, 2014, 3:31 p.m., Alan Conway wrote:
/trunk/qpid/python/qpid/messaging/endpoints.py, line 169
https://reviews.apache.org/r/22864/diff/2/?file=614978#file614978line169
Missing self. on reconnect_interval
This if statement is long. May I suggest something
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22864/
---
(Updated June 24, 2014, 1:01 p.m.)
Review request for qpid, Alan Conway,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22864/
---
Review request for qpid, Alan Conway, Kenneth Giusti, Darryl Pierce, and Rafael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22864/#review46401
---
I have a suggestion to simplify the code, see comments on diff.
If
