Re: Review Request 23096: QPID-5855: JAVA Client Can not recieve message with qpid ha cluster "Session exception occured while trying to commit"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23096/#review51270 --- Ship it! Looks good to me; nice work! - Gordon Sim On Aug. 21, 2

Re: Review Request 23096: QPID-5855: JAVA Client Can not recieve message with qpid ha cluster "Session exception occured while trying to commit"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23096/ --- (Updated Aug. 21, 2014, 10:56 p.m.) Review request for qpid, Gordon Sim, rajith

Re: Review Request 23096: QPID-5855: JAVA Client Can not recieve message with qpid ha cluster "Session exception occured while trying to commit"

> On Aug. 21, 2014, 11:13 a.m., Robbie Gemmell wrote: > > Looking at the client code (I'll leave the code for people familiar with > > it), I can see where it (o.a.q.transport.Session#complete) would be aware > > of the gap and make the sync() method hold awaiting it being filled, and I > > th

Re: Review Request 23096: QPID-5855: JAVA Client Can not recieve message with qpid ha cluster "Session exception occured while trying to commit"

> On Aug. 21, 2014, 11:13 a.m., Robbie Gemmell wrote: > > Looking at the client code (I'll leave the code for people familiar with > > it), I can see where it (o.a.q.transport.Session#complete) would be aware > > of the gap and make the sync() method hold awaiting it being filled, and I > > th

Re: Review Request 23096: QPID-5855: JAVA Client Can not recieve message with qpid ha cluster "Session exception occured while trying to commit"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23096/#review51165 --- Looking at the client code (I'll leave the code for people familiar

Re: Review Request 23096: QPID-5855: JAVA Client Can not recieve message with qpid ha cluster "Session exception occured while trying to commit"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23096/ --- (Updated Aug. 20, 2014, 9:35 p.m.) Review request for qpid, Gordon Sim, rajith

Re: Review Request 23096: QPID-5855 JAVA Client Can not recieve message with qpid ha cluster "Session exception occured while trying to commit"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23096/#review46847 --- The code you highlighted around 'needSync' and the whole 'sync metho

Re: Review Request 23096: QPID-5855 JAVA Client Can not recieve message with qpid ha cluster "Session exception occured while trying to commit"

> On June 27, 2014, 8:27 a.m., Gordon Sim wrote: > > The client shouldn't have to do a full execution-sync. It should be > > sufficient to set the sync flag on the method. Skimming the broker code, I > > don't see where async handling for a commit would happen. It looks to me > > like perhaps

Re: Review Request 23096: QPID-5855 JAVA Client Can not recieve message with qpid ha cluster "Session exception occured while trying to commit"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23096/#review46845 --- The client shouldn't have to do a full execution-sync. It should be

Re: Review Request 23096: QPID-5855 JAVA Client Can not recieve message with qpid ha cluster "Session exception occured while trying to commit"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23096/ --- (Updated June 26, 2014, 10:27 p.m.) Review request for qpid, Gordon Sim, rajith

Review Request 23096: QPID-5855 JAVA Client Can not recieve message with qpid ha cluster "Session exception occured while trying to commit"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23096/ --- Review request for qpid, Gordon Sim, rajith attapattu, and Robbie Gemmell. Bugs