Re: Review Request 26829: CPP Broker and client - disable SSL protocols SSLv2 and SSLv3

2014-10-20 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26829/#review57310 --- Ship it! Looks fine to me, though I am no expert on NSS. One thing

Re: Review Request 26829: CPP Broker and client - disable SSL protocols SSLv2 and SSLv3

2014-10-20 Thread Kenneth Giusti
On Oct. 20, 2014, 8:44 a.m., Gordon Sim wrote: Looks fine to me, though I am no expert on NSS. One thing just to note, is that when the SSL port and the plain TCP pport are the same, there is a different codepath used that includes some version checking (see isSslStream() in

Re: Review Request 26829: CPP Broker and client - disable SSL protocols SSLv2 and SSLv3

2014-10-17 Thread Pavel Moravec
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26829/#review57130 --- I run various tests that all passed, including: - test script from

Review Request 26829: CPP Broker and client - disable SSL protocols SSLv2 and SSLv3

2014-10-16 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26829/ --- Review request for qpid and Gordon Sim. Bugs: qpid-6160