Re: Review Request 28770: Some engine examples and supporting library code

2014-12-11 Thread Rafael Schloming
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28770/#review64860 --- Ship it! Ship It! - Rafael Schloming On Dec. 9, 2014, 11:56

Re: Review Request 28770: Some engine examples and supporting library code

2014-12-09 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28770/ --- (Updated Dec. 9, 2014, 11:56 a.m.) Review request for qpid and Rafael

Re: Review Request 28770: Some engine examples and supporting library code

2014-12-09 Thread Gordon Sim
On Dec. 5, 2014, 10:24 p.m., Rafael Schloming wrote: proton-c/bindings/python/proton/__init__.py, line 3542 https://reviews.apache.org/r/28770/diff/1/?file=784021#file784021line3542 To expand on my question here, I'd also like to understand if this __getattr__ is just an

Re: Review Request 28770: Some engine examples and supporting library code

2014-12-08 Thread Gordon Sim
On Dec. 5, 2014, 9:06 p.m., Steve Huston wrote: Ship It! Steve Huston wrote: Great bunch of examples, Gordon! One thng that would be helpful at this point is a README to briefly describe the examples that are there and how they're paired up (send/recv, when they are). I agree and

Re: Review Request 28770: Some engine examples and supporting library code

2014-12-08 Thread Gordon Sim
On Dec. 5, 2014, 10:13 p.m., Rafael Schloming wrote: proton-c/bindings/python/proton/__init__.py, line 3488 https://reviews.apache.org/r/28770/diff/1/?file=784021#file784021line3488 Isn't there some redundancy here? For example this hasattr check is redudant with the clazz ==

Re: Review Request 28770: Some engine examples and supporting library code

2014-12-08 Thread Gordon Sim
On Dec. 5, 2014, 10:24 p.m., Rafael Schloming wrote: proton-c/bindings/python/proton/__init__.py, line 3542 https://reviews.apache.org/r/28770/diff/1/?file=784021#file784021line3542 To expand on my question here, I'd also like to understand if this __getattr__ is just an

Re: Review Request 28770: Some engine examples and supporting library code

2014-12-08 Thread Rafael Schloming
On Dec. 5, 2014, 10:24 p.m., Rafael Schloming wrote: proton-c/bindings/python/proton/__init__.py, line 3542 https://reviews.apache.org/r/28770/diff/1/?file=784021#file784021line3542 To expand on my question here, I'd also like to understand if this __getattr__ is just an

Re: Review Request 28770: Some engine examples and supporting library code

2014-12-08 Thread Gordon Sim
On Dec. 5, 2014, 10:24 p.m., Rafael Schloming wrote: proton-c/bindings/python/proton/__init__.py, line 3542 https://reviews.apache.org/r/28770/diff/1/?file=784021#file784021line3542 To expand on my question here, I'd also like to understand if this __getattr__ is just an

Re: Review Request 28770: Some engine examples and supporting library code

2014-12-05 Thread Steve Huston
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28770/#review64083 --- Ship it! Ship It! - Steve Huston On Dec. 5, 2014, 8:55 p.m.,

Re: Review Request 28770: Some engine examples and supporting library code

2014-12-05 Thread Steve Huston
On Dec. 5, 2014, 9:06 p.m., Steve Huston wrote: Ship It! Great bunch of examples, Gordon! One thng that would be helpful at this point is a README to briefly describe the examples that are there and how they're paired up (send/recv, when they are). - Steve

Re: Review Request 28770: Some engine examples and supporting library code

2014-12-05 Thread Rafael Schloming
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28770/#review64091 --- proton-c/bindings/python/proton/__init__.py

Re: Review Request 28770: Some engine examples and supporting library code

2014-12-05 Thread Rafael Schloming
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28770/#review64096 --- proton-c/bindings/python/proton/__init__.py