Re: Review Request 36992: PROTON-886 and PROTON-930 -- handle_max and AMQP numeric default constants

2015-08-05 Thread michael goulish
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36992/ --- (Updated Aug. 5, 2015, 9:52 a.m.) Review request for qpid, Kenneth Giusti and

Re: Review Request 36992: PROTON-886 and PROTON-930 -- handle_max and AMQP numeric default constants

2015-08-05 Thread michael goulish
On July 31, 2015, 8:27 p.m., Kenneth Giusti wrote: proton-c/src/engine/engine.c, line 2230 https://reviews.apache.org/r/36992/diff/1/?file=1026182#file1026182line2230 use pn_min() in utils.h Wow we ... have a min macro. I... That'sOK! Absolutely. On July 31, 2015,

Re: Review Request 36992: PROTON-886 and PROTON-930 -- handle_max and AMQP numeric default constants

2015-08-05 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36992/#review94317 --- Ship it! Ship It! - Kenneth Giusti On Aug. 5, 2015, 9:52 a.m.,

Review Request 36992: PROTON-886 and PROTON-930 -- handle_max and AMQP numeric default constants

2015-07-31 Thread michael goulish
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36992/ --- Review request for qpid, Kenneth Giusti and Ted Ross. Repository:

Re: Review Request 36992: PROTON-886 and PROTON-930 -- handle_max and AMQP numeric default constants

2015-07-31 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36992/#review93765 --- proton-c/bindings/python/proton/__init__.py (line 2571)