Re: Review Request 59108: PROTON-1466: proton-c mixing up links with names that are prefixes

2017-05-10 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59108/#review174548 --- Ship it! Ship It! - Andrew Stitcher On May 10, 2017, 8:34

Re: Review Request 59108: PROTON-1466: proton-c mixing up links with names that are prefixes

2017-05-10 Thread Alan Conway
> On May 10, 2017, 7:21 p.m., Andrew Stitcher wrote: > > I think centralising the comparison is clearly the correct thing to do. > > > > I note that you could create a Macro that defines a constant symbol without > > having to manually count the size: > > > > #define MKSYMBOL(X)

Re: Review Request 59108: PROTON-1466: proton-c mixing up links with names that are prefixes

2017-05-10 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59108/ --- (Updated May 10, 2017, 8:34 p.m.) Review request for qpid, Andrew Stitcher and

Re: Review Request 59108: PROTON-1466: proton-c mixing up links with names that are prefixes

2017-05-10 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59108/#review174528 --- I think centralising the comparison is clearly the correct thing

Re: Review Request 59108: PROTON-1466: proton-c mixing up links with names that are prefixes

2017-05-10 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59108/ --- (Updated May 10, 2017, 6:48 p.m.) Review request for qpid and Gordon Sim.

Re: Review Request 59108: PROTON-1466: proton-c mixing up links with names that are prefixes

2017-05-09 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59108/#review174377 --- Ship it! Ship It! - Gordon Sim On May 9, 2017, 8:24 p.m.,

Review Request 59108: PROTON-1466: proton-c mixing up links with names that are prefixes

2017-05-09 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59108/ --- Review request for qpid and Gordon Sim. Bugs: PROTON-1466