Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/20
@pateljm You might want to try add back the else case of `MAKE_JOBS=2` for
`clang`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/17
@pateljm This PR is ready to merge, and has sync-ed with the master. Please
take another look. Thanks!
As for adding a document regarding how to add a new operator, we should do
so in
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/20
@pateljm Before merging this PR, we need to rebase w/ master to get rid of
previous merged commits.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66543912
--- Diff: storage/InsertDestination.cpp ---
@@ -60,25 +60,28 @@ InsertDestination::InsertDestination(const
CatalogRelationSchema ,
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/5
@navsan Do you have any insights regarding the clang linking issues? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user navsan commented on the issue:
https://github.com/apache/incubator-quickstep/pull/23
Spoke to @hbdeshmukh offline. I don't currently have tcmalloc working on
either of my dev boxes, so I'll debug this with his help by tomorrow.
Note that this is currently affecting
Github user pateljm commented on the issue:
https://github.com/apache/incubator-quickstep/pull/23
LGTM. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user pateljm commented on the issue:
https://github.com/apache/incubator-quickstep/pull/22
LGTM. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/14
@hbdeshmukh We have to rebase again, as we had "git merge" again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66495816
--- Diff: cli/QuickstepCli.cpp ---
@@ -323,13 +326,20 @@ int main(int argc, char* argv[]) {
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66492947
--- Diff: cli/CommandExecutor.cpp ---
@@ -194,11 +198,14 @@ void executeDescribeTable(
/**
* @brief A helper function that executes a SQL
Github user navsan commented on the issue:
https://github.com/apache/incubator-quickstep/pull/21
Comparing Travis run times for this PR
(https://travis-ci.org/apache/incubator-quickstep/builds/136474629) with one
from earlier today
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/14
Hi @zuyu The rebase is complete.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user navsan commented on the issue:
https://github.com/apache/incubator-quickstep/pull/20
@pateljm I think you should set MAKE_JOBS to 1 for Selection as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user navsan commented on the issue:
https://github.com/apache/incubator-quickstep/pull/20
GCC with VECTOR_COPY_ELISION_LEVEL=Selection failed in both debug and
release modes. It's the same internal compiler error.
Does the number of concurrently running jobs affect
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/20
@pateljm How about trying with all the four options to see the time to
take, and then go with there?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/19#discussion_r66470811
--- Diff: relational_operators/TextScanOperator.cpp ---
@@ -155,116 +63,50 @@ bool TextScanOperator::getAllWorkOrders(
InsertDestination
GitHub user pateljm opened a pull request:
https://github.com/apache/incubator-quickstep/pull/20
Change the vector elision from `none` to `selection`
The default VECTOR_COPY_ELISION_LEVEL is selection, so test that instead of
none.
You can merge this pull request into a Git
Github user pateljm commented on the issue:
https://github.com/apache/incubator-quickstep/pull/19
@zuyu -- I think it is perfectly fine for you go clean it up and open a new
PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/19#discussion_r66455959
--- Diff: relational_operators/TextScanOperator.cpp ---
@@ -155,116 +63,50 @@ bool TextScanOperator::getAllWorkOrders(
InsertDestination
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user pateljm commented on the issue:
https://github.com/apache/incubator-quickstep/pull/19
@jianqiao This is fantastic! This is going to making a huge difference when
loading large datasets. LGTM. As a perspective loading SSB used to take about
2800 seconds. Huge 6X
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/19
Improve text scan operator
This PR updates the `TextScanOperator` to improve its performance.
There are three main changes:
(1) Pass `text_offset` and `text_segment_size`
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/18
Fix a potential segfault in CompressedBlockBuilder
This PR fixes a potential bug in `CompressedBlockBuilder`. This fix is
necessary for a subsequent PR on `TextScanOperator` where each
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/17
Serialized WorkOrders as proto.
This large PR serializes `WorkOrders` as a proto, as a part of achieving
distributed version.
Note that this would affect the on-going work for
26 matches
Mail list logo
