[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66716091 --- Diff: query_execution/Foreman.hpp --- @@ -22,46 +22,40 @@ #include #include -#include "catalog/CatalogTypedefs.hpp"

Re: Code Style Guidelines and Code Review pages added to ASF wiki

Yeah, but I’m wondering if, using a git hook, we can automate away all formatting checks, so that we don’t spend so much time commenting/discussing/arguing about formatting changes in the PRs. > On Jun 11, 2016, at 23:03, Jignesh Patel wrote: > > Hi Nav, > > We do have

Code Style Guidelines and Code Review pages added to ASF wiki

Folks: Added two pages to the ASF wiki under the How-to page. You can visit them by going here: https://cwiki.apache.org/confluence/display/QUICKSTEP/How-to+articles Comments welcome! Cheers, Jignesh  

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66713602 --- Diff: query_execution/QueryContext.proto --- @@ -54,4 +54,6 @@ message QueryContext { // NOTE(zuyu): For UpdateWorkOrder only.

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66713594 --- Diff: query_execution/PolicyEnforcer.hpp --- @@ -0,0 +1,168 @@ +/** + * Copyright 2016, Quickstep Research Group, Computer

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66713568 --- Diff: query_execution/Foreman.hpp --- @@ -22,46 +22,40 @@ #include #include -#include "catalog/CatalogTypedefs.hpp"

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66713553 --- Diff: query_execution/Foreman.cpp --- @@ -22,355 +22,189 @@ #include #include -#include "catalog/CatalogDatabase.hpp"

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66713074 --- Diff: query_execution/PolicyEnforcer.hpp --- @@ -0,0 +1,168 @@ +/** + * Copyright 2016, Quickstep Research Group, Computer

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66709222 --- Diff: query_execution/Foreman.cpp --- @@ -22,355 +22,189 @@ #include #include -#include "catalog/CatalogDatabase.hpp"

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66706036 --- Diff: query_execution/Foreman.cpp --- @@ -22,355 +22,189 @@ #include #include -#include "catalog/CatalogDatabase.hpp"