Re: Guideline To Update Copyright Header

> +1 to keeping the NOTICE file as short as possible. Some projects get into > the habit of adding copyrights & notices merely out of “courtesy” but that > imposes a burden on downstream projects (who are obliged by the ASL to pass > on the NOTICE file intact). > > Julian Thanks Julian for

[GitHub] incubator-quickstep pull request #29: Fix bug: specify log file name correct...

GitHub user navsan opened a pull request: https://github.com/apache/incubator-quickstep/pull/29 Fix bug: specify log file name correctly I introduced a bug during one of the many merges! You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-quickstep issue #22: Add a shell script that logs the build proces...

Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/22 @navsan FYI, please edit the squashed commit messages when doing squashing. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-quickstep issue #28: Add option to enable Google Profiler.

Github user navsan commented on the issue: https://github.com/apache/incubator-quickstep/pull/28 Thanks Zuyu! > On Jun 13, 2016, at 16:56, Zuyu ZHANG wrote: > > Merged! > > — > You are receiving this because you were

[GitHub] incubator-quickstep pull request #28: Add option to enable Google Profiler.

Github user asfgit closed the pull request at: https://github.com/apache/incubator-quickstep/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-quickstep issue #28: Add option to enable Google Profiler.

Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/28 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-quickstep pull request #28: Add option to enable Google Profiler.

Github user navsan commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/28#discussion_r66870439 --- Diff: cli/QuickstepCli.cpp --- @@ -430,6 +445,13 @@ int main(int argc, char* argv[]) { reset_parser = true; break;

[GitHub] incubator-quickstep pull request #28: Add option to enable Google Profiler.

Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/28#discussion_r66870133 --- Diff: cli/QuickstepCli.cpp --- @@ -430,6 +445,13 @@ int main(int argc, char* argv[]) { reset_parser = true; break;

[GitHub] incubator-quickstep pull request #22: Add a shell script that logs the build...

Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/22#discussion_r66869747 --- Diff: build/profile_build.sh --- @@ -0,0 +1,111 @@ +#!/bin/bash +# This script may be useful for developers to profile the build process

[GitHub] incubator-quickstep issue #28: Add option to enable Google Profiler.

Github user navsan commented on the issue: https://github.com/apache/incubator-quickstep/pull/28 Thanks. I'll resolve and resubmit. I seem to have messed something up in my local branch. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-quickstep pull request #22: Add a shell script that logs the build...

Github user navsan commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/22#discussion_r66854343 --- Diff: build/profile_build.sh --- @@ -0,0 +1,111 @@ +#!/bin/bash +# This script may be useful for developers to profile the build

[GitHub] incubator-quickstep pull request #28: Add option to enable Google Profiler.

Github user navsan commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/28#discussion_r66851286 --- Diff: cli/QuickstepCli.cpp --- @@ -150,6 +154,14 @@ DEFINE_bool(initialize_db, false, "If true, initialize a database.");

Re: Guideline To Update Copyright Header

> On Jun 13, 2016, at 8:01 AM, Jignesh Patel wrote: > > Please note it is my understanding that we don’t need to add our individual > names or organization names to the NOTICE file, so don’t need to grow the > list in the NOTICE file. +1 to keeping the NOTICE file as

[GitHub] incubator-quickstep pull request #22: Add a shell script that logs the build...

Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/22#discussion_r66828192 --- Diff: build/profile_build.sh --- @@ -0,0 +1,111 @@ +#!/bin/bash +# This script may be useful for developers to profile the build process

[GitHub] incubator-quickstep pull request #28: Add option to enable Google Profiler.

Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/28#discussion_r66825014 --- Diff: cli/QuickstepCli.cpp --- @@ -150,6 +154,14 @@ DEFINE_bool(initialize_db, false, "If true, initialize a database.");

[GitHub] incubator-quickstep issue #14: QUICKSTEP-8: Long running Foreman thread

Github user pateljm commented on the issue: https://github.com/apache/incubator-quickstep/pull/14 LGTM. Merging. Let's handle any remaining issues re. reordering parameters in a separate PR. --- If your project is set up for it, you can reply to this email and have your reply appear

Re: Guideline To Update Copyright Header

Thanks Roman! To not disturb the ongoing work in existing PRs, I can take care of fixing the copyright in all existing files once we have closed the existing PRs (upto PR #28) . I’ll write a sed script to make the switch. Tentatively, lets plan on running this script this on Thursday 6/16 at