[GitHub] incubator-quickstep issue #103: QUICKSTEP-46 Fault tolerance in bulk loading...

2016-10-05 Thread zuyu
Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/103 @tarunbansal To clarify, I mean to dump the flaky tuples `at the end` of query execution, either to `stdout` or a new file. --- If your project is set up for it, you can reply to this emai

[GitHub] incubator-quickstep issue #109: Refactored SplitRowStore bulk insertion

2016-10-05 Thread cramja
Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/109 @hbdeshmukh I updated for TPCH in the PR header --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

TPCH 100

2016-10-05 Thread Marc Spehlmann
Hey 2 questions about TPCH sf100. (1) On a cloud lab box, I am having trouble getting query 17 to finish. It seems to be stuck in Hash table operations. Any ideas/experience? (2) Anyone got the link to the spreadsheet with benchmark results? -Marc

[GitHub] incubator-quickstep issue #109: Refactored SplitRowStore bulk insertion

2016-10-05 Thread cramja
Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/109 @hbdeshmukh do we have any recent TPCH 100 results from a CloudLab box? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-quickstep issue #109: Refactored SplitRowStore bulk insertion

2016-10-05 Thread cramja
Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/109 Thanks @hakanmemisoglu I tried something similar to what you were suggesting and the "works but I don't know why" solution I found was to declare the variables inside the lambda. It's eve

[GitHub] incubator-quickstep issue #109: Refactored SplitRowStore bulk insertion

2016-10-05 Thread cramja
Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/109 @hbdeshmukh 2x improvement was for the contrived test of trying to insert a whole bunch of tuples into a Splitrow at once as in PR100. As for TPCH, I'm not sure, other than that this is n

[GitHub] incubator-quickstep issue #109: Refactored SplitRowStore bulk insertion

2016-10-05 Thread navsan
Github user navsan commented on the issue: https://github.com/apache/incubator-quickstep/pull/109 This bug was filed and fixed a year ago in 5.3, I think. It had been around for 2-3 years, so we’ll probably be affected in older versions of GCC too. https://gcc.gnu.org/bugzilla/s

[GitHub] incubator-quickstep issue #109: Refactored SplitRowStore bulk insertion

2016-10-05 Thread hakanmemisoglu
Github user hakanmemisoglu commented on the issue: https://github.com/apache/incubator-quickstep/pull/109 Hi @cramja, the problem might be related lambda capture arguments. GCC 5 was giving the same problems if you use general capture by reference [&]. You can try to give specific ref

[GitHub] incubator-quickstep issue #109: Refactored SplitRowStore bulk insertion

2016-10-05 Thread navsan
Github user navsan commented on the issue: https://github.com/apache/incubator-quickstep/pull/109 Have you tried with a newer or older version of GCC5? > On Oct 5, 2016, at 14:54, Marc S wrote: > > internal compiler error: in tsubst_copy --- If your project i

[GitHub] incubator-quickstep issue #109: Refactored SplitRowStore bulk insertion

2016-10-05 Thread hbdeshmukh
Github user hbdeshmukh commented on the issue: https://github.com/apache/incubator-quickstep/pull/109 @cramja Do you mean TPC-H SF100 Q1-Q17 has 2x improvement? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] incubator-quickstep issue #109: Refectored bulk insertion to the SplitRow st...

2016-10-05 Thread cramja
Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/109 Note: this crashes GCC5. I'm not sure what to do about this. Maybe @navsan or @hakanmemisoglu (hakan the compiler man) might have some advice. ``` ]’ /fastdisk/quickstep

[GitHub] incubator-quickstep pull request #109: Refectored bulk insertion to the Spli...

2016-10-05 Thread cramja
GitHub user cramja opened a pull request: https://github.com/apache/incubator-quickstep/pull/109 Refectored bulk insertion to the SplitRow store The inner loop of the insert algorithm has been changed to reduce function calls to only those that are absolutely necessary. Also, we mer

[GitHub] incubator-quickstep issue #100: Refactor bulk insert for SplitRowStore

2016-10-05 Thread cramja
Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/100 I'm closing this PR in favor of another which uses a technique to merge attribute copies when possible. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] incubator-quickstep pull request #100: Refactor bulk insert for SplitRowStor...

2016-10-05 Thread cramja
Github user cramja closed the pull request at: https://github.com/apache/incubator-quickstep/pull/100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-quickstep pull request #106: Improve StarSchemaSimpleCostModel to ...

2016-10-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-quickstep/pull/106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-quickstep issue #106: Improve StarSchemaSimpleCostModel to provide...

2016-10-05 Thread hbdeshmukh
Github user hbdeshmukh commented on the issue: https://github.com/apache/incubator-quickstep/pull/106 Looks good, merging. Thanks @jianqiao for the feature. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-quickstep pull request #108: Remove unnecessary code from FastSepa...

2016-10-05 Thread hbdeshmukh
GitHub user hbdeshmukh opened a pull request: https://github.com/apache/incubator-quickstep/pull/108 Remove unnecessary code from FastSeparateChainingHashTable::resize() - In resize, all the values are moved from original hash table are copied to the new hash table using memcpy

[GitHub] incubator-quickstep pull request #107: Fix memory leak in FastSeparateChaini...

2016-10-05 Thread hbdeshmukh
GitHub user hbdeshmukh opened a pull request: https://github.com/apache/incubator-quickstep/pull/107 Fix memory leak in FastSeparateChaining hash table - Destruction of payload in hash table. - Separate phases of payload destruction of aggregation hash tables. - First the pay

[GitHub] incubator-quickstep issue #106: Improve StarSchemaSimpleCostModel to provide...

2016-10-05 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/106 @hbdeshmukh There is no need to reload the data or run \analyze again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-quickstep issue #106: Improve StarSchemaSimpleCostModel to provide...

2016-10-05 Thread hbdeshmukh
Github user hbdeshmukh commented on the issue: https://github.com/apache/incubator-quickstep/pull/106 Hi @jianqiao I have a dataset on which \analyze was ran already. Do I need to reload the data for the changes in this PR to be effective? --- If your project is set up for