Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/122
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/122
Looks good to me, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/121#discussion_r84796400
--- Diff: storage/StorageBlock.cpp ---
@@ -1369,4 +1369,77 @@ const std::size_t StorageBlock::getNumTuples() const
{
return
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/121#discussion_r84796051
--- Diff: storage/PartitionedHashTablePool.hpp ---
@@ -0,0 +1,224 @@
+/**
+ * Copyright 2016, Quickstep Research Group, Computer
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/122
Comments addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/121#discussion_r84795775
--- Diff: storage/PartitionedHashTablePool.hpp ---
@@ -0,0 +1,224 @@
+/**
+ * Copyright 2016, Quickstep Research Group, Computer
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/121#discussion_r84793516
--- Diff: storage/AggregationOperationState.hpp ---
@@ -172,12 +173,44 @@ class AggregationOperationState {
**/
void
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/121#discussion_r84792130
--- Diff: relational_operators/FinalizeAggregationOperator.cpp ---
@@ -41,12 +41,29 @@ bool FinalizeAggregationOperator::getAllWorkOrders(
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/122#discussion_r84789328
--- Diff: storage/StorageBlock.cpp ---
@@ -340,22 +340,16 @@ void StorageBlock::sample(const bool is_block_sample,
}
void
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/122#discussion_r84787343
--- Diff: relational_operators/SelectOperator.cpp ---
@@ -210,23 +242,39 @@ serialization::WorkOrder*
10 matches
Mail list logo
