[GitHub] incubator-quickstep pull request #215: Used an alternative implementation fo...

2017-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-quickstep/pull/215 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-quickstep pull request #213: Added script for release license audi...

2017-03-16 Thread hbdeshmukh
Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/213#discussion_r106575102 --- Diff: release/release_cmds.sh --- @@ -100,6 +101,23 @@ publish_candidate() { cd $BASE_DIR } +release_audit() { +

[GitHub] incubator-quickstep issue #213: Added script for release license audit

2017-03-16 Thread hbdeshmukh
Github user hbdeshmukh commented on the issue: https://github.com/apache/incubator-quickstep/pull/213 Looks good to me, the audit feature should be really useful. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] incubator-quickstep pull request #215: Used an alternative implementation fo...

2017-03-16 Thread zuyu
GitHub user zuyu opened a pull request: https://github.com/apache/incubator-quickstep/pull/215 Used an alternative implementation for the proto map. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-quickstep fix-p

[GitHub] incubator-quickstep pull request #214: DO NOT MERGE: Built the protobuf from...

2017-03-16 Thread zuyu
Github user zuyu closed the pull request at: https://github.com/apache/incubator-quickstep/pull/214 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] incubator-quickstep pull request #214: DO NOT MERGE: Built the protobuf from...

2017-03-16 Thread zuyu
GitHub user zuyu opened a pull request: https://github.com/apache/incubator-quickstep/pull/214 DO NOT MERGE: Built the protobuf from the source for the map support. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator

[GitHub] incubator-quickstep pull request #213: Added script for release license audi...

2017-03-16 Thread cramja
Github user cramja commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/213#discussion_r106544574 --- Diff: release/release_cmds.sh --- @@ -50,14 +51,14 @@ create_artifacts() { # Make the signature. This requires human input gpg -

[GitHub] incubator-quickstep pull request #213: Added script for release license audi...

2017-03-16 Thread cramja
GitHub user cramja opened a pull request: https://github.com/apache/incubator-quickstep/pull/213 Added script for release license audit @hbdeshmukh Take a look, this will be useful in the future. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-quickstep issue #212: Fixed headers in some files

2017-03-16 Thread cramja
Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/212 LTGM, covers what Josh said in the @dev chat. There's still more to do in the NOTICE/LICENSE file, however. --- If your project is set up for it, you can reply to this email and have you

[GitHub] incubator-quickstep pull request #212: Fixed headers in some files

2017-03-16 Thread hbdeshmukh
GitHub user hbdeshmukh opened a pull request: https://github.com/apache/incubator-quickstep/pull/212 Fixed headers in some files You can merge this pull request into a Git repository by running: $ git pull https://github.com/hbdeshmukh/incubator-quickstep rc0.1-header-fixes