Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/230
For this PR, we could add two new classes: `client` and `server`, and a
unit test to test the communication path between both. No need changes to any
existing source code files.
---
If yo
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110560109
--- Diff: cli/SingleNodeServer.proto ---
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contrib
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110560093
--- Diff: CMakeLists.txt ---
@@ -145,6 +145,7 @@ if (ENABLE_VECTOR_PREDICATE_SHORT_CIRCUIT)
)
endif()
+option(ENABLE_SINGLE_NO
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110542826
--- Diff: cli/SingleNodeServer.proto ---
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contr
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110542764
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110542523
--- Diff: CMakeLists.txt ---
@@ -145,6 +145,7 @@ if (ENABLE_VECTOR_PREDICATE_SHORT_CIRCUIT)
)
endif()
+option(ENABLE_SINGLE_
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110542459
--- Diff: cli/CMakeLists.txt ---
@@ -44,6 +44,20 @@ configure_file (
"${CMAKE_CURRENT_BINARY_DIR}/CliConfig.h"
)
+# Compile
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110542406
--- Diff: cli/CMakeLists.txt ---
@@ -44,6 +44,20 @@ configure_file (
"${CMAKE_CURRENT_BINARY_DIR}/CliConfig.h"
)
+# Compile
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110542269
--- Diff: cli/CMakeLists.txt ---
@@ -44,6 +44,20 @@ configure_file (
"${CMAKE_CURRENT_BINARY_DIR}/CliConfig.h"
)
+# Compile
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/230
@zuyu Thank you for the review
Here's a possibility based on your overall comment: I could add the IOBase
and its subclass GrpcWrapper to this PR. The IOBase abstracts around all
10 matches
Mail list logo
