Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/232
After @hbdeshmukh and I's code review, we created:
* QUICKSTEP-90
* QUICKSTEP-91
in response to some of the issues we found. @zuyu 90 will address the async
up
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r113041261
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r113040305
--- Diff: CMakeLists.txt ---
@@ -145,6 +145,7 @@ if (ENABLE_VECTOR_PREDICATE_SHORT_CIRCUIT)
)
endif()
+option
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/240#discussion_r113038771
--- Diff: query_optimizer/rules/ReuseAggregateExpressions.cpp ---
@@ -194,7 +194,7 @@ P::PhysicalPtr ReuseAggregateExpressions::applyToNode
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/232
@zuyu Thank you for review. I addressed the minor stuff and will look into
Async when I have more time this coming week.
---
If your project is set up for it, you can reply to this
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112837404
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,286 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112836758
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,286 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112836622
--- Diff: cli/NetworkCliClientMain.cpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112836342
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112836146
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112836065
--- Diff: cli/CMakeLists.txt ---
@@ -15,7 +15,6 @@
# specific language governing permissions and limitations
# under the License
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112835877
--- Diff: cli/Flags.cpp ---
@@ -87,4 +87,25 @@ DEFINE_bool(preload_buffer_pool, false,
"accepting queries (should als
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112835858
--- Diff: cli/Flags.cpp ---
@@ -87,4 +87,25 @@ DEFINE_bool(preload_buffer_pool, false,
"accepting queries (should als
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112788365
--- Diff: cli/tests/CMakeLists.txt ---
@@ -32,6 +32,17 @@ if (ENABLE_DISTRIBUTED)
"${PROJECT_SOURCE_DIR}/ut
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112788031
--- Diff: cli/NetworkCliClient.hpp ---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112787479
--- Diff: cli/NetworkCliClient.hpp ---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/232
I should also mention that @hbdeshmukh and I had a discussion yesterday
about refactoring the CLI main method. I was unhappy with how cluttered seeming
it has become, and this PR only
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/232
@zuyu Thank you for review. Regarding the question about mutexes and
cond_var in the `NetworkCliServiceImpl`, we disallow multiple gRPC threads from
submitting requests at the same time
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112686604
--- Diff: CMakeLists.txt ---
@@ -145,6 +145,7 @@ if (ENABLE_VECTOR_PREDICATE_SHORT_CIRCUIT)
)
endif()
+option
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/236
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/234
LTM if comments are addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/234#discussion_r112333485
--- Diff: relational_operators/UnionAllOperator.hpp ---
@@ -149,6 +151,11 @@ class UnionAllOperator : public RelationalOperator
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/234#discussion_r11271
--- Diff: relational_operators/UnionAllOperator.cpp ---
@@ -128,14 +128,56 @@ bool UnionAllOperator::getAllWorkOrders(
}
bool
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/234#discussion_r112333067
--- Diff: relational_operators/UnionAllOperator.cpp ---
@@ -128,14 +128,56 @@ bool UnionAllOperator::getAllWorkOrders(
}
bool
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112325082
--- Diff: cli/LineReaderBuffered.hpp ---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112324538
--- Diff: cli/LineReaderBuffered.hpp ---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112324457
--- Diff: cli/LineReaderBuffered.cpp ---
@@ -0,0 +1,67 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112323095
--- Diff: cli/LineReaderBuffered.cpp ---
@@ -0,0 +1,67 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112322839
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/232
Thanks @hbdeshmukh , fixed validate_cmakelists issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/232
@hbdeshmukh I created a ticket `QUICKSTEP-87`; maybe you can show me how to
link to this PR later.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/232
Adds network cli interface.
# Adds Network CLI functionality to Single Node
**Functional Changes include:**
Then, run quickstep in `network` mode (defaults to `local
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/230
@zuyu I'm going to close this PR and submit another one with the tests as I
think the content has changed sufficiently enough to have another PR
---
If your project is set up f
Github user cramja closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/230
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110542826
--- Diff: cli/SingleNodeServer.proto ---
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110542764
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110542523
--- Diff: CMakeLists.txt ---
@@ -145,6 +145,7 @@ if (ENABLE_VECTOR_PREDICATE_SHORT_CIRCUIT)
)
endif()
+option
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110542459
--- Diff: cli/CMakeLists.txt ---
@@ -44,6 +44,20 @@ configure_file (
"${CMAKE_CURRENT_BINARY_DIR}/CliConfig.h"
)
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110542406
--- Diff: cli/CMakeLists.txt ---
@@ -44,6 +44,20 @@ configure_file (
"${CMAKE_CURRENT_BINARY_DIR}/CliConfig.h"
)
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110542269
--- Diff: cli/CMakeLists.txt ---
@@ -44,6 +44,20 @@ configure_file (
"${CMAKE_CURRENT_BINARY_DIR}/CliConfig.h"
)
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/230
@zuyu Thank you for the review
Here's a possibility based on your overall comment: I could add the IOBase
and its subclass GrpcWrapper to this PR. The IOBase abstracts aroun
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/230
Oh shoot, so no Travis for dist?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/230
@zuyu is there something special we specify in Travis to get Proto3?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/230
Initial SingleNodeClient implementation
This is the first part of a couple of PRs which will implement basic server
functionality in QS. The basic usage of the client is
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/228
D'oh I think what I read was `EOF` and was thinking, wtf, do I add a EOF?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/228
What is an EOL? I thought what you were saying was to add a `\n` but is
that not it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/228
@zuyu updated. I tried adding a new line but it doesn't seem to be added on
github. Does it really matter? If not, I'll merge
---
If your project is set up for it, you can rep
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/228
Refactored out proto GenerateCPP function
Refactored out the GenProto methods from the main cmakelist. This cuts down
on clutter and is something I ran into when making the single-node
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/226
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/226#discussion_r109448735
--- Diff: storage/AggregationOperationState.cpp ---
@@ -949,9 +949,15 @@ void
AggregationOperationState::finalizeHashTableImplThreadPrivate
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/212
I am working on the license file now- I sent out a question to Josh about
which clauses to include. How about we wait on this PR and I'll have the
changes for LICENSE soon and w
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/213
Sure, also I merged while doing that. I think it's kosher so long as
someone looked over the PR w/ a +1.
---
If your project is set up for it, you can reply to this email and have
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/213#discussion_r106643961
--- Diff: release/release_cmds.sh ---
@@ -100,6 +101,23 @@ publish_candidate() {
cd $BASE_DIR
}
+release_audit
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/213#discussion_r106544574
--- Diff: release/release_cmds.sh ---
@@ -50,14 +51,14 @@ create_artifacts() {
# Make the signature. This requires human input
gpg
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/213
Added script for release license audit
@hbdeshmukh Take a look, this will be useful in the future.
You can merge this pull request into a Git repository by running:
$ git pull
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/212
LTGM, covers what Josh said in the @dev chat. There's still more to do in
the NOTICE/LICENSE file, however.
---
If your project is set up for it, you can reply to this email and
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/208
@zuyu FYI I merged this branch and it appears as merged in the apache repo
but it seems as though the git mirror is lagging behind.
I can close it once it updates, or please do
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/208
@zuyu I'll merge it now because Travis is acting up and I saw your earlier
CI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/208
That would be great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/208
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/207
These are small changes. Also, travis is failing because of a whitespace
issue addressed in #206 . I will merge this now.
---
If your project is set up for it, you can reply to this
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/207
Added dockerfile for release testing
Many people have asked for the dockerfile I've been using to test the
release. In light of this, I'll add it to the main repo.
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/206
fixes travis ws issue
This is going to fix a whitespace issue which is causing travis to fail. I
will merge this before creating RC6.
You can merge this pull request into a Git
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/203#discussion_r104319132
--- Diff: release/release_cmds.sh ---
@@ -25,6 +25,7 @@ create_artifacts() {
export RELEASE_DIR=`pwd`
cd ..
+ export
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/203
I have no objections ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/205
simplify logic of download script
In prep for RC6, @zuyu recommended making a small change to the patch
script.
Now it should be explicit as to exactly what files are being
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/204
@hbdeshmukh this should go in before RC6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/204
Cmake changes for default build
This fixes two annoying build issues
1. If the CMAKEBUILDTYPE is not set by the user, it previously defaulted to
none-type which caused one of
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/203
@hbdeshmukh This one will be good to have in before the next release
candidate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/203
fixes bug in ordering of cmds
Minor bugfixes to the release scripts. Previously I was saving the wrong
directories to environment variables. Also, adding grep to one of the commands
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/199
@jianqiao it's gtg
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/189
@zuyu I cannot recreate the issue you are describing.
```
Starting Quickstep with 8 worker thread(s) and a 11.20 GB buffer pool.
--num_workers is 8, but only specified 0
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/198
The patch fixes arguably bad style on the part of the 3rd party library
authors, so I do not think there's reason to revert the patch. However, in the
future it would be much easi
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/199
Init release scripts
Includes:
- command to create artifacts
- command to publish release candidates
- command to test a release candidate
All commands are
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/196
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/198
patch to fix gcc compile error gflags
This fix adds a patch to the third party library `gflags` so that
compilation will work with certain versions of GCC which were previously
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/189
@zuyu yes it fixed the multiple queries issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/189
@jianqiao This does not fix the bug with `\analyze`. That appears to be
something with how the analyze command was written.
---
If your project is set up for it, you can reply to this
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/189
patches for missed linenoise changes
This fixes an issue where newlines were not being given to quickstep's
parser. These changes existed previously in quickstep but were not ca
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/188
LGTM, merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/188
Adds marcs ssh key to KEYS
For release. I looked at apache KUDU and IMPALA and they both do not keep
the KEYS file in the root of their git project. I wonder if we only need to
keep
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/184
changed and closed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user cramja closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/184#discussion_r100139845
--- Diff: BUILDING.md ---
@@ -1,60 +1,71 @@
-Quickstep Build Guide
-=
+# Quickstep Build Guide
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/184
> The job exceeded the maximum time limit for jobs, and has been terminated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/184
Refactor building.md
* Added table of content
* updated building instructions
* Removed some redundancy
* Moved bonus sections into the appendix
You can merge this pull
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/183
Merged, closing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user cramja closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/183
What was your solution to tc malloc issue on mac, just ignore it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/183
@jianqiao can I get a +1 when travis comes back?
ps
This doesn't solve the TCMALLOC issue. I tried using dynamic->static libs,
and building perftools standalone. It
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/183
BTW this is so we can build on Mac. @pateljm
I'm still finding that I must specify `cmake -DUSE_TCMALLOC=FALSE ..`. Then
it builds successfully on Mac.
---
If your proje
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/183
Adds regex to specify 16.+ versions of Darwin
Before this change, only one recent version of Darwin was correctly
having the compiler flags modified to allow for deprecated syscalls
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Though, I would say, one enhancement we can do right now, is check that the
user has `curl` and stop the script if they don't.
---
If your project is set up for it, you can rep
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Also, @hbdeshmukh, I ran it on my machine, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
@zuyu I think that's a good idea. Maybe though, that could be a version 2
feature. Seeing as before we had 3 commands with `submodule`, this is an
improvement.
---
If your proje
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
@zuyu are you suggesting that the `cmake` command should automatically run
the download script?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/139
@hbdeshmukh I fixed the problem, hopefully. Waiting for Travis to come
back.
There's several Travis runs which I triggered (`git commit --amend; git
push --force`)
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/139
@hbdeshmukh my new years resolution is to finish this PR. Want to review
this with me?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/153
compiles on my mac, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user cramja closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/129
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
1 - 100 of 153 matches
Mail list logo