[GitHub] incubator-quickstep issue #155: Add min/max statistics and the exactness fla...

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/155 Rebased to squash the two commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-quickstep issue #155: Add min/max statistics and the exactness fla...

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/155 Comments updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-quickstep issue #128: Refine estimates for estimateCardinality for...

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/128 LGTM. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-quickstep issue #122: Add backend support for LIPFilters.

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/122 @zuyu `LIPFilterDeployment` gets serialized into `QueryContext`, and `LIPFilterBuilder` is a helper class that just wraps some contents from `LIPFilterDeployment

[GitHub] incubator-quickstep issue #121: QUICKSTEP-57 Support for performing partitio...

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/121 LGTM! Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-quickstep issue #122: Add backend support for LIPFilters.

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/122 Comments addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-quickstep pull request #120: Store handle count in FastSeparateCha...

Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/120#discussion_r84570072 --- Diff: storage/FastSeparateChainingHashTable.hpp --- @@ -145,10 +145,10 @@ class FastSeparateChainingHashTable header_

[GitHub] incubator-quickstep issue #109: Refactored SplitRowStore bulk insertion

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/109 @pateljm The PR was merged but was not closed automatically, @cramja can manually close it. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-quickstep issue #109: Refactored SplitRowStore bulk insertion

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/109 Merged and closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-quickstep issue #109: Refactored SplitRowStore bulk insertion

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/109 @cramja I'm not sure about the overhead for calling the constructor inside the accessor loop. We can first have this `setMemory()` version merged to have a reference

[GitHub] incubator-quickstep pull request #117: Clean up the old BloomFilter implemen...

GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/117 Clean up the old BloomFilter implementation where BloomFilters are attached to HashTables This PR cleans up the old BloomFilter implementation where BloomFilters are attached

[GitHub] incubator-quickstep issue #115: Update travis to run only single thread whil...

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/115 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-quickstep pull request #113: Optimizer changes for the LIPFilter f...

GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/113 Optimizer changes for the LIPFilter feature. There will be three PRs for adding the _LIPFilter_ feature: optimizer changes / execution generator changes / relational operator changes

[GitHub] incubator-quickstep issue #112: Minor bug fix in AggregationOperationState

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/112 LGTM. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-quickstep pull request #106: Improve StarSchemaSimpleCostModel to ...

GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/106 Improve StarSchemaSimpleCostModel to provide better group cardinality estimation for aggregations. This PR revises `StarSchemaSimpleCostModel` to provide better group cardinality

[GitHub] incubator-quickstep pull request #105: Enable \analyze command to be applied...

GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/105 Enable \analyze command to be applied to specific tables This is a light-weight PR that enables the `\analyze` command to be followed by an arbitrary number of table names

[GitHub] incubator-quickstep issue #81: Refactored QueryProcessor.

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/81 LGTM. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-quickstep issue #79: Constructed Generators once in the optimizer.

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/79 @zuyu The `Generator`'s can be stateless (need some refactoring), but each query should have its own `OptimizerContext`. --- If your project is set up for it, you can reply

[GitHub] incubator-quickstep issue #76: Visualize execution plan DAGs annotated with ...

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/76 Thanks Harshad! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-quickstep issue #74: Removed the redundant query id in the optimiz...

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/74 This change looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/73#discussion_r73290304 --- Diff: query_optimizer/rules/BottomUpRule.hpp --- @@ -80,6 +81,14 @@ class BottomUpRule : public Rule { */ virtual TreeNodePtr

[GitHub] incubator-quickstep issue #73: Move hash join's probe and build node decisio...

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/73 LGTM except for some minor places. Also fix the style check issue then we're good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/73#discussion_r73208331 --- Diff: query_optimizer/rules/SwapProbeBuild.hpp --- @@ -0,0 +1,47 @@ +#ifndef QUICKSTEP_QUERY_OPTIMIZER_RULES_SWAP_PROBE_BUILD_HPP_

[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/73#discussion_r73207435 --- Diff: query_optimizer/rules/SwapProbeBuild.cpp --- @@ -0,0 +1,64 @@ +#include "query_optimizer/rules/SwapProbeBuil

[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/73#discussion_r73204750 --- Diff: query_optimizer/rules/BottomUpRule.hpp --- @@ -80,6 +81,8 @@ class BottomUpRule : public Rule { */ virtual TreeNodePtr

[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/73#discussion_r73079256 --- Diff: query_optimizer/rules/SwapProbeBuild.hpp --- @@ -0,0 +1,46 @@ +#ifndef QUICKSTEP_QUERY_OPTIMIZER_RULES_SWAP_PROBE_BUILD_HPP_

[GitHub] incubator-quickstep issue #51: Minor changes in profiling work order output.

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/51 LGTM except for one minor typo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-quickstep pull request #51: Minor changes in profiling work order ...

Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/51#discussion_r69846306 --- Diff: query_execution/Foreman.cpp --- @@ -238,16 +238,17 @@ void Foreman::printWorkOrderProfilingResults(const std::size_t query_id

[GitHub] incubator-quickstep pull request #40: Minor Change: Added move constructor i...

Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/40#discussion_r68642507 --- Diff: query_optimizer/logical/Sort.hpp --- @@ -137,6 +150,19 @@ class Sort : public Logical { addChild(input_

[GitHub] incubator-quickstep issue #34: Bug fixed in \analyze command and reuse code.

Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/34 LGTM! Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-quickstep pull request #19: Improve text scan operator

Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/19#discussion_r66470811 --- Diff: relational_operators/TextScanOperator.cpp --- @@ -155,116 +63,50 @@ bool TextScanOperator::getAllWorkOrders( InsertDestination

[GitHub] incubator-quickstep pull request #19: Improve text scan operator

GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/19 Improve text scan operator This PR updates the `TextScanOperator` to improve its performance. There are three main changes: (1) Pass `text_offset` and `text_segment_size

[GitHub] incubator-quickstep pull request #18: Fix a potential segfault in Compressed...

GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/18 Fix a potential segfault in CompressedBlockBuilder This PR fixes a potential bug in `CompressedBlockBuilder`. This fix is necessary for a subsequent PR on `TextScanOperator` where each

<    1   2   3