Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112547038
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112417791
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112417078
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112548566
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112414736
--- Diff: cli/CMakeLists.txt ---
@@ -39,18 +38,39 @@ if (ENABLE_GOOGLE_PROFILER)
set(QUICKSTEP_ENABLE_GOOGLE_PROFILER TRUE)
endif
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112417374
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112417941
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112547359
--- Diff: cli/QuickstepCli.cpp ---
@@ -28,26 +28,23 @@
#include
#include
-#include "cli/CliConfig.h&quo
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112417234
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112548112
--- Diff: cli/tests/CMakeLists.txt ---
@@ -90,3 +101,18 @@ if (ENABLE_DISTRIBUTED)
${GFLAGS_LIB_NAME
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112549890
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112404840
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112413621
--- Diff: cli/tests/CMakeLists.txt ---
@@ -32,6 +32,17 @@ if (ENABLE_DISTRIBUTED)
"${PROJECT_SOURCE_DIR}/ut
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112417113
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112416384
--- Diff: cli/LineReaderBuffered.hpp ---
@@ -0,0 +1,73 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112411604
--- Diff: cli/NetworkCliClientMain.cpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112549264
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112550617
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112406197
--- Diff: cli/LineReaderBuffered.cpp ---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112406425
--- Diff: cli/LineReaderBuffered.hpp ---
@@ -0,0 +1,73 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112404491
--- Diff: cli/Flags.cpp ---
@@ -87,4 +87,18 @@ DEFINE_bool(preload_buffer_pool, false,
"accepting queries (should als
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112403533
--- Diff: CMakeLists.txt ---
@@ -145,6 +145,7 @@ if (ENABLE_VECTOR_PREDICATE_SHORT_CIRCUIT)
)
endif()
+option
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112408163
--- Diff: cli/NetworkCliClient.hpp ---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112407440
--- Diff: cli/LocalIO.hpp ---
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112548387
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112405717
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112410750
--- Diff: cli/Flags.hpp ---
@@ -45,6 +45,8 @@ DECLARE_string(storage_path);
DECLARE_bool(preload_buffer_pool);
+DECLARE_int32
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112404137
--- Diff: cli/CMakeLists.txt ---
@@ -150,6 +189,34 @@ if(USE_LINENOISE)
else()
target_link_libraries(quickstep_cli_LineReader
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112405059
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112407163
--- Diff: cli/LineReaderBuffered.hpp ---
@@ -0,0 +1,73 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112406932
--- Diff: cli/LocalIO.hpp ---
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112407922
--- Diff: cli/NetworkCliClient.hpp ---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112407047
--- Diff: cli/LocalIO.hpp ---
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112407627
--- Diff: cli/NetworkCliClient.hpp ---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112406128
--- Diff: cli/LineReaderBuffered.cpp ---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112411238
--- Diff: cli/NetworkCliClientMain.cpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/234#discussion_r112401278
--- Diff: relational_operators/UnionAllOperator.hpp ---
@@ -149,6 +151,11 @@ class UnionAllOperator : public RelationalOperator
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/234#discussion_r112400291
--- Diff: relational_operators/UnionAllOperator.cpp ---
@@ -128,14 +128,56 @@ bool UnionAllOperator::getAllWorkOrders(
}
bool
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110817047
--- Diff: parser/SqlParser.ypp ---
@@ -1198,23 +1211,49 @@ with_list_element:
$$->set_table_reference_signature
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/230
For this PR, we could add two new classes: `client` and `server`, and a
unit test to test the communication path between both. No need changes to any
existing source code files.
---
If
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110560109
--- Diff: cli/SingleNodeServer.proto ---
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110560093
--- Diff: CMakeLists.txt ---
@@ -145,6 +145,7 @@ if (ENABLE_VECTOR_PREDICATE_SHORT_CIRCUIT)
)
endif()
+option
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524074
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524006
--- Diff: cli/CMakeLists.txt ---
@@ -44,6 +44,20 @@ configure_file (
"${CMAKE_CURRENT_BINARY_DIR}/CliConfig.h"
)
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524040
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524344
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524263
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524033
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524355
--- Diff: cli/SingleNodeServer.proto ---
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110523885
--- Diff: CMakeLists.txt ---
@@ -696,7 +697,8 @@ set(ENABLE_ZOOKEEPER OFF CACHE BOOL "Enable Zookeeper
TMB")
add_su
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524089
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524143
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110523774
--- Diff: CMakeLists.txt ---
@@ -145,6 +145,7 @@ if (ENABLE_VECTOR_PREDICATE_SHORT_CIRCUIT)
)
endif()
+option
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524125
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524371
--- Diff: cli/SingleNodeServer.proto ---
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524222
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524205
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110523933
--- Diff: CMakeLists.txt ---
@@ -792,3 +794,13 @@ if (ENABLE_DISTRIBUTED)
${GFLAGS_LIB_NAME
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524066
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524021
--- Diff: cli/CMakeLists.txt ---
@@ -150,7 +170,15 @@ if(USE_LINENOISE)
else()
target_link_libraries(quickstep_cli_LineReader
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/230
Unfortunately, for now no CIs for the distributed version due to both
`Protobuf 3` and `gRPC` dependencies. But we definitely should have!
One thing to add is that ccache could
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/230
There are several ways to get `Protobuf 3` and `gRPC` in Travis, but
unfortunately all may result in time-out.
* PR #223 upgrades git submodule in the third_party.
* PR #220
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/229
@jianqiao We need to wait for squashing commits into one before merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110511246
--- Diff: parser/SqlParser.ypp ---
@@ -676,7 +686,7 @@ sql_statement:
| quit_statement {
$$ = $1
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110300377
--- Diff: parser/tests/SetOperation.test ---
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110304313
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -1350,16 +1351,172 @@ L::LogicalPtr Resolver::resolveSelect(
return logical_plan
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110300978
--- Diff: query_optimizer/logical/SetOperation.hpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110295303
--- Diff: parser/ParseSetOperation.hpp ---
@@ -0,0 +1,136 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110304131
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -1350,16 +1351,172 @@ L::LogicalPtr Resolver::resolveSelect(
return logical_plan
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110294613
--- Diff: parser/ParseSetOperation.hpp ---
@@ -0,0 +1,136 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110294927
--- Diff: parser/ParseSetOperation.hpp ---
@@ -0,0 +1,136 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110303184
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -372,23 +373,23 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
&parse_q
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110304392
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -1350,16 +1351,172 @@ L::LogicalPtr Resolver::resolveSelect(
return logical_plan
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110296317
--- Diff: parser/SqlParser.ypp ---
@@ -604,8 +615,6 @@ void NotSupported(const YYLTYPE *location, yyscan_t
yyscanner, const std::string
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110305172
--- Diff: query_optimizer/resolver/Resolver.hpp ---
@@ -183,6 +184,24 @@ class Resolver {
const NameResolver *parent_resolver
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110303831
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -1350,16 +1351,172 @@ L::LogicalPtr Resolver::resolveSelect(
return logical_plan
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110295083
--- Diff: parser/ParseSetOperation.hpp ---
@@ -0,0 +1,136 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110304705
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -1350,16 +1351,172 @@ L::LogicalPtr Resolver::resolveSelect(
return logical_plan
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110305426
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -1350,16 +1351,172 @@ L::LogicalPtr Resolver::resolveSelect(
return logical_plan
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110295617
--- Diff: parser/ParseStatement.hpp ---
@@ -479,49 +480,49 @@ class ParseStatementDropTable : public ParseStatement
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110300461
--- Diff: query_optimizer/LogicalGenerator.cpp ---
@@ -51,12 +51,12 @@ L::LogicalPtr LogicalGenerator::generatePlan(
const CatalogDatabase
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110302971
--- Diff: query_optimizer/logical/SetOperation.hpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110303143
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -372,23 +373,23 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
&parse_q
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/228
Pressing `` adds `\n`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/228
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/228
You've already added the `EOL`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/228#discussion_r110269621
--- Diff: cmake/QsProtobufGenerateCpp.cmake ---
@@ -0,0 +1,80 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/228#discussion_r110269580
--- Diff: cmake/QsProtobufGenerateCpp.cmake ---
@@ -0,0 +1,80 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user zuyu closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/220
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zuyu closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/225
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zuyu closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/225
DO NOT MERGE: Travis ccache
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zuyu/incubator-quickstep travis-ccache
Alternatively you
Hi Marc,
With the NetworkWrapper, does the QuickstepServer could serve queries from
multiple clients?
Cheers,
Zuyu
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/219#discussion_r109276326
--- Diff: storage/PartitionedHashTablePool.hpp ---
@@ -113,6 +113,19 @@ class PartitionedHashTablePool {
return num_partitions_
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/219
Hi @hbdeshmukh,
Most of the newly added methods could be marked as `const`, and I'll merge
this PR after you make the following suggested changes.
Btw, this could
.
For your purpose, you might want to split QuickstepCli.cpp into two new
executables, one for the cli, and one the database core. Both need to link
the Protobuf 3 and gRPC. And then, the python program could talk to the cli
executable to send a query or a command.
Hope it helps.
Cheers,
Zuyu
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/219
Hi @hbdeshmukh,
In the debug build, it seems we have deadlocks in
`quickstep_queryoptimizer_tests_executiongenerator_join`.
---
If your project is set up for it, you can reply to
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/224
Hi @hbdeshmukh, any intuition of what causes this huge performance boost?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
pre-built binary package. Again, downloading in Travis script gets
stuck due to the timeout.
Cheers,
Zuyu
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/224#discussion_r108283664
--- Diff: storage/PackedPayloadHashTable.cpp ---
@@ -239,26 +239,47 @@ bool
PackedPayloadHashTable::upsertValueAccessorCompositeKey
301 - 400 of 1108 matches
Mail list logo
