Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/224#discussion_r108285120
--- Diff: storage/PackedPayloadHashTable.cpp ---
@@ -239,26 +239,47 @@ bool
PackedPayloadHashTable::upsertValueAccessorCompositeKey
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/224#discussion_r108283380
--- Diff: storage/PackedPayloadHashTable.cpp ---
@@ -239,26 +239,47 @@ bool
PackedPayloadHashTable::upsertValueAccessorCompositeKey
Hi Harshad,
A quick question: any reason why we still keep protobuf as a git submodule?
To test the distributed version in the Travis CI, we need at least protobuf
3.0 and grpc.
Cheers,
Zuyu
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/217
Hi @hbdeshmukh,
I have reported QUICKSTEP-86 for the test failure, and squashed all the
commits. Please merge it. Thanks!
---
If your project is set up for it, you can reply to
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/217
Hi @hbdeshmukh,
Thank you for the review. I have addressed most of issues, and please take
another look.
And I also would like to propose to remove the debug builds in
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/217#discussion_r108021509
--- Diff: catalog/PartitionSchemeHeader.cpp ---
@@ -32,16 +34,29 @@
#include "glog/logging.h"
+using std::move;
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/217#discussion_r108021399
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -724,6 +708,25 @@ const S::PartitionSchemeHeader*
Resolver::resolvePartitionClause
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/217#discussion_r107982736
--- Diff: storage/InsertDestination.cpp ---
@@ -682,8 +685,11 @@ void
PartitionAwareInsertDestination::bulkInsertTuplesWithRemappedAttributes
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/217#discussion_r107981928
--- Diff: catalog/tests/PartitionScheme_unittest.cpp ---
@@ -611,6 +665,7 @@ TEST(PartitionSchemeTest,
CheckRangePartitionSchemeSerialization
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/217#discussion_r107981179
--- Diff: catalog/tests/PartitionScheme_unittest.cpp ---
@@ -343,15 +363,43 @@ TEST(PartitionSchemeHeaderTest
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/217#discussion_r107980470
--- Diff: catalog/PartitionSchemeHeader.hpp ---
@@ -288,22 +310,46 @@ class RangePartitionSchemeHeader : public
PartitionSchemeHeader
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/217#discussion_r107969229
--- Diff: catalog/PartitionSchemeHeader.hpp ---
@@ -48,6 +50,13 @@ class Type;
**/
class PartitionSchemeHeader {
public
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/217#discussion_r107966844
--- Diff: catalog/PartitionSchemeHeader.cpp ---
@@ -77,32 +95,44 @@ PartitionSchemeHeader*
PartitionSchemeHeader::ReconstructFromProto
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/223
DO NOT MERGE: Use Protobuf 3
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zuyu/incubator-quickstep protobuf-3
Alternatively you
Github user zuyu commented on the pull request:
https://github.com/apache/incubator-quickstep/commit/42bf626d6ee922e30334b835c793ff6607a89051#commitcomment-21440716
In README.md:
In README.md on line 81:
Hi @pateljm, we have a duplicated word `can` here.
---
If your project
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/222
Fixed a sign compare warning.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep
fix-sign-cmp-warning
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/219#discussion_r107301913
--- Diff: query_execution/QueryContext.cpp ---
@@ -58,7 +59,8 @@ QueryContext::QueryContext(const
serialization::QueryContext &p
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/221
Fixed a pedantic warning.
This small PR removes `;` after the namespace scope.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/219#discussion_r107298842
--- Diff: query_execution/QueryContext.cpp ---
@@ -58,7 +59,8 @@ QueryContext::QueryContext(const
serialization::QueryContext &p
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/220
DO NOT MERGE: Built the distributed version in Travis.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zuyu/incubator-quickstep
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/219#discussion_r107286932
--- Diff: query_execution/QueryContext.cpp ---
@@ -58,7 +59,8 @@ QueryContext::QueryContext(const
serialization::QueryContext &p
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/217
QUICKSTEP-73: Multi-attribute PartitionSchemeHeader.
This PR added multi-attribute partitions support.
```
CREATE TABLE foo5 (attr1 INT, attr2 LONG, attr3 FLOAT, attr4 DOUBLE
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/212#discussion_r106759138
--- Diff: NOTICE ---
@@ -5,33 +5,4 @@ This product includes software developed at
The Apache Software Foundation (http://www.apache.org
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/216
Hi @hbdeshmukh,
Thank you for the review. Done the rebase. Cheers!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/216
Minor refactored RangePartitionSchemeHeader::getProto.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/215
Used an alternative implementation for the proto map.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep fix
Github user zuyu closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/214
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/214
DO NOT MERGE: Built the protobuf from the source for the map support.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache
Github user zuyu closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/211
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/211
Retry pulling if RPC fails in the distributed version.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep
Github user zuyu closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/181
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/181
Close it temporally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/210
Fixed the bug in admitQueries.
Assigned to @hbdeshmukh.
This PR fixed the bug in `admitQueries` that if an `AdmitRequestMessage`
contains a number of queries that excesses that
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/208
Just wait for the GitHub to sync with the ASF repo, and it will
automatically close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/181#discussion_r104878308
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -740,6 +805,202 @@ void ExecutionGenerator::convertHashJoin(const
P::HashJoinPtr
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/208
@cramja The [initial CI
tests](https://travis-ci.org/apache/incubator-quickstep/builds/208755951)
passed. If we are blocked by this PR for the release, I think we could merge
now
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/209
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/208
Assigned to @cramja.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/208
Removed redundant third party libraries.
shared by both Quickstep and TMB.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache
Btw, it seems that the compiler does not support or honor the flag
'-Wno-unused-variable' set by the TMB.
https://github.com/apache/incubator-quickstep/blob/master/third_party/src/tmb/CMakeLists.txt#L57
Hi Marc,
Yes, I am looking at this issue.
How to produce this issue? It seems that the error was generated by gcc?
Cheers,
Zuyu
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/181#discussion_r104763709
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -740,6 +805,202 @@ void ExecutionGenerator::convertHashJoin(const
P::HashJoinPtr
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/181#discussion_r104759237
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -740,6 +805,202 @@ void ExecutionGenerator::convertHashJoin(const
P::HashJoinPtr
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/181#discussion_r104758847
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -740,6 +805,202 @@ void ExecutionGenerator::convertHashJoin(const
P::HashJoinPtr
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/181#discussion_r104604523
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -679,13 +688,72 @@ void ExecutionGenerator::convertFilterJoin(const
P::FilterJoinPtr
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/181#discussion_r104604315
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -679,13 +688,72 @@ void ExecutionGenerator::convertFilterJoin(const
P::FilterJoinPtr
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/181#discussion_r104604399
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -679,13 +688,72 @@ void ExecutionGenerator::convertFilterJoin(const
P::FilterJoinPtr
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/181#discussion_r104603519
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -740,6 +805,202 @@ void ExecutionGenerator::convertHashJoin(const
P::HashJoinPtr
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/181#discussion_r104603305
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -740,6 +805,202 @@ void ExecutionGenerator::convertHashJoin(const
P::HashJoinPtr
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/181#discussion_r104577292
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -679,13 +688,72 @@ void ExecutionGenerator::convertFilterJoin(const
P::FilterJoinPtr
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/181#discussion_r104576949
--- Diff: query_optimizer/ExecutionGenerator.hpp ---
@@ -135,9 +135,11 @@ class ExecutionGenerator {
*/
struct CatalogRelationInfo
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/203#discussion_r104258044
--- Diff: release/release_cmds.sh ---
@@ -25,6 +25,7 @@ create_artifacts() {
export RELEASE_DIR=`pwd`
cd ..
+ export
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/205
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/202
Added \analyze support in the distributed version.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep dist
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/189
Never mind. It works after resetting the third party and recompiling.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/198
It is more about maintainability when we try to upgrade the third party
while our patch may not work in a new release.
---
If your project is set up for it, you can reply to this email
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/189
@cramja In addition to `\analyze`, it seems that other commands like `\d`
and `\dt` also do not work.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/199#discussion_r103599402
--- Diff: release/release_cmds.sh ---
@@ -0,0 +1,135 @@
+#!/usr/bin/bash
+
+# Functions for Releasing Quickstep
+# Usage: Fill out
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/199#discussion_r103599270
--- Diff: release/release_manager.profile ---
@@ -0,0 +1,28 @@
+# Profile for Releasing Quickstep
+#
+# This script is for release
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/200
Style fixes in the distributed version.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep dist-fix
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/198
@cramja If I remembered correctly, we disable some waring->error flags for
building third party libraries. So for this issue, I suggest to disable certain
cxx flags, instead of addin
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/197
Moved Describe command to an util file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep refactor-cmd
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/195
Minor refactored CommandExecutor.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep refactor-cmd
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/193
@jianqiao Please fix the build failures using gcc. See
[here](https://travis-ci.org/apache/incubator-quickstep/builds/205062637) for
more info.
---
If your project is set up for it, you
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/191
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/194
Used two TMB implementations in Shiftboss.
- Global TMB between Foreman and Shiftboss.
- Local TMB between Workers and Shiftboss.
You can merge this pull request into a Git
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/189
@cramja Did this PR fix the issue that the cli shell does not work with a
input file with multiple queries?
---
If your project is set up for it, you can reply to this email and have your
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/189
@cramja The patch has trailing whitespaces.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/187
Visualized Execution DAG in the distributed version.
Assigned to @jianqiao.
In the future, we may merge this PR and the similar code in
`cli/QuickstepCli.cpp` into
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/186
Added HDFS Support For TextScanWorkOrder.
Assigned to @jianqiao.
This PR allows to bulk load files to HDFS used in the distributed version.
It also fixed the file pointer leak
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/185#discussion_r100365695
--- Diff: query_optimizer/physical/CrossReferenceCoalesceAggregate.hpp ---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Software
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/185#discussion_r100368014
--- Diff: relational_operators/BuildAggregationExistenceMapOperator.hpp ---
@@ -0,0 +1,177 @@
+/**
+ * Licensed to the Apache Software
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/185#discussion_r100365438
--- Diff: query_optimizer/physical/CrossReferenceCoalesceAggregate.hpp ---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Software
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/185#discussion_r100244520
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -1730,6 +1631,148 @@ void ExecutionGenerator::convertAggregate
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/185#discussion_r100369933
--- Diff: relational_operators/WorkOrderFactory.cpp ---
@@ -91,6 +92,19 @@ WorkOrder* WorkOrderFactory::ReconstructFromProto(const
serialization
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/185#discussion_r100251764
--- Diff: query_optimizer/cost_model/StarSchemaSimpleCostModel.cpp ---
@@ -49,15 +55,24 @@
#include "query_optimizer/phy
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/185#discussion_r100368210
--- Diff: relational_operators/BuildAggregationExistenceMapOperator.hpp ---
@@ -0,0 +1,177 @@
+/**
+ * Licensed to the Apache Software
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/185#discussion_r100369492
--- Diff: relational_operators/WorkOrder.proto ---
@@ -44,6 +44,7 @@ enum WorkOrderType {
UPDATE = 20;
WINDOW_AGGREGATION = 21
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/185#discussion_r100367721
--- Diff: relational_operators/BuildAggregationExistenceMapOperator.cpp ---
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the Apache Software
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/184#discussion_r100128102
--- Diff: BUILDING.md ---
@@ -1,60 +1,71 @@
-Quickstep Build Guide
-=
+# Quickstep Build Guide
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/177#discussion_r99964669
--- Diff: query_optimizer/rules/ReduceGroupByAttributes.hpp ---
@@ -0,0 +1,143 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/179
Please resync with the master branch, and I will merge it. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99925160
--- Diff: storage/AggregationOperationState.cpp ---
@@ -353,187 +353,286 @@ bool AggregationOperationState::ProtoIsValid(
return true
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99924782
--- Diff: relational_operators/InitializeAggregationOperator.cpp ---
@@ -0,0 +1,72 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/183
Next time, before merging, sync again your local branch with the master,
and this PR will automatically merged, instead of manually closed.
---
If your project is set up for it, you can
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/183
So far it is only the problem for Mac, so I disabled `tcmalloc` by
`-DUSE_TCMALLOC=0` in `cmake` configuration.
---
If your project is set up for it, you can reply to this email and have
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99908259
--- Diff: storage/AggregationOperationState.hpp ---
@@ -156,6 +152,29 @@ class AggregationOperationState {
const CatalogDatabaseLite
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/183
I sometimes encountered `tcmalloc` build issues on Mac, but it worked for a
while before the third party changes.
---
If your project is set up for it, you can reply to this email and
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/177#discussion_r99887277
--- Diff: query_optimizer/rules/ReduceGroupByAttributes.hpp ---
@@ -0,0 +1,143 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/177#discussion_r99886212
--- Diff: query_optimizer/rules/ReduceGroupByAttributes.hpp ---
@@ -0,0 +1,143 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/182
Defined TMB Message Poll Interval as a gflag.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99505477
--- Diff: storage/AggregationOperationState.cpp ---
@@ -269,7 +269,7 @@ AggregationOperationState*
AggregationOperationState::ReconstructFromProto
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99510443
--- Diff: storage/AggregationOperationState.cpp ---
@@ -556,80 +655,83 @@ void AggregationOperationState::finalizeSingleState
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99511761
--- Diff: storage/AggregationOperationState.hpp ---
@@ -156,6 +152,29 @@ class AggregationOperationState {
const CatalogDatabaseLite
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99510612
--- Diff: storage/AggregationOperationState.cpp ---
@@ -80,148 +83,145 @@ AggregationOperationState::AggregationOperationState(
const std
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99500588
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -1495,9 +1607,28 @@ void ExecutionGenerator::convertAggregate(
}
if
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99504991
--- Diff: relational_operators/InitializeAggregationOperator.cpp ---
@@ -0,0 +1,72 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99499809
--- Diff: expressions/aggregation/AggregationConcreteHandle.hpp ---
@@ -61,7 +61,7 @@ class HashTableStateUpserterFast {
*table. The
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99517170
--- Diff: storage/PackedPayloadHashTable.cpp ---
@@ -0,0 +1,463 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/179#discussion_r99517316
--- Diff: storage/PackedPayloadHashTable.cpp ---
@@ -0,0 +1,463 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
401 - 500 of 1108 matches
Mail list logo
