[GitHub] incubator-quickstep issue #183: Adds regex to specify 16.+ versions of Darwi...

2017-02-07 Thread pateljm
Github user pateljm commented on the issue: https://github.com/apache/incubator-quickstep/pull/183 Thanks @cramja !! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] incubator-quickstep issue #183: Adds regex to specify 16.+ versions of Darwi...

2017-02-07 Thread zuyu
Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/183 Next time, before merging, sync again your local branch with the master, and this PR will automatically merged, instead of manually closed. --- If your project is set up for it, you can re

[GitHub] incubator-quickstep issue #183: Adds regex to specify 16.+ versions of Darwi...

2017-02-07 Thread cramja
Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/183 Merged, closing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] incubator-quickstep issue #183: Adds regex to specify 16.+ versions of Darwi...

2017-02-07 Thread zuyu
Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/183 So far it is only the problem for Mac, so I disabled `tcmalloc` by `-DUSE_TCMALLOC=0` in `cmake` configuration. --- If your project is set up for it, you can reply to this email and have y

[GitHub] incubator-quickstep issue #183: Adds regex to specify 16.+ versions of Darwi...

2017-02-07 Thread cramja
Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/183 What was your solution to tc malloc issue on mac, just ignore it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] incubator-quickstep issue #183: Adds regex to specify 16.+ versions of Darwi...

2017-02-07 Thread zuyu
Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/183 I sometimes encountered `tcmalloc` build issues on Mac, but it worked for a while before the third party changes. --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-quickstep issue #183: Adds regex to specify 16.+ versions of Darwi...

2017-02-07 Thread cramja
Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/183 @jianqiao can I get a +1 when travis comes back? ps This doesn't solve the TCMALLOC issue. I tried using dynamic->static libs, and building perftools standalone. It compiles f

[GitHub] incubator-quickstep issue #183: Adds regex to specify 16.+ versions of Darwi...

2017-02-07 Thread cramja
Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/183 BTW this is so we can build on Mac. @pateljm I'm still finding that I must specify `cmake -DUSE_TCMALLOC=FALSE ..`. Then it builds successfully on Mac. --- If your project is s