Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/198
It is more about maintainability when we try to upgrade the third party
while our patch may not work in a new release.
---
If your project is set up for it, you can reply to this email and
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/198
The patch fixes arguably bad style on the part of the 3rd party library
authors, so I do not think there's reason to revert the patch. However, in the
future it would be much easier to ju
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/198
@cramja If I remembered correctly, we disable some waring->error flags for
building third party libraries. So for this issue, I suggest to disable certain
cxx flags, instead of adding a pat
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/198
Great! Thanks Marc @cramja.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
