[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-11 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66716091 --- Diff: query_execution/Foreman.hpp --- @@ -22,46 +22,40 @@ #include #include -#include "catalog/CatalogTypedefs.hpp"

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-11 Thread hbdeshmukh
Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66713602 --- Diff: query_execution/QueryContext.proto --- @@ -54,4 +54,6 @@ message QueryContext { // NOTE(zuyu): For UpdateWorkOrder only.

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-11 Thread hbdeshmukh
Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66713594 --- Diff: query_execution/PolicyEnforcer.hpp --- @@ -0,0 +1,168 @@ +/** + * Copyright 2016, Quickstep Research Group, Computer

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-11 Thread hbdeshmukh
Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66713568 --- Diff: query_execution/Foreman.hpp --- @@ -22,46 +22,40 @@ #include #include -#include "catalog/CatalogTypedefs.hpp"

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-11 Thread hbdeshmukh
Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66713553 --- Diff: query_execution/Foreman.cpp --- @@ -22,355 +22,189 @@ #include #include -#include "catalog/CatalogDatabase.hpp"

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-11 Thread hbdeshmukh
Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66713074 --- Diff: query_execution/PolicyEnforcer.hpp --- @@ -0,0 +1,168 @@ +/** + * Copyright 2016, Quickstep Research Group, Computer

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-11 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66709222 --- Diff: query_execution/Foreman.cpp --- @@ -22,355 +22,189 @@ #include #include -#include "catalog/CatalogDatabase.hpp"

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-11 Thread hbdeshmukh
Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66706036 --- Diff: query_execution/Foreman.cpp --- @@ -22,355 +22,189 @@ #include #include -#include "catalog/CatalogDatabase.hpp"

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-10 Thread pateljm
Github user pateljm commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66692255 --- Diff: cli/QuickstepCli.cpp --- @@ -323,13 +326,20 @@ int main(int argc, char* argv[]) {

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-10 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66691464 --- Diff: query_optimizer/ExecutionGenerator.hpp --- @@ -374,6 +375,14 @@ class ExecutionGenerator { */ void

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-10 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66691741 --- Diff: relational_operators/DestroyHashOperator.hpp --- @@ -83,6 +85,8 @@ class DestroyHashWorkOrder : public WorkOrder { * *

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-10 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66691680 --- Diff: relational_operators/AggregationOperator.hpp --- @@ -123,6 +123,8 @@ class AggregationWorkOrder : public WorkOrder { * *

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-10 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66691003 --- Diff: query_execution/QueryExecutionTypedefs.hpp --- @@ -67,7 +68,8 @@ enum QueryExecutionMessageType : message_type_id {

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-10 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66690499 --- Diff: query_execution/QueryContext.proto --- @@ -54,4 +54,6 @@ message QueryContext { // NOTE(zuyu): For UpdateWorkOrder only.

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-10 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66690232 --- Diff: query_execution/PolicyEnforcer.hpp --- @@ -0,0 +1,168 @@ +/** + * Copyright 2016, Quickstep Research Group, Computer Sciences

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-10 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66688816 --- Diff: query_execution/Foreman.hpp --- @@ -71,233 +65,31 @@ class Foreman final : public ForemanLite { * @note If cpu_id is not specified,

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-10 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66687418 --- Diff: query_execution/AdmitRequestMessage.hpp --- @@ -0,0 +1,73 @@ +/** + * Copyright 2016, Quickstep Research Group, Computer Sciences

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-10 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66686943 --- Diff: query_execution/CMakeLists.txt --- @@ -235,36 +241,6 @@ if (ENABLE_DISTRIBUTED) add_test(BlockLocator_unittest

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-10 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66686682 --- Diff: query_execution/AdmitRequestMessage.hpp --- @@ -0,0 +1,73 @@ +/** + * Copyright 2016, Quickstep Research Group, Computer Sciences

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-10 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r0503 --- Diff: query_optimizer/ExecutionGenerator.cpp --- @@ -1635,5 +1635,11 @@ void ExecutionGenerator::convertTableGenerator(

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-10 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66646566 --- Diff: storage/InsertDestination.cpp --- @@ -60,25 +60,28 @@ InsertDestination::InsertDestination(const CatalogRelationSchema ,

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-10 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66646360 --- Diff: cli/QuickstepCli.cpp --- @@ -323,13 +326,20 @@ int main(int argc, char* argv[]) {

[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

2016-06-09 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/14#discussion_r66543912 --- Diff: storage/InsertDestination.cpp --- @@ -60,25 +60,28 @@ InsertDestination::InsertDestination(const CatalogRelationSchema ,