Re: [racket-dev] Fix to module reader?

2013-04-03 Thread Robby Findler
Your fix looks good to me. Robby On Wed, Apr 3, 2013 at 3:32 PM, Danny Yoo wrote: > > In general, if you want to add a "test" to DrDr, all you do is commit > > the file somewhere. I'd put that file in something like > > collects/tests/syntax/module-reader-bad-pos.rkt > > Ok, I've put it into >

Re: [racket-dev] Fix to module reader?

2013-04-03 Thread Danny Yoo
> In general, if you want to add a "test" to DrDr, all you do is commit > the file somewhere. I'd put that file in something like > collects/tests/syntax/module-reader-bad-pos.rkt Ok, I've put it into collects/tests/syntax/module-reader-synthetic-pos.rkt. I don't think it's technically "bad". I

Re: [racket-dev] [plt] Push #26528: master branch updated

2013-04-03 Thread Ryan Culpepper
On 04/02/2013 11:48 PM, Asumu Takikawa wrote: On 2013-03-30 10:10:20 -0400, ry...@racket-lang.org wrote: 293b208 Ryan Culpepper 2013-03-20 10:52 : | added optional #:grammar clause to defform, etc : M collects/scribble/private/manual-form.rkt | 68 - M collects/scribblings/sc

[racket-dev] IRC compliment for Eli, after a fashion...

2013-04-03 Thread John Clements
>From IRC, hope the copy&paste is okay: GoNZooo:I installed 5.3.3 now [11:01am]GoNZooo:From the site instead [11:01am]jbclements:good choice! [11:01am]GoNZooo:With the extremely well-behaved .sh file [11:01am]GoNZooo:God damn, that is user friendly [11:01am] _ Racket D

Re: [racket-dev] Fix to module reader?

2013-04-03 Thread Jay McCarthy
The patch looks obviously correct to me, in that it doesn't do anything bad. I don't know enough about the code to know if the bad pos should be dealt with some other way, though. In general, if you want to add a "test" to DrDr, all you do is commit the file somewhere. I'd put that file in somethi

Re: [racket-dev] Right-paren behavior on Definitions window still looks funky

2013-04-03 Thread Robby Findler
Oh no problem. Sorry i didnt fix it sooner. Thanks for the report! Robby On Wednesday, April 3, 2013, Danny Yoo wrote: > > > On Tuesday, April 2, 2013, Robby Findler wrote: > >> I've just pushed a fix for this, but when you say "still", do you mean >> that you've reported this before? >> >> > I'