Re: [racket-dev] seeing compile-time error for Whalesong on HEAD

2013-04-29 Thread Danny Yoo
Ah, ok, I've reduced the test case to something more managable: two files, promise.rkt and test-promise.rkt, with the following content: ;; promise.rkt #lang typed/racket/base (require (for-syntax racket/base)) (provide MyPromise) (define-struct: (a) MyPromise ([thunk : (-> a)]) #:mutable) ;;

Re: [racket-dev] seeing compile-time error for Whalesong on HEAD

2013-04-29 Thread Eric Dobson
I submitted a commit on Thursday which changed the contract generation code, to introduce the buggy behavior. So thats why there wasn't an error until now. It should be during module compilation where the error is raised, so that should narrow it down. I'll try to take a look tonight if you cannot

Re: [racket-dev] seeing compile-time error for Whalesong on HEAD

2013-04-29 Thread Danny Yoo
Yeah, I want to reduce this to a test case, but I haven't been able to figure out yet what part of Whalesong is tickling this one. I'm also a bit confused, as this part of the code hasn't been touched in months, and so I would have expected the error to show up much sooner. Unfortunately, I don't

Re: [racket-dev] seeing compile-time error for Whalesong on HEAD

2013-04-29 Thread Eric Dobson
LGTM, can you submit a testcase or at least a bug so that we can add a test case for this code path? On Mon, Apr 29, 2013 at 4:42 PM, Danny Yoo wrote: > I believe the right fix for this is: > > > https://github.com/dyoo/racket/commit/24d03f2bf308854deb365fe8bcf6599e8d84fab9 > > but I do not

Re: [racket-dev] seeing compile-time error for Whalesong on HEAD

2013-04-29 Thread Danny Yoo
I believe the right fix for this is: https://github.com/dyoo/racket/commit/24d03f2bf308854deb365fe8bcf6599e8d84fab9 but I do not have enough comfort with TR to know if this will break anything. Can someone review this? Thanks! _ Racket Developers list: http://li

Re: [racket-dev] seeing compile-time error for Whalesong on HEAD

2013-04-29 Thread Danny Yoo
There's something funky in typed-racket/private/type-contract.rkt, with some non-uniformity in the following lines: https://github.com/plt/racket/blob/master/collects/typed-racket/private/type-contract.rkt#L143-L149 where the keywords are being called #:kind, but the variable binding is called "f

[racket-dev] seeing compile-time error for Whalesong on HEAD

2013-04-29 Thread Danny Yoo
I'm seeing the following error message on HEAD (08dc0e10d934cb29b9830a94945c2e38c275a9d8): application: procedure does not expect an argument with given keyword procedure: t->c/both given keyword: #:kind given arguments: Boolean #:kind 'impersonator #:seen (list (cons #(struct:# (B