Re: Review Request 58034: 'Ranger KMS' repo is not getting created in manual installation

2017-03-31 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58034/ --- (Updated March 31, 2017, 7:31 p.m.) Review request for ranger and Madhan Neethi

[jira] [Comment Edited] (RANGER-1489) Solr plugin fails to get client address

2017-03-31 Thread Yan (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951440#comment-15951440 ] Yan edited comment on RANGER-1489 at 3/31/17 6:23 PM: -- A review requ

[jira] [Commented] (RANGER-1489) Solr plugin fails to get client address

2017-03-31 Thread Yan (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951440#comment-15951440 ] Yan commented on RANGER-1489: - A review request is created at https://reviews.apache.org/r/58

Review Request 58115: Ranger-1489: Solr plugin fails to get client address

2017-03-31 Thread Yan Zhou via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58115/ --- Review request for ranger. Repository: ranger Description --- An immedia

[jira] [Created] (RANGER-1489) Solr plugin fails to get client address

2017-03-31 Thread Yan (JIRA)
Yan created RANGER-1489: --- Summary: Solr plugin fails to get client address Key: RANGER-1489 URL: https://issues.apache.org/jira/browse/RANGER-1489 Project: Ranger Issue Type: Bug Components:

Re: Question about group policies

2017-03-31 Thread Alexander Denissov
Thank you all, I get it now. We will include using Hadoop APIs to obtain user group membership before calling Ranger Plugin API isAccessAllowed(). Our current code is here: https://github.com/apache/incubator-hawq/blob/master/ranger-plugin/service/src/main/java/org/apache/hawq/ranger/authorizatio

[jira] [Commented] (RANGER-1483) Ranger hive service definition to use hive metastore directly

2017-03-31 Thread Ankita Sinha (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951334#comment-15951334 ] Ankita Sinha commented on RANGER-1483: -- Committed to Master branch : https://github

Re: Review Request 58067: Ranger hive service definition to use hive metastore directly

2017-03-31 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58067/#review170742 --- Ship it! Ship It! - Ramesh Mani On March 31, 2017, 9:15 a.m.

Re: Review Request 58067: Ranger hive service definition to use hive metastore directly

2017-03-31 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58067/#review170741 --- Ship it! Ship It! - Velmurugan Periasamy On March 31, 2017,

Re: Review Request 57988: RANGER-1479 : Fix bug in ranger-*-(security/audit).xml loading, which prevented loading from JAR's

2017-03-31 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57988/#review170739 --- Ship it! Ship It! - Ramesh Mani On March 31, 2017, 12:32 p.m

Re: Review Request 58067: Ranger hive service definition to use hive metastore directly

2017-03-31 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58067/#review170738 --- Ship it! Ship It! - Ramesh Mani On March 31, 2017, 9:15 a.m.

Re: Review Request 57987: RANGER-1478 : Small refactor in RangerPolicyEngineCache and RangerPolicyEngineOptions, to avoid looking up RangerConfiguration everytime, and try to write the RPEO fields onl

2017-03-31 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57987/#review170728 --- I'm wondering if it makes sense to make the default getPolicyEngin

Re: Review Request 57988: RANGER-1479 : Fix bug in ranger-*-(security/audit).xml loading, which prevented loading from JAR's

2017-03-31 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57988/#review170719 --- Ship it! Ship It! - Colm O hEigeartaigh On March 31, 2017, 1

[jira] [Updated] (RANGER-1478) Refactor RangerPolicyEngineOptions, RangerConfiguration is looked up too many times

2017-03-31 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1478: --- Attachment: (was: 0001-RANGER-1478-Small-refactor-in-RangerPolicyEngineCach.patch) > Ref

[jira] [Updated] (RANGER-1478) Refactor RangerPolicyEngineOptions, RangerConfiguration is looked up too many times

2017-03-31 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1478: --- Attachment: 0001-RANGER-1478-Small-refactor-in-RangerPolicyEngineCach.patch > Refactor Ranger

Re: Review Request 57987: RANGER-1478 : Small refactor in RangerPolicyEngineCache and RangerPolicyEngineOptions, to avoid looking up RangerConfiguration everytime, and try to write the RPEO fields onl

2017-03-31 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57987/ --- (Updated March 31, 2017, 12:50 p.m.) Review request for ranger. Changes -

Re: Review Request 57987: RANGER-1478 : Small refactor in RangerPolicyEngineCache and RangerPolicyEngineOptions, to avoid looking up RangerConfiguration everytime, and try to write the RPEO fields onl

2017-03-31 Thread Zsombor Gegesy
> On March 29, 2017, 3:53 p.m., Colm O hEigeartaigh wrote: > > Looks good, again submit patch using git. I guess, this is made by rbt, which I've tried to use to help with reviewboard. - Zsombor --- This is an automatically generated e-

Re: Review Request 57988: RANGER-1479 : Fix bug in ranger-*-(security/audit).xml loading, which prevented loading from JAR's

2017-03-31 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57988/ --- (Updated March 31, 2017, 12:32 p.m.) Review request for ranger. Changes -

[jira] [Updated] (RANGER-1479) Plugins couldnt load settings xml files from the classpath, if they are inside a jar

2017-03-31 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1479: --- Attachment: (was: 0001-RANGER-1479-Fix-bug-in-ranger-security-audit-.xml-lo.patch) > Plu

[jira] [Updated] (RANGER-1479) Plugins couldnt load settings xml files from the classpath, if they are inside a jar

2017-03-31 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1479: --- Attachment: 0001-RANGER-1479-Fix-bug-in-ranger-security-audit-.xml-lo.patch > Plugins couldnt

Re: Review Request 57988: RANGER-1479 : Fix bug in ranger-*-(security/audit).xml loading, which prevented loading from JAR's

2017-03-31 Thread Colm O hEigeartaigh
The current patch is fine. The original patch did not have author information at the top and looked like it was created with "git diff". Colm. On Fri, Mar 31, 2017 at 12:24 PM, Zsombor wrote: > On Fri, Mar 31, 2017 at 1:16 PM, Colm O hEigeartaigh > wrote: > > > This is an automatically generat

Re: Review Request 57988: RANGER-1479 : Fix bug in ranger-*-(security/audit).xml loading, which prevented loading from JAR's

2017-03-31 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57988/#review170704 --- I think the error message should be changed. "Unable to find URL f

Re: Review Request 57988: RANGER-1479 : Fix bug in ranger-*-(security/audit).xml loading, which prevented loading from JAR's

2017-03-31 Thread Zsombor
On Fri, Mar 31, 2017 at 1:16 PM, Colm O hEigeartaigh wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57988/ > > On March 29th, 2017, 4 p.m. UTC, *Colm O hEigeartaigh* wrote: > > Still the same problemplease see > https://cwiki.apache.org/co

Re: Review Request 57988: RANGER-1479 : Fix bug in ranger-*-(security/audit).xml loading, which prevented loading from JAR's

2017-03-31 Thread Colm O hEigeartaigh
> On March 29, 2017, 4 p.m., Colm O hEigeartaigh wrote: > > Still the same problemplease see > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=55151244 > > Zsombor Gegesy wrote: > Strange, I could run git apply on the downloaded patch file on the latest > apache/mast

Review Request 58104: RangerUI: Escape of policy condition text entered in the policy form.

2017-03-31 Thread Nitin Galave
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58104/ --- Review request for ranger, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep

[jira] [Updated] (RANGER-1479) Plugins couldnt load settings xml files from the classpath, if they are inside a jar

2017-03-31 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1479: --- Attachment: 0001-RANGER-1479-Fix-bug-in-ranger-security-audit-.xml-lo.patch > Plugins couldnt

[jira] [Updated] (RANGER-1479) Plugins couldnt load settings xml files from the classpath, if they are inside a jar

2017-03-31 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1479: --- Attachment: (was: 0001-RANGER-1479-Fix-bug-in-ranger-security-audit-.xml-lo.patch) > Plu

Re: Review Request 57372: Remove a lot of not used code in XResourceService

2017-03-31 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57372/ --- (Updated March 31, 2017, 10:58 a.m.) Review request for ranger. Changes -

Re: Review Request 57988: RANGER-1479 : Fix bug in ranger-*-(security/audit).xml loading, which prevented loading from JAR's

2017-03-31 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57988/ --- (Updated March 31, 2017, 10:56 a.m.) Review request for ranger. Changes -

Re: Review Request 57988: RANGER-1479 : Fix bug in ranger-*-(security/audit).xml loading, which prevented loading from JAR's

2017-03-31 Thread Zsombor Gegesy
> On March 29, 2017, 4 p.m., Colm O hEigeartaigh wrote: > > Still the same problemplease see > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=55151244 Strange, I could run git apply on the downloaded patch file on the latest apache/master branch - Zsombor --

[jira] [Updated] (RANGER-1483) Ranger hive service definition to use hive metastore directly

2017-03-31 Thread Ankita Sinha (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankita Sinha updated RANGER-1483: - Attachment: RANGER-1483_07.patch RANGER-1483_Master.patch > Ranger hive service d

[jira] [Updated] (RANGER-1483) Ranger hive service definition to use hive metastore directly

2017-03-31 Thread Ankita Sinha (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankita Sinha updated RANGER-1483: - Attachment: (was: RANGER-1483_07.patch) > Ranger hive service definition to use hive metastor

[jira] [Updated] (RANGER-1483) Ranger hive service definition to use hive metastore directly

2017-03-31 Thread Ankita Sinha (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankita Sinha updated RANGER-1483: - Attachment: (was: RANGER-1483_Master.patch) > Ranger hive service definition to use hive meta

Re: Review Request 58067: Ranger hive service definition to use hive metastore directly

2017-03-31 Thread Ankita Sinha
> On March 30, 2017, 8:40 p.m., Ramesh Mani wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java > > Lines 306 (patched) > > > > > > Do we need this to be set to null explici

Re: Review Request 58067: Ranger hive service definition to use hive metastore directly

2017-03-31 Thread Ankita Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58067/ --- (Updated March 31, 2017, 9:15 a.m.) Review request for ranger, Don Bosco Durai,

Re: Review Request 58068: Ranger hive service definition to use hive metastore directly

2017-03-31 Thread Ankita Sinha
> On March 30, 2017, 6:46 a.m., Colm O hEigeartaigh wrote: > > In HiveClient, the additional properties (+ the existing ones) should all > > be made private. Also remove the default values (= null, = false, etc.). > > Some of the statements are not consistent in terms of whitespace, for > > exa

[jira] [Commented] (RANGER-1474) On SP12, hive policy page opens up with UDF as default under resources, rather than table.

2017-03-31 Thread Nitin Galave (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950508#comment-15950508 ] Nitin Galave commented on RANGER-1474: -- Committed to [master|https://github.com/apa