Re: Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices

2018-08-03 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68186/#review206850 --- agents-common/src/main/java/org/apache/ranger/plugin/errors/Valid

[jira] [Updated] (RANGER-2177) Handle validations for duplicate configuration item during service create/edit

2018-08-03 Thread Peng Xing (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peng Xing updated RANGER-2177: -- Attachment: 0001-RANGER-2177-Handle-validations-for-duplicate-configu.patch > Handle validations for d

Review Request 68184: RANGER-2177 Handle validations for duplicate configuration item during service create/edit

2018-08-03 Thread Xing Peng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68184/ --- Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, G

[jira] [Reopened] (RANGER-2168) Add service admin user through service config

2018-08-03 Thread Pradeep Agrawal (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Agrawal reopened RANGER-2168: - Reopening the issue as When keyadmin role user is added as service admin user in kms servic

[jira] [Updated] (RANGER-2168) Add service admin user through service config

2018-08-03 Thread Pradeep Agrawal (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Agrawal updated RANGER-2168: Attachment: RANGER-2168-3.patch > Add service admin user through service config >

[jira] [Updated] (RANGER-2168) Add service admin user through service config

2018-08-03 Thread Pradeep Agrawal (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Agrawal updated RANGER-2168: Attachment: (was: 0001-Add-service-admin-user-through-service-config.patch) > Add ser

[jira] [Updated] (RANGER-2168) Add service admin user through service config

2018-08-03 Thread Pradeep Agrawal (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Agrawal updated RANGER-2168: Attachment: RANGER-2168-2.patch > Add service admin user through service config >

Review Request 68185: RANGER-2168: Add service admin user through service config

2018-08-03 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68185/ --- Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Abhay Kulk

Re: Review Request 68185: RANGER-2168: Add service admin user through service config

2018-08-03 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68185/ --- (Updated Aug. 3, 2018, 11:12 a.m.) Review request for ranger, Ankita Sinha, dee

[jira] [Updated] (RANGER-2181) Code Improvement To Follow Best Practices

2018-08-03 Thread bhavik patel (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] bhavik patel updated RANGER-2181: - Attachment: 0001-RANGER-2181-Code-Improvement-To-Follow-Best-Practice.patch > Code Improvement T

Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices

2018-08-03 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68186/ --- Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Ne

Re: Review Request 68185: RANGER-2168: Add service admin user through service config

2018-08-03 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68185/#review206845 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 3, 2018, 11

[jira] [Commented] (RANGER-2172) Good coding practices for unix authentication Service in Ranger

2018-08-03 Thread Sailaja Polavarapu (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568515#comment-16568515 ] Sailaja Polavarapu commented on RANGER-2172: New review request is available

[jira] [Updated] (RANGER-2172) Good coding practices for unix authentication Service in Ranger

2018-08-03 Thread Sailaja Polavarapu (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sailaja Polavarapu updated RANGER-2172: --- Attachment: 0001-RANGER-2172-Fixing-minor-issue-with-the-no.-of-chara.patch > Good c

Re: Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices

2018-08-03 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68186/#review206848 --- Fix it and ship it. agents-common/src/main/java/org/apache/range

[jira] [Commented] (RANGER-2168) Add service admin user through service config

2018-08-03 Thread Pradeep Agrawal (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568628#comment-16568628 ] Pradeep Agrawal commented on RANGER-2168: - Second patch committed to Apache Rang