Re: Review Request 72800: [RANGER-2967] Add support for Amazon CloudWatch Logs as an Audit Store

2021-12-07 Thread Yao Zhou
Watch Logs successfully Thanks, Yao Zhou

Re: Review Request 73756: RANGER-3540: Add support to read audit logs from Amazon CloudWatch

2021-12-15 Thread Yao Zhou
/r/73756/#comment312899> nit: add a comment on this. security-admin/src/main/java/org/apache/ranger/amazon/cloudwatch/CloudWatchUtil.java Lines 137-141 (patched) <https://reviews.apache.org/r/73756/#comment312900> same comment: The DescribeLogStreams API supports pagination whic

Re: Review Request 73756: RANGER-3540: Add support to read audit logs from Amazon CloudWatch

2021-12-20 Thread Yao Zhou
config files. security-admin/src/main/java/org/apache/ranger/amazon/cloudwatch/CloudWatchUtil.java Lines 137-166 (patched) <https://reviews.apache.org/r/73756/#comment312927> Please see my response in rev1. When log stream is not provided, simply skip the input so that the API searche

Re: Review Request 73756: RANGER-3540: Add support to read audit logs from Amazon CloudWatch

2021-12-21 Thread Yao Zhou
tml#setLogStreamNamePrefix-java.lang.String-) ``` logStreamName = PropertiesUtil.getProperty(CONFIG_PREFIX + "." + "log_stream"); ``` - Yao Zhou On Dec. 10, 2021, 8:08 p.m., Pradeep Agrawal wrote: > > ---

Re: Review Request 73756: RANGER-3540: Add support to read audit logs from Amazon CloudWatch

2021-12-22 Thread Yao Zhou
> On Dec. 15, 2021, 8:46 p.m., Yao Zhou wrote: > > agents-audit/src/main/java/org/apache/ranger/audit/destination/AmazonCloudWatchAuditDestination.java > > Line 159 (original), 176 (patched) > > <https://reviews.apache.org/r/73756/diff/1/?file=22

Re: Review Request 73756: RANGER-3540: Add support to read audit logs from Amazon CloudWatch

2021-12-22 Thread Yao Zhou
> On Dec. 21, 2021, 7:09 p.m., Yao Zhou wrote: > > security-admin/src/main/java/org/apache/ranger/amazon/cloudwatch/CloudWatchUtil.java > > Lines 136-166 (patched) > > <https://reviews.apache.org/r/73756/diff/4/?file=2257093#file2257093line136> > > > >

Re: Review Request 73756: RANGER-3540: Add support to read audit logs from Amazon CloudWatch

2021-12-23 Thread Yao Zhou
tBlank(logStreamPrefix)) { filterLogEventsRequest.setLogStreamNamePrefix(logStreamPrefix) } ``` - Yao Zhou On Dec. 23, 2021, 6:56 a.m., Pradeep Agrawal wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 73756: RANGER-3540: Add support to read audit logs from Amazon CloudWatch

2021-12-24 Thread Yao Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73756/#review223905 --- Ship it! Ship It! - Yao Zhou On Dec. 23, 2021, 10:48 a.m

Re: Review Request 73756: RANGER-3540: Add support to read audit logs from Amazon CloudWatch

2021-12-24 Thread Yao Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73756/#review223906 --- Ship it! Ship It! - Yao Zhou On Dec. 23, 2021, 10:48 a.m

Thread-safety in Audit Destination

2020-08-22 Thread Yao Zhou
Hi Rangers, I am a developer who wants to implement a new audit destination similar to Solr. I observed that many places are using synchronization[1][2]. I wonder if this is needed to ensure the audit destination is thread-safe? In audit V3 configuration, audit events are always sent to a queue wh

Review Request 72800: [RANGER-2967] Add support for Amazon CloudWatch Logs as an Audit Store

2020-08-24 Thread Yao Zhou
ache.org/r/72800/diff/1/ Testing --- mvn -pl agents-audit clean install compile package Testing with Hive Audit events were sent to Amazon CloudWatch Logs successfully Thanks, Yao Zhou