Re: Review Request 57987: RANGER-1478 : Small refactor in RangerPolicyEngineCache and RangerPolicyEngineOptions, to avoid looking up RangerConfiguration everytime, and try to write the RPEO fields onl

2017-04-24 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57987/#review172772 --- Ship it! Ship It! - Colm O hEigeartaigh On April 21, 2017,

Re: Review Request 57987: RANGER-1478 : Small refactor in RangerPolicyEngineCache and RangerPolicyEngineOptions, to avoid looking up RangerConfiguration everytime, and try to write the RPEO fields onl

2017-04-21 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57987/ --- (Updated April 21, 2017, 1:17 p.m.) Review request for ranger. Changes

Re: Review Request 57987: RANGER-1478 : Small refactor in RangerPolicyEngineCache and RangerPolicyEngineOptions, to avoid looking up RangerConfiguration everytime, and try to write the RPEO fields onl

2017-04-21 Thread Zsombor Gegesy
> On March 31, 2017, 3:31 p.m., Colm O hEigeartaigh wrote: > > I'm wondering if it makes sense to make the default > > getPolicyEngineOptions() configured via "configureDelegateAdmin"? Why not > > just let ServiceREST do that part? > > Zsombor Gegesy wrote: > I thought about creating a

Re: Review Request 57987: RANGER-1478 : Small refactor in RangerPolicyEngineCache and RangerPolicyEngineOptions, to avoid looking up RangerConfiguration everytime, and try to write the RPEO fields onl

2017-04-10 Thread Colm O hEigeartaigh
> On March 31, 2017, 3:31 p.m., Colm O hEigeartaigh wrote: > > I'm wondering if it makes sense to make the default > > getPolicyEngineOptions() configured via "configureDelegateAdmin"? Why not > > just let ServiceREST do that part? > > Zsombor Gegesy wrote: > I thought about creating a

Re: Review Request 57987: RANGER-1478 : Small refactor in RangerPolicyEngineCache and RangerPolicyEngineOptions, to avoid looking up RangerConfiguration everytime, and try to write the RPEO fields onl

2017-03-31 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57987/#review170728 --- I'm wondering if it makes sense to make the default

Re: Review Request 57987: RANGER-1478 : Small refactor in RangerPolicyEngineCache and RangerPolicyEngineOptions, to avoid looking up RangerConfiguration everytime, and try to write the RPEO fields onl

2017-03-31 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57987/ --- (Updated March 31, 2017, 12:50 p.m.) Review request for ranger. Changes

Re: Review Request 57987: RANGER-1478 : Small refactor in RangerPolicyEngineCache and RangerPolicyEngineOptions, to avoid looking up RangerConfiguration everytime, and try to write the RPEO fields onl

2017-03-31 Thread Zsombor Gegesy
> On March 29, 2017, 3:53 p.m., Colm O hEigeartaigh wrote: > > Looks good, again submit patch using git. I guess, this is made by rbt, which I've tried to use to help with reviewboard. - Zsombor --- This is an automatically generated