----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58647/#review172769 -----------------------------------------------------------
Ship it! Ship It! - Colm O hEigeartaigh On April 22, 2017, 8:09 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58647/ > ----------------------------------------------------------- > > (Updated April 22, 2017, 8:09 a.m.) > > > Review request for ranger, Don Bosco Durai and Colm O hEigeartaigh. > > > Bugs: RANGER-1536 > https://issues.apache.org/jira/browse/RANGER-1536 > > > Repository: ranger > > > Description > ------- > > if(StringUtils.isEmpty(nameRules)){ > if(LOG.isDebugEnabled()){ > LOG.debug("Name is empty. Setting Name Rule as 'DEFAULT'"); > } > nameRules = DEFAULT_NAME_RULE; > } > we should change "Name is empty. Setting Name Rule as 'DEFAULT'" to "Name > Rule is empty. Setting Name Rule as 'DEFAULT'" > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/client/BaseClient.java > 941c118 > > > Diff: https://reviews.apache.org/r/58647/diff/1/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >
