Re: Review Request 63870: RANGER-1861:There are errors when the "ranger-kms start" command was executed.

2017-11-20 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63870/#review191551 --- Ship it! Ship It! - Qiang Zhang On Nov. 16, 2017, 10:03

Re: Review Request 63870: RANGER-1861:There are errors when the "ranger-kms start" command was executed.

2017-11-20 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63870/#review191494 --- Ship it! Ship It! - Colm O hEigeartaigh On Nov. 16, 2017,

Re: Review Request 63870: RANGER-1861:There are errors when the "ranger-kms start" command was executed.

2017-11-17 Thread pengjianhua
> On εδΈ€ζœˆ 16, 2017, 11:47 a.m., Colm O hEigeartaigh wrote: > > How does your change prevent the error? From what I can see the change is > > that it doesn't load the DEFAULT_CONFIG_FILENAME if an argument is > > specified. The EmbeddedServer class is only called by the security admin and KMS.

Re: Review Request 63870: RANGER-1861:There are errors when the "ranger-kms start" command was executed.

2017-11-16 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63870/#review191209 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 16, 2017,

Re: Review Request 63870: RANGER-1861:There are errors when the "ranger-kms start" command was executed.

2017-11-16 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63870/#review191172 --- How does your change prevent the error? From what I can see the

Review Request 63870: RANGER-1861:There are errors when the "ranger-kms start" command was executed.

2017-11-16 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63870/ --- Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O