Re: Review Request 66357: RANGER-2017 : Ranger KMS encryption good practices

2018-04-06 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66357/#review200636 --- Ship it! Ship It! - Velmurugan Periasamy On April 4, 2018, 6

Re: Review Request 66357: RANGER-2017 : Ranger KMS encryption good practices

2018-04-04 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66357/#review200439 --- Ship it! Ship It! - Qiang Zhang On April 4, 2018, 6:02 a.m.,

Re: Review Request 66357: RANGER-2017 : Ranger KMS encryption good practices

2018-04-03 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66357/ --- (Updated April 4, 2018, 6:02 a.m.) Review request for ranger, Ankita Sinha, Don

Re: Review Request 66357: RANGER-2017 : Ranger KMS encryption good practices

2018-04-03 Thread Qiang Zhang
> On April 3, 2018, 1:34 a.m., Qiang Zhang wrote: > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java > > Lines 81-84 (original), 133-141 (patched) > > > > > > The getEncryptedMK function can retu

Re: Review Request 66357: RANGER-2017 : Ranger KMS encryption good practices

2018-04-03 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66357/#review200423 --- kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.ja

Re: Review Request 66357: RANGER-2017 : Ranger KMS encryption good practices

2018-04-03 Thread Qiang Zhang
> On April 3, 2018, 1:34 a.m., Qiang Zhang wrote: > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java > > Lines 81-84 (original), 133-141 (patched) > > > > > > The getEncryptedMK function can retu

Re: Review Request 66357: RANGER-2017 : Ranger KMS encryption good practices

2018-04-03 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66357/ --- (Updated April 4, 2018, 3:56 a.m.) Review request for ranger, Ankita Sinha, Don

Re: Review Request 66357: RANGER-2017 : Ranger KMS encryption good practices

2018-04-03 Thread Velmurugan Periasamy
> On April 2, 2018, 9:58 p.m., Velmurugan Periasamy wrote: > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java > > Line 200 (original), 322 (patched) > > > > > > Why is salt generated from passwor

Re: Review Request 66357: RANGER-2017 : Ranger KMS encryption good practices

2018-04-03 Thread bhavik patel
> On April 2, 2018, 9:58 p.m., Velmurugan Periasamy wrote: > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java > > Line 200 (original), 322 (patched) > > > > > > Why is salt generated from passwor

Re: Review Request 66357: RANGER-2017 : Ranger KMS encryption good practices

2018-04-02 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66357/#review200338 --- kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.ja

Re: Review Request 66357: RANGER-2017 : Ranger KMS encryption good practices

2018-04-02 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66357/#review200319 --- kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.ja

Review Request 66357: RANGER-2017 : Ranger KMS encryption good practices

2018-03-29 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66357/ --- Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Ku