Re: Review Request 68871: RANGER-2238 String comparison should not use ‘==’ in ServiceUtil.java

2018-10-11 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68871/#review209474 --- Ship it! Ship It! - pengjianhua On 十月 8, 2018, 2:08 a.m.,

Re: Review Request 68871: RANGER-2238 String comparison should not use ‘==’ in ServiceUtil.java

2018-10-11 Thread Qiang Zhang
> On 十月 10, 2018, 3:31 p.m., Velmurugan Periasamy wrote: > > security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java > > Line 859 (original), 859 (patched) > > > > > > Could you please make sure that

Re: Review Request 68871: RANGER-2238 String comparison should not use ‘==’ in ServiceUtil.java

2018-10-10 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68871/#review209412 --- Fix it, then Ship it!

Re: Review Request 68871: RANGER-2238 String comparison should not use ‘==’ in ServiceUtil.java

2018-10-07 Thread Qiang Zhang
> On 十月 2, 2018, 3:55 p.m., Velmurugan Periasamy wrote: > > security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java > > Line 859 (original), 859 (patched) > > > > > > Better to use equalsIgnoreCase ?

Re: Review Request 68871: RANGER-2238 String comparison should not use ‘==’ in ServiceUtil.java

2018-10-07 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68871/ --- (Updated 十月 8, 2018, 2:08 a.m.) Review request for ranger, Ankita Sinha, Don

Re: Review Request 68871: RANGER-2238 String comparison should not use ‘==’ in ServiceUtil.java

2018-10-02 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68871/#review209152 ---

Re: Review Request 68871: RANGER-2238 String comparison should not use ‘==’ in ServiceUtil.java

2018-10-02 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68871/#review209145 --- Ship it! Ship It! - Colm O hEigeartaigh On Sept. 28, 2018,

Review Request 68871: RANGER-2238 String comparison should not use ‘==’ in ServiceUtil.java

2018-09-27 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68871/ --- Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh,