Review Request 70629: RANGER-2414: Enhancements to support roles in Ranger policies

2019-05-10 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70629/ --- Review request for ranger, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galav

Re: Review Request 70629: RANGER-2414: Enhancements to support roles in Ranger policies

2019-05-11 Thread Don Bosco Durai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70629/#review215198 --- agents-common/src/main/java/org/apache/ranger/plugin/model/Ranger

Re: Review Request 70629: RANGER-2414: Enhancements to support roles in Ranger policies

2019-05-11 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70629/#review215200 --- agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAud

Re: Review Request 70629: RANGER-2414: Enhancements to support roles in Ranger policies

2019-05-13 Thread Abhay Kulkarni
> On May 11, 2019, 7:10 a.m., Don Bosco Durai wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java > > Lines 944 (patched) > > > > > > Do we have small window where the roles could

Re: Review Request 70629: RANGER-2414: Enhancements to support roles in Ranger policies

2019-05-13 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70629/ --- (Updated May 14, 2019, 1:55 a.m.) Review request for ranger, Madhan Neethiraj,

Re: Review Request 70629: RANGER-2414: Enhancements to support roles in Ranger policies

2019-05-13 Thread Abhay Kulkarni
> On May 11, 2019, 5:08 p.m., Madhan Neethiraj wrote: > > agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java > > Lines 127 (patched) > > > > > > Would this include all roles of the user, at

Re: Review Request 70629: RANGER-2414: Enhancements to support roles in Ranger policies

2019-05-13 Thread Don Bosco Durai
> On May 11, 2019, 7:10 a.m., Don Bosco Durai wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java > > Lines 944 (patched) > > > > > > Do we have small window where the roles could

Re: Review Request 70629: RANGER-2414: Enhancements to support roles in Ranger policies

2019-05-13 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70629/#review215233 --- agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAud

Re: Review Request 70629: RANGER-2414: Enhancements to support roles in Ranger policies

2019-05-14 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70629/ --- (Updated May 15, 2019, 1:58 a.m.) Review request for ranger, Madhan Neethiraj,

Re: Review Request 70629: RANGER-2414: Enhancements to support roles in Ranger policies

2019-05-14 Thread Abhay Kulkarni
> On May 11, 2019, 5:08 p.m., Madhan Neethiraj wrote: > > agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java > > Lines 127 (patched) > > > > > > Would this include all roles of the user, at

Re: Review Request 70629: RANGER-2414: Enhancements to support roles in Ranger policies

2019-05-14 Thread Abhay Kulkarni
> On May 11, 2019, 7:10 a.m., Don Bosco Durai wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java > > Lines 944 (patched) > > > > > > Do we have small window where the roles could

Re: Review Request 70629: RANGER-2414: Enhancements to support roles in Ranger policies

2019-05-14 Thread Don Bosco Durai
> On May 11, 2019, 7:10 a.m., Don Bosco Durai wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java > > Lines 944 (patched) > > > > > > Do we have small window where the roles could

Re: Review Request 70629: RANGER-2414: Enhancements to support roles in Ranger policies

2019-05-15 Thread Abhay Kulkarni
> On May 14, 2019, 3:37 a.m., Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > > Line 527 (original), 528 (patched) > > > > > > Poli

Re: Review Request 70629: RANGER-2414: Enhancements to support roles in Ranger policies

2019-05-21 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70629/ --- (Updated May 22, 2019, 1:19 a.m.) Review request for ranger, Madhan Neethiraj,

Re: Review Request 70629: RANGER-2414: Enhancements to support roles in Ranger policies

2019-05-29 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70629/ --- (Updated May 29, 2019, 10:47 p.m.) Review request for ranger, Madhan Neethiraj,

Re: Review Request 70629: RANGER-2414: Enhancements to support roles in Ranger policies

2019-05-29 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70629/#review215596 --- Fix it, then Ship it! agents-common/src/main/java/org/apache/r

Re: Review Request 70629: RANGER-2414: Enhancements to support roles in Ranger policies

2019-05-30 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70629/ --- (Updated May 30, 2019, 6:31 p.m.) Review request for ranger, Madhan Neethiraj,

Re: Review Request 70629: RANGER-2414: Enhancements to support roles in Ranger policies

2019-05-30 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70629/#review215602 --- Ship it! Ship It! - Madhan Neethiraj On May 30, 2019, 6:31 p