Re: Review Request 72272: Upgrade and improve Presto plugin

2020-04-23 Thread Bolke de Bruin
> On apr 22, 2020, 3:55 p.m., Madhan Neethiraj wrote: > > Ship It! Can it be merged now then? - Bolke --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72272/#review220428

Re: Review Request 72272: Upgrade and improve Presto plugin

2020-04-22 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72272/#review220428 --- Ship it! Ship It! - Madhan Neethiraj On April 21, 2020,

Fwd: Re: Review Request 72272: Upgrade and improve Presto plugin

2020-04-21 Thread Bolke de Bruin
Hi Madhan, Would you mind reviewing again? If you know how to ‘fix’ the assembly to ensure everything is included without putting it in the pom I will gladly do that. Cheers Bolke On 21 April 2020 at 13:45:36, Bolke de Bruin (bdbr...@gmail.com) wrote: This is an automatically generated

Re: Review Request 72272: Upgrade and improve Presto plugin

2020-04-21 Thread Bolke de Bruin
> On April 5, 2020, 6:09 p.m., Madhan Neethiraj wrote: > > agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json > > Lines 96 (patched) > > > > > > To update existing Ranger instances with these

Re: Review Request 72272: Upgrade and improve Presto plugin

2020-04-21 Thread Bolke de Bruin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72272/ --- (Updated April 21, 2020, 11:43 a.m.) Review request for ranger, Madhan

Re: Review Request 72272: Upgrade and improve Presto plugin

2020-04-20 Thread Bolke de Bruin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72272/ --- (Updated April 20, 2020, 3:46 p.m.) Review request for ranger, Madhan

Re: Review Request 72272: Upgrade and improve Presto plugin

2020-04-15 Thread Pradeep Agrawal
> On 四月 5, 2020, 6:09 p.m., Madhan Neethiraj wrote: > > agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json > > Lines 96 (patched) > > > > > > To update existing Ranger instances with these

Re: Review Request 72272: Upgrade and improve Presto plugin

2020-04-15 Thread Bolke de Bruin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72272/ --- (Updated April 15, 2020, 6:49 a.m.) Review request for ranger, Madhan

Re: Review Request 72272: Upgrade and improve Presto plugin

2020-04-14 Thread Bolke de Bruin
> On April 13, 2020, 10:16 p.m., Madhan Neethiraj wrote: > > Unit tests fail with this patch - see below for details. This is likely > > caused by change of Hadoop version in this patch (3.1.1 => 3.1.3). Please > > review and update. > > > > > > > > mvn clean package > > ... > > > >

Re: Review Request 72272: Upgrade and improve Presto plugin

2020-04-13 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72272/#review220301 --- Unit tests fail with this patch - see below for details. This is

Re: Review Request 72272: Upgrade and improve Presto plugin

2020-04-13 Thread Bolke de Bruin
> On April 13, 2020, 4:40 a.m., Madhan Neethiraj wrote: > > plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java > > Lines 206 (patched) > > > > > > None of

Re: Review Request 72272: Upgrade and improve Presto plugin

2020-04-12 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72272/#review220292 ---

Re: Review Request 72272: Upgrade and improve Presto plugin

2020-04-10 Thread Bolke de Bruin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72272/ --- (Updated April 10, 2020, 6 p.m.) Review request for ranger, Madhan Neethiraj,

Re: Review Request 72272: Upgrade and improve Presto plugin

2020-04-10 Thread Bolke de Bruin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72272/ --- (Updated April 10, 2020, 5:16 p.m.) Review request for ranger, Madhan

Re: Review Request 72272: Upgrade and improve Presto plugin

2020-04-10 Thread Bolke de Bruin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72272/ --- (Updated April 10, 2020, 9:09 a.m.) Review request for ranger, Madhan

Re: Review Request 72272: Upgrade and improve Presto plugin

2020-04-10 Thread Bolke de Bruin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72272/ --- (Updated April 10, 2020, 8:55 a.m.) Review request for ranger, Madhan

Re: Review Request 72272: Upgrade and improve Presto plugin

2020-04-10 Thread Bolke de Bruin
> On April 5, 2020, 6:09 p.m., Madhan Neethiraj wrote: > > plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java > > Lines 74 (patched) > > > > > > Since

Re: Review Request 72272: Upgrade and improve Presto plugin

2020-04-05 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72272/#review220223 ---

Fwd: Review Request 72272: Upgrade and improve Presto plugin

2020-04-03 Thread Bolke de Bruin
friendly ping Thx Bolke Verstuurd vanaf mijn iPad Begin doorgestuurd bericht: > Van: Bolke de Bruin > Datum: 30 maart 2020 om 19:20:10 CEST > Aan: Pradeep Agrawal , Mehul Parikh > , Madhan Neethiraj , Ramesh Mani > , Bolke de Bruin > Onderwerp: Antw: Review Requ

Re: Review Request 72272: Upgrade and improve Presto plugin

2020-03-26 Thread Bolke de Bruin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72272/ --- (Updated March 26, 2020, 2:07 p.m.) Review request for ranger. Bugs:

Review Request 72272: Upgrade and improve Presto plugin

2020-03-26 Thread Bolke de Bruin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72272/ --- Review request for ranger. Bugs: