Re: Review Request 73963: RANGER-3737 : Usersync is broken due to NullPointerException

2022-05-05 Thread Kirby Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73963/#review224407 --- Ship it! Ship It! - Kirby Zhou On 四月 28, 2022, 10:16 a.m., b

Re: Review Request 73963: RANGER-3737 : Usersync is broken due to NullPointerException

2022-05-03 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73963/#review224399 --- Ship it! Ship It! - Madhan Neethiraj On April 28, 2022, 10:1

Re: Review Request 73963: RANGER-3737 : Usersync is broken due to NullPointerException

2022-04-28 Thread bhavik patel
> On April 28, 2022, 10:05 a.m., Kirby Zhou wrote: > > I have some doubts, under what circumstances will sessionMgr == null. > > Spring shoud auto-wire it. > > Maybe we should check whether authentication == null instead. > > bhavik patel wrote: > exactly sessionMgr is comming as a null. I t

Re: Review Request 73963: RANGER-3737 : Usersync is broken due to NullPointerException

2022-04-28 Thread bhavik patel
> On April 28, 2022, 10:05 a.m., Kirby Zhou wrote: > > I have some doubts, under what circumstances will sessionMgr == null. > > Spring shoud auto-wire it. > > Maybe we should check whether authentication == null instead. exactly sessionMgr is comming as a null. I tried by removing that check.

Re: Review Request 73963: RANGER-3737 : Usersync is broken due to NullPointerException

2022-04-28 Thread bhavik patel
> On April 28, 2022, 10:05 a.m., Kirby Zhou wrote: > > security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java > > Line 22 (original) > > > > > > "import xxx" is not related t

Re: Review Request 73963: RANGER-3737 : Usersync is broken due to NullPointerException

2022-04-28 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73963/ --- (Updated April 28, 2022, 10:16 a.m.) Review request for ranger, Kirby Zhou, Abh

Re: Review Request 73963: RANGER-3737 : Usersync is broken due to NullPointerException

2022-04-28 Thread Kirby Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73963/#review224382 --- I have some doubts, under what circumstances will sessionMgr == nu

Review Request 73963: RANGER-3737 : Usersync is broken due to NullPointerException

2022-04-28 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73963/ --- Review request for ranger, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mateen