Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74112/#review225249 --- Ship it! Ship It! - Madhan Neethiraj On Feb. 24, 2023, 5:02

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

> On Feb. 23, 2023, 8:39 p.m., Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPolicyDeltaUtil.java > > Line 107 (original), 96 (patched) > > > > > > Line #96 and #102 shou

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74112/ --- (Updated Feb. 24, 2023, 5:02 a.m.) Review request for ranger, Don Bosco Durai,

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74112/#review225211 --- agents-common/src/main/java/org/apache/ranger/plugin/util/RangerP

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74112/#review225210 --- agents-common/src/main/java/org/apache/ranger/plugin/util/RangerP

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

> On Feb. 23, 2023, 7:37 a.m., Kirby Zhou wrote: > > Ship It! Hi Madhan I feel it is good to go for merging - Ramachandran --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74112/#review225207

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74112/#review225207 --- Ship it! Ship It! - Kirby Zhou On 一月 29, 2023, 1:01 p.m., Ra

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

> On Jan. 29, 2023, 11:16 a.m., Kirby Zhou wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPolicyDeltaUtil.java > > Lines 121 (patched) > > > > > > just call ret.addAll(policesIdMap.values(

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

> On Jan. 29, 2023, 11:16 a.m., Kirby Zhou wrote: > > > > Ramachandran Krishnan wrote: > madhan I think that we have addressed all of the review comments in this > PR .I feel it is good to go for merging Madhan As Abhishek Kumar said, The optimizations in the review certainly reduces the

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

> On Jan. 29, 2023, 11:16 a.m., Kirby Zhou wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPolicyDeltaUtil.java > > Lines 121 (patched) > > > > > > just call ret.addAll(policesIdMap.values(

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

> On Jan. 29, 2023, 11:16 a.m., Kirby Zhou wrote: > > madhan I think that we have addressed all of the review comments in this PR .I feel it is good to go for merging - Ramachandran --- This is an automatically generated e-mail. To rep

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74112/ --- (Updated Jan. 29, 2023, 1:01 p.m.) Review request for ranger, Don Bosco Durai,

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74112/#review225137 --- agents-common/src/main/java/org/apache/ranger/plugin/util/RangerP

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74112/ --- (Updated Jan. 27, 2023, 3:51 a.m.) Review request for ranger, Don Bosco Durai,

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74112/#review225134 --- agents-common/src/main/java/org/apache/ranger/plugin/util/RangerP

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74112/ --- (Updated Jan. 25, 2023, 4:50 a.m.) Review request for ranger, Don Bosco Durai,

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

> On Jan. 24, 2023, 8:28 a.m., Abhishek Kumar wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPolicyDeltaUtil.java > > Line 61 (original), 63 (patched) > > > > > > This for loop may not be

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

> On Jan. 24, 2023, 8:28 a.m., Abhishek Kumar wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPolicyDeltaUtil.java > > Line 61 (original), 63 (patched) > > > > > > This for loop may not be

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

> On Jan. 24, 2023, 8:28 a.m., Abhishek Kumar wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPolicyDeltaUtil.java > > Line 61 (original), 63 (patched) > > > > > > This for loop may not be

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74112/ --- (Updated Jan. 24, 2023, 4:06 p.m.) Review request for ranger, Don Bosco Durai,

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74112/#review225121 --- agents-common/src/main/java/org/apache/ranger/plugin/util/RangerP

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74112/ --- (Updated Dec. 11, 2022, 7:04 a.m.) Review request for ranger, Don Bosco Durai,

Re: Review Request 74112: RANGER-3903:Improvement in RangerPolicyDeltaUtil--> applyDeltas method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74112/ --- (Updated Dec. 10, 2022, 10:12 a.m.) Review request for ranger, Don Bosco Durai,