Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74259/#review226383 --- Ship it! Ship It! - Dhaval Shah On March 23, 2024, 2:20

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74259/#review226365 --- Hi Kirby, As mentioned in Apache Jira, Can you please share the

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

> On 三月 27, 2024, 11:43 a.m., Dhaval Shah wrote: > > kms/pom.xml > > Lines 425 (patched) > > > > > > Initialize the version This version is already in ranger's pom.

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

> On 三月 27, 2024, 11:36 a.m., Dhaval Shah wrote: > > distro/src/main/assembly/kms.xml > > Line 182 (original), 185 (patched) > > > > > > Do we need tencent KMS dependency for AWS KMS? This is about streamlining

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74259/#review226354 --- kms/pom.xml Lines 425 (patched)

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74259/#review226353 --- distro/src/main/assembly/kms.xml Line 182 (original), 185

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74259/ --- (Updated 三月 23, 2024, 2:20 a.m.) Review request for ranger, Dhaval Shah,

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74259/#review226343 ---

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74259/ --- (Updated 三月 21, 2024, 9:21 a.m.) Review request for ranger, Dhaval Shah,

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

> On 三月 30, 2023, 11:27 a.m., Kishor Gollapalliwar wrote: > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerAWSKMSProvider.java > > Lines 24 (patched) > > > > > > Please consider importing individual classes

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74259/ --- (Updated 四月 7, 2023, 11:16 a.m.) Review request for ranger, Dhaval Shah,

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74259/#review225323 ---

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74259/#review225314 --- anybody else can review it and merge? - Kirby Zhou On 一月 17,

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74259/ --- (Updated 一月 17, 2023, 9:49 a.m.) Review request for ranger, Dhaval Shah,

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

> On 十二月 28, 2022, 3:33 a.m., Selvamohan Neethiraj wrote: > > kms/scripts/install.properties > > Lines 135 (patched) > > > > > > Please remove the actual credential from here and provide comments as > > how it

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74259/#review225026 --- kms/scripts/install.properties Lines 135 (patched)

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

Need one more reviewer, thanks. 在 2022/12/19 16:01，“bhavik patel”mailto:nore...@reviews.apache.org> 代表 bhavikpatel...@gmail.com > 写入: --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74259/#review225012 --- Ship it! Ship It! - bhavik patel On Dec. 19, 2022, 7:49

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

> On 十二月 19, 2022, 6:07 a.m., bhavik patel wrote: > > Is testing completed for this? Any plan to write utility script to migrate > > masterkey from ranger DB to aws kms and vice-versa? Tested. Migrate script is blocked by RANGER-3682, I want to simpify the code structrue of old KMS at first.

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74259/ --- (Updated 十二月 19, 2022, 7:49 a.m.) Review request for ranger, Dhaval Shah,

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74259/#review225008 --- Is testing completed for this? Any plan to write utility script

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74259/ --- (Updated 十二月 16, 2022, 10:27 a.m.) Review request for ranger, Dhaval Shah,

Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74259/ --- Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Gautam Borad,