Re: Review Request 74966: RANGER-4787: reduce plugin memory footprint by avoiding unnecessary creation of collections

2024-05-06 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74966/ --- (Updated May 6, 2024, 11:53 p.m.) Review request for ranger, Abhishek Kumar, A

Re: Review Request 74966: RANGER-4787: reduce plugin memory footprint by avoiding unnecessary creation of collections

2024-05-06 Thread Madhan Neethiraj
> On May 6, 2024, 11:15 p.m., Abhay Kulkarni wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > > Lines 96 (patched) > > > > > > The default value seems to be OptimalNullSa

Re: Review Request 74966: RANGER-4787: reduce plugin memory footprint by avoiding unnecessary creation of collections

2024-05-06 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74966/#review226417 --- Fix it, then Ship it! agents-common/src/main/java/org/apache/r

Re: Review Request 74966: RANGER-4787: reduce plugin memory footprint by avoiding unnecessary creation of collections

2024-05-05 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74966/ --- (Updated May 5, 2024, 8:43 a.m.) Review request for ranger, Abhishek Kumar, As

Re: Review Request 74966: RANGER-4787: reduce plugin memory footprint by avoiding unnecessary creation of collections

2024-05-02 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74966/ --- (Updated May 2, 2024, 8:02 a.m.) Review request for ranger, Abhishek Kumar, As

Re: Review Request 74966: RANGER-4787: reduce plugin memory footprint by avoiding unnecessary creation of collections

2024-05-02 Thread Madhan Neethiraj
> On May 2, 2024, 12:45 a.m., Abhay Kulkarni wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java > > Line 39 (original), 36 (patched) > > > > > > This is a general comment/suggestio

Re: Review Request 74966: RANGER-4787: reduce plugin memory footprint by avoiding unnecessary creation of collections

2024-05-01 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74966/#review226409 --- agents-common/src/main/java/org/apache/ranger/plugin/model/Ranger