Re: Code review release 2.2.1 - dedicated to Fred Oliver

2012-02-11 Thread Simon IJskes - QCG
On 11-02-12 12:08, Peter wrote: I'm glad you were watching Sim, I wasn't even aware it went awry. Did you see the emails jenkins sent? Gr. Simon -- QCG, Software voor het MKB, 071-5890970, http://www.qcg.nl Quality Consultancy Group b.v., Leiderdorp, Kvk Den Haag: 28088397

Re: Code review release 2.2.1 - dedicated to Fred Oliver

2012-02-11 Thread Peter Firmstone
Simon IJskes - QCG wrote: On 11-02-12 12:08, Peter wrote: I'm glad you were watching Sim, I wasn't even aware it went awry. Did you see the emails jenkins sent? Gr. Simon Yeah, those were just new junit tests that were testing some functionality I hadn't yet implemented, I figured I could

Re: Code review release 2.2.1 - dedicated to Fred Oliver

2012-02-11 Thread Peter Firmstone
Simon IJskes - QCG wrote: On 11-02-12 12:08, Peter wrote: - Original message - On 11-02-12 06:56, Peter wrote: Lets dedicate this release to Fred Oliver, please dive in and review recent code changes and ask questions, make sure the javadoc makes sense. Let's make it the best