[GitHub] zongtanghu commented on issue #403: ACL feature request

2019-01-18 Thread GitBox
zongtanghu commented on issue #403: ACL feature request URL: https://github.com/apache/rocketmq/issues/403#issuecomment-455757764 @jayden88 The feature acl have already been merged.You can see the codes in the 4.4.0 version of RocketMQ. -

[GitHub] ZhangShenao removed a comment on issue #700: Potential Concurrent Risk in RouteInfoManager

2019-01-18 Thread GitBox
ZhangShenao removed a comment on issue #700: Potential Concurrent Risk in RouteInfoManager URL: https://github.com/apache/rocketmq/issues/700#issuecomment-455755354 这里是否可以考虑使用ConcurrentHashMap? This is an automated message fr

[GitHub] ZhangShenao opened a new issue #700: Potential Concurrent Risk in RouteInfoManager

2019-01-18 Thread GitBox
ZhangShenao opened a new issue #700: Potential Concurrent Risk in RouteInfoManager URL: https://github.com/apache/rocketmq/issues/700 The method scanNotActiveBroker() in RouteInfoManager : ` public void scanNotActiveBroker() { Iterator> it = this.brokerLiveTable.entrySet(

[GitHub] ZhangShenao commented on issue #700: Potential Concurrent Risk in RouteInfoManager

2019-01-18 Thread GitBox
ZhangShenao commented on issue #700: Potential Concurrent Risk in RouteInfoManager URL: https://github.com/apache/rocketmq/issues/700#issuecomment-455755354 这里是否可以考虑使用ConcurrentHashMap? This is an automated message from the A

[GitHub] ZhangShenao closed issue #700: Potential Concurrent Risk in RouteInfoManager

2019-01-18 Thread GitBox
ZhangShenao closed issue #700: Potential Concurrent Risk in RouteInfoManager URL: https://github.com/apache/rocketmq/issues/700 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] ZhangShenao commented on issue #700: Potential Concurrent Risk in RouteInfoManager

2019-01-18 Thread GitBox
ZhangShenao commented on issue #700: Potential Concurrent Risk in RouteInfoManager URL: https://github.com/apache/rocketmq/issues/700#issuecomment-455755373 > 修改不会报错,如果是新增或者删除的话,这个迭代会报错。 这里不加锁很大的原因在于10S执行一次很频繁的,如果这个时候真的有添加的话报错的话也没事儿。我感觉应该更多的考虑是扫描发现不可用的概率非常低。 这里是否可以考虑使用ConcurrentHash

[GitHub] ifplusor commented on issue #71: consumer.start() segment fault

2019-01-18 Thread GitBox
ifplusor commented on issue #71: consumer.start() segment fault URL: https://github.com/apache/rocketmq-client-cpp/issues/71#issuecomment-455751183 @MemeTao I try fixing this in PR #73 , could you test it? This is an automat

[GitHub] ifplusor opened a new pull request #73: Fixed: return dangling reference.

2019-01-18 Thread GitBox
ifplusor opened a new pull request #73: Fixed: return dangling reference. URL: https://github.com/apache/rocketmq-client-cpp/pull/73 MQMessage::getProperty return a dangling reference when return empty string. This is an autom

[GitHub] MemeTao edited a comment on issue #71: consumer.start() segment fault

2019-01-18 Thread GitBox
MemeTao edited a comment on issue #71: consumer.start() segment fault URL: https://github.com/apache/rocketmq-client-cpp/issues/71#issuecomment-455535649 I guess there is a big problem with your string-related functions. such as,: file: consumeMessageConcurrentlyService.cpp void Cons

[GitHub] duhenglucky merged pull request #703: [ISSUE 403]add acl model to snode branch, adjust some codes and pass all of unit test cases in acl model.

2019-01-18 Thread GitBox
duhenglucky merged pull request #703: [ISSUE 403]add acl model to snode branch,adjust some codes and pass all of unit test cases in acl model. URL: https://github.com/apache/rocketmq/pull/703 This is an automated message fro

[GitHub] zhhlovely commented on issue #700: Potential Concurrent Risk in RouteInfoManager

2019-01-18 Thread GitBox
zhhlovely commented on issue #700: Potential Concurrent Risk in RouteInfoManager URL: https://github.com/apache/rocketmq/issues/700#issuecomment-41581 修改不会报错,如果是新增或者删除的话,这个迭代会报错。 这里不加锁很大的原因在于10S执行一次很频繁的,如果这个时候真的有添加的话报错的话也没事儿。我感觉应该更多的考虑是扫描发现不可用的概率非常低。 ---

[GitHub] MemeTao edited a comment on issue #71: consumer.start() segment fault

2019-01-18 Thread GitBox
MemeTao edited a comment on issue #71: consumer.start() segment fault URL: https://github.com/apache/rocketmq-client-cpp/issues/71#issuecomment-455535649 I guess there is a big problem with your string-related functions. such as,: file: consumeMessageConcurrentlyService.cpp void Cons

[GitHub] MemeTao edited a comment on issue #71: consumer.start() segment fault

2019-01-18 Thread GitBox
MemeTao edited a comment on issue #71: consumer.start() segment fault URL: https://github.com/apache/rocketmq-client-cpp/issues/71#issuecomment-455535649 I guess there is a big problem with your string-related functions. such as,: file: consumeMessageConcurrentlyService.cpp void Cons

[GitHub] MemeTao commented on issue #71: consumer.start() segment fault

2019-01-18 Thread GitBox
MemeTao commented on issue #71: consumer.start() segment fault URL: https://github.com/apache/rocketmq-client-cpp/issues/71#issuecomment-455535649 I guess there is a big problem with your string-related functions. such as,: file: consumeMessageConcurrentlyService.cpp void ConsumeMess

[GitHub] ShannonDing commented on issue #33: can no run

2019-01-18 Thread GitBox
ShannonDing commented on issue #33: can no run URL: https://github.com/apache/rocketmq-spring/issues/33#issuecomment-455532596 Could you please leave more information according to the ISSUE TEMPLATE? This is an automated messa

[GitHub] LuciferInLove opened a new issue #704: Messages become unread when one of masters stops

2019-01-18 Thread GitBox
LuciferInLove opened a new issue #704: Messages become unread when one of masters stops URL: https://github.com/apache/rocketmq/issues/704 Hello. I have a cluster-configured RocketMQ docker deployment. There are 3 broker sets in one cluster: 3 masters and 3 slaves with the same brokerClus

[GitHub] walking98 opened a new issue #34: Change rocketmq-spring-boot-samples pom.xml to use the 2.0.1 version

2019-01-18 Thread GitBox
walking98 opened a new issue #34: Change rocketmq-spring-boot-samples pom.xml to use the 2.0.1 version URL: https://github.com/apache/rocketmq-spring/issues/34 1. Need to update the samples pom.xml to user the released starter version 2.0.1 2. Need to update related README and let use

[GitHub] ShannonDing merged pull request #28: Polish Travis:download CPP core from oss us region.

2019-01-18 Thread GitBox
ShannonDing merged pull request #28: Polish Travis:download CPP core from oss us region. URL: https://github.com/apache/rocketmq-client-python/pull/28 This is an automated message from the Apache Git Service. To respond to t

[GitHub] ShannonDing merged pull request #27: Polish Travis:download CPP core from oss us region.

2019-01-18 Thread GitBox
ShannonDing merged pull request #27: Polish Travis:download CPP core from oss us region. URL: https://github.com/apache/rocketmq-client-python/pull/27 This is an automated message from the Apache Git Service. To respond to t

[GitHub] ShannonDing commented on issue #71: consumer.start() segment fault

2019-01-18 Thread GitBox
ShannonDing commented on issue #71: consumer.start() segment fault URL: https://github.com/apache/rocketmq-client-cpp/issues/71#issuecomment-455509187 Could you please share the backtrace? This is an automated message from t

[VOTE] Release Apache RocketMQ 4.4.0 RC1.

2019-01-18 Thread Shannon
Hello RocketMQ Community, This is the vote for 4.4.0 of Apache RocketMQ. This release implemented three new features such as ACL, message trace, and fixed some bugs, further improved the stability of RocketMQ. The artifacts: https://dist.apache.org/repos/dist/dev/rocketmq/4.4.0-rc1/

[VOTE] Release Apache RocketMQ 4.4.0 RC1.

2019-01-18 Thread Shannon
Hello RocketMQ Community, This is the vote for 4.4.0 of Apache RocketMQ. This release implemented three new features such as ACL, message trace, and fixed some bugs, further improved the stability of RocketMQ. The artifacts: https://dist.apache.org/repos/dist/dev/rocketmq/4.4.0-rc1/

[GitHub] jovany-wang opened a new pull request #72: Enable clang format in CI

2019-01-18 Thread GitBox
jovany-wang opened a new pull request #72: Enable clang format in CI URL: https://github.com/apache/rocketmq-client-cpp/pull/72 After this change, the CI will check the code style when requesting a PR. It just check the codes that you changed instead of all the codes of this repo. -

[GitHub] MemeTao opened a new issue #71: consumer.start() segment fault

2019-01-18 Thread GitBox
MemeTao opened a new issue #71: consumer.start() segment fault URL: https://github.com/apache/rocketmq-client-cpp/issues/71 I run "./PushConsumer“ fail after build example,but PullConsumer is ok. client log : [2019-01-18 17:31:35.315213](info):DefaultMQPushConsumer::boost asio async

[GitHub] degnbo opened a new issue #33: can no run

2019-01-18 Thread GitBox
degnbo opened a new issue #33: can no run URL: https://github.com/apache/rocketmq-spring/issues/33 The issue tracker is **ONLY** used for bug report and feature request. Any question or RocketMQ proposal please use our [mailing lists](http://rocketmq.apache.org/about/contact/).

回复: Re: [Vote] [RIP-9]RocketMQ Developer Guide

2019-01-18 Thread chengxiangw...@cmss.chinamobile.com
+1 程向往 chengxiangw...@cmss.chinamobile.com 18896725053(685053) 中移(苏州)软件技术有限公司 云计算产品部 江苏省苏州市高新区昆仑山路58号 发件人: Shannon 发送时间: 2019-01-18 15:50 收件人: dev@rocketmq.apache.org 抄送: us...@rocketmq.apache.org 主题: Re: [Vote] [RIP-9]RocketMQ Developer Guide +1 在 2019年1月18日,上午11:14,Li Martin 写道: +1

[GitHub] vongosling commented on issue #701: add http2 unit test case, fix http2 shutdown issue and adjust some codes

2019-01-18 Thread GitBox
vongosling commented on issue #701: add http2 unit test case,fix http2 shutdown issue and adjust some codes URL: https://github.com/apache/rocketmq/pull/701#issuecomment-455479057 @zongtanghu Could you please follow the pr template, I have not seen your issue binding with this pr. 5.0 is a

[GitHub] ShannonDing merged pull request #69: Remove the unnessesary code it may cause dead loop for some scene

2019-01-18 Thread GitBox
ShannonDing merged pull request #69: Remove the unnessesary code it may cause dead loop for some scene URL: https://github.com/apache/rocketmq-client-cpp/pull/69 This is an automated message from the Apache Git Service. To

[GitHub] zongtanghu opened a new pull request #703: add acl model to snode branch, adjust some codes and pass all of unit test cases in acl model.

2019-01-18 Thread GitBox
zongtanghu opened a new pull request #703: add acl model to snode branch,adjust some codes and pass all of unit test cases in acl model. URL: https://github.com/apache/rocketmq/pull/703 ## What is the purpose of the change add acl model to snode branch,adjust some codes and pass all

Re: [VOTE] RocketMQ spring 2.0.1 release.

2019-01-18 Thread Shannon
+1 > 在 2019年1月18日,下午4:22,huzongt...@cmss.chinamobile.com 写道: > > +1 > > huzongt...@cmss.chinamobile.com > > From: heng du > Date: 2019-01-18 13:16 > To: users > Subject: Re: [VOTE] Rock