[GitHub] chenhaoxiang opened a new pull request #781: [RIP-9] Added sample English documents of English transaction messages

2019-02-15 Thread GitBox
chenhaoxiang opened a new pull request #781: [RIP-9] Added sample English documents of English transaction messages URL: https://github.com/apache/rocketmq/pull/781 ## What is the purpose of the change RocketMQ Developer Guide doc ## Brief changelog Organize the English transla

[GitHub] chenhaoxiang closed pull request #775: [RIP-9] Added sample English documents of English transaction messages

2019-02-15 Thread GitBox
chenhaoxiang closed pull request #775: [RIP-9] Added sample English documents of English transaction messages URL: https://github.com/apache/rocketmq/pull/775 This is an automated message from the Apache Git Service. To resp

[GitHub] coveralls edited a comment on issue #773: [RIP-10] ADD ScheduleMessageServiceTest

2019-02-15 Thread GitBox
coveralls edited a comment on issue #773: [RIP-10] ADD ScheduleMessageServiceTest URL: https://github.com/apache/rocketmq/pull/773#issuecomment-464010469 [![Coverage Status](https://coveralls.io/builds/21682479/badge)](https://coveralls.io/builds/21682479) Coverage increased (+0

[GitHub] coveralls commented on issue #780: [RIP-9] Add the English description document for Deployment.md

2019-02-15 Thread GitBox
coveralls commented on issue #780: [RIP-9] Add the English description document for Deployment.md URL: https://github.com/apache/rocketmq/pull/780#issuecomment-464293672 [![Coverage Status](https://coveralls.io/builds/21682211/badge)](https://coveralls.io/builds/21682211) Covera

[GitHub] SeekerWu667 opened a new pull request #780: [RIP-9] Add the English description document for Deployment.md

2019-02-15 Thread GitBox
SeekerWu667 opened a new pull request #780: [RIP-9] Add the English description document for Deployment.md URL: https://github.com/apache/rocketmq/pull/780 ## What is the purpose of the change add the English description document for Deployment.md ## Brief changelog Add

[GitHub] coveralls commented on issue #779: [RIP-9] Add an delay example in RocketMQ

2019-02-15 Thread GitBox
coveralls commented on issue #779: [RIP-9] Add an delay example in RocketMQ URL: https://github.com/apache/rocketmq/pull/779#issuecomment-464283760 [![Coverage Status](https://coveralls.io/builds/21681928/badge)](https://coveralls.io/builds/21681928) Coverage increased (+0.08%) t

[GitHub] coveralls edited a comment on issue #777: [RIP-10] Add test cases for DefaultMessageStore.putMessages

2019-02-15 Thread GitBox
coveralls edited a comment on issue #777: [RIP-10] Add test cases for DefaultMessageStore.putMessages URL: https://github.com/apache/rocketmq/pull/777#issuecomment-464279546 [![Coverage Status](https://coveralls.io/builds/21681931/badge)](https://coveralls.io/builds/21681931) Co

[GitHub] ThailandKing opened a new pull request #779: [RIP-9] Add an delay example in RocketMQ

2019-02-15 Thread GitBox
ThailandKing opened a new pull request #779: [RIP-9] Add an delay example in RocketMQ URL: https://github.com/apache/rocketmq/pull/779 ## What is the purpose of the change Add an example in RocketMQ ## Brief changelog Add an delay example in RocketMQ ## Verifying

[GitHub] coveralls commented on issue #777: [RIP-10] Add test cases for DefaultMessageStore.putMessages

2019-02-15 Thread GitBox
coveralls commented on issue #777: [RIP-10] Add test cases for DefaultMessageStore.putMessages URL: https://github.com/apache/rocketmq/pull/777#issuecomment-464279546 [![Coverage Status](https://coveralls.io/builds/21681787/badge)](https://coveralls.io/builds/21681787) Coverage

[GitHub] coveralls commented on issue #778: [RIP-10]Add test cases for DefaultMessageStore which methods read from CommitLog/ConsumeQueue

2019-02-15 Thread GitBox
coveralls commented on issue #778: [RIP-10]Add test cases for DefaultMessageStore which methods read from CommitLog/ConsumeQueue URL: https://github.com/apache/rocketmq/pull/778#issuecomment-464235993 [![Coverage Status](https://coveralls.io/builds/21671739/badge)](https://coveralls.io

[GitHub] coveralls edited a comment on issue #684: [RIP-10]Add test cases for DefaultMessageStore which methods read from CommitLog/ConsumeQueue

2019-02-15 Thread GitBox
coveralls edited a comment on issue #684: [RIP-10]Add test cases for DefaultMessageStore which methods read from CommitLog/ConsumeQueue URL: https://github.com/apache/rocketmq/pull/684#issuecomment-453824607 [![Coverage Status](https://coveralls.io/builds/21670463/badge)](https://cover

[GitHub] wnow20 opened a new pull request #778: [RIP-10]Add test cases for DefaultMessageStore which methods read from CommitLog/ConsumeQueue

2019-02-15 Thread GitBox
wnow20 opened a new pull request #778: [RIP-10]Add test cases for DefaultMessageStore which methods read from CommitLog/ConsumeQueue URL: https://github.com/apache/rocketmq/pull/778 ## What is the purpose of the change add test cases for DefaultMessageStore.lookMessageByOffset

[GitHub] odbozhou opened a new pull request #777: [RIP-10]Add test cases for DefaultMessageStore.putMessages

2019-02-15 Thread GitBox
odbozhou opened a new pull request #777: [RIP-10]Add test cases for DefaultMessageStore.putMessages URL: https://github.com/apache/rocketmq/pull/777 ## What is the purpose of the change Add test cases for DefaultMessageStore.putMessages ## Brief changelog test for Defau

[GitHub] husterxsp opened a new issue #776: make mqadmin usage information more friendly to user

2019-02-15 Thread GitBox
husterxsp opened a new issue #776: make mqadmin usage information more friendly to user URL: https://github.com/apache/rocketmq/issues/776 When I run `sh bin/mqadmin updateTopic -t topicA `, I’m confused because i get ```shell usage: mqadmin updateTopic [-b ] [-c ] [-h] [-n ] [

[GitHub] coveralls commented on issue #775: [RIP-9] Added sample English documents of English transaction messages

2019-02-15 Thread GitBox
coveralls commented on issue #775: [RIP-9] Added sample English documents of English transaction messages URL: https://github.com/apache/rocketmq/pull/775#issuecomment-464049952 [![Coverage Status](https://coveralls.io/builds/21666983/badge)](https://coveralls.io/builds/21666983)

[GitHub] chenhaoxiang opened a new pull request #775: Rocketmq example transaction

2019-02-15 Thread GitBox
chenhaoxiang opened a new pull request #775: Rocketmq example transaction URL: https://github.com/apache/rocketmq/pull/775 ## What is the purpose of the change RocketMQ Developer Guide doc ## Brief changelog Organize the English translation of the RocketMQ transaction message sa

[GitHub] coveralls commented on issue #774: [RIP-10] best practice for broker

2019-02-15 Thread GitBox
coveralls commented on issue #774: [RIP-10] best practice for broker URL: https://github.com/apache/rocketmq/pull/774#issuecomment-464039133 [![Coverage Status](https://coveralls.io/builds/21666422/badge)](https://coveralls.io/builds/21666422) Coverage increased (+0.01%) to 44.83

[GitHub] ZCChow opened a new pull request #774: [RIP-10] best practice for broker

2019-02-15 Thread GitBox
ZCChow opened a new pull request #774: [RIP-10] best practice for broker URL: https://github.com/apache/rocketmq/pull/774 This is an automated message from the Apache Git Service. To respond to the message, please log on GitH

[GitHub] chenhaoxiang closed pull request #770: [RIP-9] Added sample English documents of English transaction messages

2019-02-15 Thread GitBox
chenhaoxiang closed pull request #770: [RIP-9] Added sample English documents of English transaction messages URL: https://github.com/apache/rocketmq/pull/770 This is an automated message from the Apache Git Service. To resp

[GitHub] coveralls commented on issue #773: [RIP-10] ADD ScheduleMessageServiceTest

2019-02-15 Thread GitBox
coveralls commented on issue #773: [RIP-10] ADD ScheduleMessageServiceTest URL: https://github.com/apache/rocketmq/pull/773#issuecomment-464010469 [![Coverage Status](https://coveralls.io/builds/21665245/badge)](https://coveralls.io/builds/21665245) Coverage increased (+0.4%) to

[GitHub] jovany-wang commented on a change in pull request #60: Update: update network interface.

2019-02-15 Thread GitBox
jovany-wang commented on a change in pull request #60: Update: update network interface. URL: https://github.com/apache/rocketmq-client-cpp/pull/60#discussion_r257198353 ## File path: src/transport/EventLoop.cpp ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

[GitHub] ifplusor commented on a change in pull request #60: Update: update network interface.

2019-02-15 Thread GitBox
ifplusor commented on a change in pull request #60: Update: update network interface. URL: https://github.com/apache/rocketmq-client-cpp/pull/60#discussion_r257194366 ## File path: src/transport/EventLoop.cpp ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] ranqiqiang opened a new pull request #773: Develop

2019-02-15 Thread GitBox
ranqiqiang opened a new pull request #773: Develop URL: https://github.com/apache/rocketmq/pull/773 ## What is the purpose of the change ADD ScheduleMessageServiceTest ## Brief changelog 1.test buildRunningStatsTest 2.test computeDeliverTimestampTest , just test delayLeve

[GitHub] ranqiqiang closed pull request #726: [RIP-10] Add ScheduleMessageServiceTest

2019-02-15 Thread GitBox
ranqiqiang closed pull request #726: [RIP-10] Add ScheduleMessageServiceTest URL: https://github.com/apache/rocketmq/pull/726 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] ShannonDing merged pull request #83: First stage 1

2019-02-15 Thread GitBox
ShannonDing merged pull request #83: First stage 1 URL: https://github.com/apache/rocketmq-client-cpp/pull/83 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use t

[GitHub] jovany-wang commented on a change in pull request #60: Update: update network interface.

2019-02-15 Thread GitBox
jovany-wang commented on a change in pull request #60: Update: update network interface. URL: https://github.com/apache/rocketmq-client-cpp/pull/60#discussion_r257178748 ## File path: src/transport/TcpRemotingClient.h ## @@ -1,133 +1,124 @@ -/* - * Licensed to the Apache S

[GitHub] jovany-wang commented on a change in pull request #60: Update: update network interface.

2019-02-15 Thread GitBox
jovany-wang commented on a change in pull request #60: Update: update network interface. URL: https://github.com/apache/rocketmq-client-cpp/pull/60#discussion_r248225882 ## File path: src/transport/EventLoop.cpp ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

[GitHub] jovany-wang commented on a change in pull request #60: Update: update network interface.

2019-02-15 Thread GitBox
jovany-wang commented on a change in pull request #60: Update: update network interface. URL: https://github.com/apache/rocketmq-client-cpp/pull/60#discussion_r248229182 ## File path: src/transport/EventLoop.cpp ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

[GitHub] jovany-wang commented on a change in pull request #60: Update: update network interface.

2019-02-15 Thread GitBox
jovany-wang commented on a change in pull request #60: Update: update network interface. URL: https://github.com/apache/rocketmq-client-cpp/pull/60#discussion_r248228454 ## File path: src/transport/EventLoop.cpp ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

[GitHub] jovany-wang commented on a change in pull request #95: [Issue#94] Support send batch message to broker

2019-02-15 Thread GitBox
jovany-wang commented on a change in pull request #95: [Issue#94] Support send batch message to broker URL: https://github.com/apache/rocketmq-client-cpp/pull/95#discussion_r257172232 ## File path: example/BatchProducer.cpp ## @@ -0,0 +1,130 @@ +/* +* Licensed to the Apach

[GitHub] jovany-wang commented on a change in pull request #95: [Issue#94] Support send batch message to broker

2019-02-15 Thread GitBox
jovany-wang commented on a change in pull request #95: [Issue#94] Support send batch message to broker URL: https://github.com/apache/rocketmq-client-cpp/pull/95#discussion_r257174617 ## File path: example/BatchProducer.cpp ## @@ -0,0 +1,130 @@ +/* +* Licensed to the Apach

[GitHub] jovany-wang commented on a change in pull request #95: [Issue#94] Support send batch message to broker

2019-02-15 Thread GitBox
jovany-wang commented on a change in pull request #95: [Issue#94] Support send batch message to broker URL: https://github.com/apache/rocketmq-client-cpp/pull/95#discussion_r257172692 ## File path: example/BatchProducer.cpp ## @@ -0,0 +1,130 @@ +/* +* Licensed to the Apach

[GitHub] jovany-wang commented on a change in pull request #95: [Issue#94] Support send batch message to broker

2019-02-15 Thread GitBox
jovany-wang commented on a change in pull request #95: [Issue#94] Support send batch message to broker URL: https://github.com/apache/rocketmq-client-cpp/pull/95#discussion_r257172451 ## File path: example/BatchProducer.cpp ## @@ -0,0 +1,130 @@ +/* +* Licensed to the Apach

[GitHub] jovany-wang commented on a change in pull request #95: [Issue#94] Support send batch message to broker

2019-02-15 Thread GitBox
jovany-wang commented on a change in pull request #95: [Issue#94] Support send batch message to broker URL: https://github.com/apache/rocketmq-client-cpp/pull/95#discussion_r257172939 ## File path: example/BatchProducer.cpp ## @@ -0,0 +1,130 @@ +/* +* Licensed to the Apach

[GitHub] jovany-wang commented on a change in pull request #95: [Issue#94] Support send batch message to broker

2019-02-15 Thread GitBox
jovany-wang commented on a change in pull request #95: [Issue#94] Support send batch message to broker URL: https://github.com/apache/rocketmq-client-cpp/pull/95#discussion_r257174819 ## File path: include/BatchMessage.h ## @@ -0,0 +1,12 @@ +#ifndef __BATCHMESSAGE_H__ +#de

[GitHub] jovany-wang commented on a change in pull request #95: [Issue#94] Support send batch message to broker

2019-02-15 Thread GitBox
jovany-wang commented on a change in pull request #95: [Issue#94] Support send batch message to broker URL: https://github.com/apache/rocketmq-client-cpp/pull/95#discussion_r257174709 ## File path: example/BatchProducer.cpp ## @@ -0,0 +1,130 @@ +/* +* Licensed to the Apach

[GitHub] ShannonDing merged pull request #92: fixed MQDecoder::createMessageId and MQDecoder::decodeMessageId.

2019-02-15 Thread GitBox
ShannonDing merged pull request #92: fixed MQDecoder::createMessageId and MQDecoder::decodeMessageId. URL: https://github.com/apache/rocketmq-client-cpp/pull/92 This is an automated message from the Apache Git Service. To re

[GitHub] ShannonDing merged pull request #72: Enable clang format in CI

2019-02-15 Thread GitBox
ShannonDing merged pull request #72: Enable clang format in CI URL: https://github.com/apache/rocketmq-client-cpp/pull/72 This is an automated message from the Apache Git Service. To respond to the message, please log on GitH

[GitHub] ShannonDing merged pull request #70: Optimize: optimize memory copy in MemoryBlock by move constructor and move assignment.

2019-02-15 Thread GitBox
ShannonDing merged pull request #70: Optimize: optimize memory copy in MemoryBlock by move constructor and move assignment. URL: https://github.com/apache/rocketmq-client-cpp/pull/70 This is an automated message from the Apa

[GitHub] ShannonDing merged pull request #78: [ISSUE #77] optimize process of allocate opaque by atomic without lock.

2019-02-15 Thread GitBox
ShannonDing merged pull request #78: [ISSUE #77] optimize process of allocate opaque by atomic without lock. URL: https://github.com/apache/rocketmq-client-cpp/pull/78 This is an automated message from the Apache Git Service

[GitHub] zongtanghu commented on issue #403: ACL feature request

2019-02-15 Thread GitBox
zongtanghu commented on issue #403: ACL feature request URL: https://github.com/apache/rocketmq/issues/403#issuecomment-463963050 please look at the develop branch of rocketmq,the acl doc is at the doc fold.https://github.com/apache/rocketmq/tree/develop/docs/cn/acl huzongt.

[GitHub] manpure commented on issue #403: ACL feature request

2019-02-15 Thread GitBox
manpure commented on issue #403: ACL feature request URL: https://github.com/apache/rocketmq/issues/403#issuecomment-463960645 @zongtanghu 官方文档中怎么没有acl的相关介绍? This is an automated message from the Apache Git Service. To respond

[GitHub] lizhanhui commented on issue #78: [ISSUE #77] optimize process of allocate opaque by atomic without lock.

2019-02-15 Thread GitBox
lizhanhui commented on issue #78: [ISSUE #77] optimize process of allocate opaque by atomic without lock. URL: https://github.com/apache/rocketmq-client-cpp/pull/78#issuecomment-463959821 +1 to get this pull request merged.

[GitHub] ranqiqiang opened a new pull request #726: [RIP-10] Add ScheduleMessageServiceTest

2019-02-15 Thread GitBox
ranqiqiang opened a new pull request #726: [RIP-10] Add ScheduleMessageServiceTest URL: https://github.com/apache/rocketmq/pull/726 ## What is the purpose of the change add ScheduleMessageService unit test This is an autom