[GitHub] [rocketmq-externals] lizhiboo opened a new pull request #795: add task woker thread name

2021-08-29 Thread GitBox
lizhiboo opened a new pull request #795: URL: https://github.com/apache/rocketmq-externals/pull/795 ## What is the purpose of the change assign thread name to worker task thread, do not use default pool-xx-thread-xx format. -- This is an automated message from the Apache Git Servi

[GitHub] [rocketmq-externals] lizhiboo opened a new issue #796: assign thread name to worker task thread

2021-08-29 Thread GitBox
lizhiboo opened a new issue #796: URL: https://github.com/apache/rocketmq-externals/issues/796 assign thread name to worker task thread, do not use default pool-xx-thread-xx format. #795 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [rocketmq-externals] lizhiboo opened a new pull request #797: fields will not be built in SinkDataEntry

2021-08-29 Thread GitBox
lizhiboo opened a new pull request #797: URL: https://github.com/apache/rocketmq-externals/pull/797 ## What is the purpose of the change fields put after SinkDataEntry built, SinkDataEntry will include fields. ```java SinkDataEntry sinkDataEntry = dataEntryBuilder.buildSink

[GitHub] [rocketmq-externals] lizhiboo opened a new issue #798: Build SinkDataEntry after fields put.

2021-08-29 Thread GitBox
lizhiboo opened a new issue #798: URL: https://github.com/apache/rocketmq-externals/issues/798 fields will not be built in SinkDataEntry. #797 ```java SinkDataEntry sinkDataEntry = dataEntryBuilder.buildSinkDataEntry(message.getQueueOffset()); List fields = sche

[GitHub] [rocketmq-externals] lizhiboo opened a new issue #799: Is needed to convert MessageExt body to String in WorkerSinkTask convertToSinkDataEntry method.

2021-08-29 Thread GitBox
lizhiboo opened a new issue #799: URL: https://github.com/apache/rocketmq-externals/issues/799 ```java private SinkDataEntry convertToSinkDataEntry(MessageExt message) { Map properties = message.getProperties(); String queueName; EntryType entryTyp

[GitHub] [rocketmq-externals] lizhiboo opened a new pull request #800: Rocketmq connector sink for hudi

2021-08-29 Thread GitBox
lizhiboo opened a new pull request #800: URL: https://github.com/apache/rocketmq-externals/pull/800 Support rocketmq connector sink to hudi. welcome to contribute together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [rocketmq-externals] lizhiboo opened a new issue #801: Support rocketmq connector sink to hudi

2021-08-29 Thread GitBox
lizhiboo opened a new issue #801: URL: https://github.com/apache/rocketmq-externals/issues/801 #800 Welcome to contribute together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [rocketmq] RongtongJin closed issue #3290: TestProcessRequest_RegisterBrokerLogicalQueue fails when running full test cases

2021-08-29 Thread GitBox
RongtongJin closed issue #3290: URL: https://github.com/apache/rocketmq/issues/3290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [rocketmq-dashboard] 953761972 opened a new issue #15: why this happened?

2021-08-29 Thread GitBox
953761972 opened a new issue #15: URL: https://github.com/apache/rocketmq-dashboard/issues/15 [2021-08-29 18:29:36.297] ERROR Application run failed java.lang.NoSuchMethodError: org.yaml.snakeyaml.nodes.ScalarNode.getScalarStyle()Lorg/yaml/snakeyaml/DumperOptions$ScalarStyle; at

[GitHub] [rocketmq] SteNicholas opened a new issue #3298: Support RocketMQ schema registry

2021-08-29 Thread GitBox
SteNicholas opened a new issue #3298: URL: https://github.com/apache/rocketmq/issues/3298 **FEATURE REQUEST** RocketMQ Flink module would add the implementation of the `Catalog` interface, which needs the schema registry feature of the RocketMQ. The schema registry feature is like t

[GitHub] [rocketmq-dashboard] StyleTang commented on issue #15: why this happened?

2021-08-29 Thread GitBox
StyleTang commented on issue #15: URL: https://github.com/apache/rocketmq-dashboard/issues/15#issuecomment-907788122 @953761972 Could you provide more information about how to reproduce it? **BUG REPORT** 1. Please describe the issue you observed: - What did you do

[GitHub] [rocketmq] hjm2015 opened a new pull request #3299: Removing redundant configurations

2021-08-29 Thread GitBox
hjm2015 opened a new pull request #3299: URL: https://github.com/apache/rocketmq/pull/3299 去除多余配置,SocketChannel 创建出来默认就是阻塞的,并且上面又再次设置非阻塞的,所以这个设置阻塞是没有必要的 **Make sure set the target branch to `develop`** ## What is the purpose of the change X ## Brief change

[GitHub] [rocketmq] hjm2015 closed pull request #3299: Removing redundant configurations

2021-08-29 Thread GitBox
hjm2015 closed pull request #3299: URL: https://github.com/apache/rocketmq/pull/3299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr.

[GitHub] [rocketmq] hjm2015 opened a new pull request #3300: Removing redundant configurations

2021-08-29 Thread GitBox
hjm2015 opened a new pull request #3300: URL: https://github.com/apache/rocketmq/pull/3300 去除多余配置,SocketChannel 创建出来默认就是阻塞的,并且后面又再次设置非阻塞的,所以这个设置阻塞是没有必要的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [rocketmq] coveralls commented on pull request #3300: Removing redundant configurations

2021-08-29 Thread GitBox
coveralls commented on pull request #3300: URL: https://github.com/apache/rocketmq/pull/3300#issuecomment-907794394 [![Coverage Status](https://coveralls.io/builds/42490584/badge)](https://coveralls.io/builds/42490584) Coverage increased (+0.002%) to 54.227% when pulling **f225c

[GitHub] [rocketmq] codecov-commenter commented on pull request #3300: Removing redundant configurations

2021-08-29 Thread GitBox
codecov-commenter commented on pull request #3300: URL: https://github.com/apache/rocketmq/pull/3300#issuecomment-907794414 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3300?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Th

[GitHub] [rocketmq] lwclover commented on pull request #3295: production level pull api demo

2021-08-29 Thread GitBox
lwclover commented on pull request #3295: URL: https://github.com/apache/rocketmq/pull/3295#issuecomment-907928500 > It would be better if you can submit an issue related with this PR first. next time, I will. haha -- This is an automated message from the Apache Git Service. To res

[GitHub] [rocketmq] SpriderMan opened a new issue #3301: indexFile need to flush?

2021-08-29 Thread GitBox
SpriderMan opened a new issue #3301: URL: https://github.com/apache/rocketmq/issues/3301 ![image](https://user-images.githubusercontent.com/18304842/131272914-2cdf76e8-8df5-4799-a867-4f151bdfe4d0.png) commitlog文件有flush到磁盘的操作,indexfile需要吗? -- This is an automated message from the A

[GitHub] [rocketmq-operator] caigy opened a new pull request #82: [ISSUE-80] Skipping generating data replication command when remote command returns error

2021-08-29 Thread GitBox
caigy opened a new pull request #82: URL: https://github.com/apache/rocketmq-operator/pull/82 Try to fix #80 : 1. Return error in `broker_controller.exec()` if remote command is failed. 2. Check if `broker_controller.exec()` returns error. If so, operator would NOT generating com

[GitHub] [rocketmq-externals] ltamber commented on a change in pull request #800: Rocketmq connector sink for hudi

2021-08-29 Thread GitBox
ltamber commented on a change in pull request #800: URL: https://github.com/apache/rocketmq-externals/pull/800#discussion_r698116971 ## File path: rocketmq-connect-hudi/src/main/java/org/apache/rocketmq/connect/hudi/config/CloneUtils.java ## @@ -0,0 +1,40 @@ +/* + * Licensed t

[GitHub] [rocketmq-externals] ltamber commented on a change in pull request #800: Rocketmq connector sink for hudi

2021-08-29 Thread GitBox
ltamber commented on a change in pull request #800: URL: https://github.com/apache/rocketmq-externals/pull/800#discussion_r698117521 ## File path: rocketmq-connect-hudi/src/main/java/org/apache/rocketmq/connect/hudi/connector/HudiSinkConnector.java ## @@ -0,0 +1,232 @@ + +/* +

[GitHub] [rocketmq] ltamber commented on a change in pull request #3224: [ISSUE #3223]Optimize startup script to support greater jdk version

2021-08-29 Thread GitBox
ltamber commented on a change in pull request #3224: URL: https://github.com/apache/rocketmq/pull/3224#discussion_r698119097 ## File path: acl/pom.xml ## @@ -13,7 +13,7 @@ org.apache.rocketmq rocketmq-all -4.9.1-SNAPSHOT +4.9.2-SNAPSHOT

[GitHub] [rocketmq] Git-Yang opened a new pull request #3302: [ISSUE] Add get stats and single queue stats for schedule topic

2021-08-29 Thread GitBox
Git-Yang opened a new pull request #3302: URL: https://github.com/apache/rocketmq/pull/3302 ## What is the purpose of the change #3296 ## Brief changelog - Add delivery TPS of SCHEDULE_TOPIC_ - Add delivery TPS for each queue of SCHEDULE_TOPIC_ - Add the w

[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #3224: [ISSUE #3223]Optimize startup script to support greater jdk version

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #3224: URL: https://github.com/apache/rocketmq/pull/3224#issuecomment-893982717 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3224?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

[ANNOUNCE] New committer involved, welcome Xiaofeng Jiang

2021-08-29 Thread heng du
Hi, The Project Management Committee (PMC) for Apache RocketMQ has invited Xiaofeng Jiang to become a committer and we are pleased to announce that he has accepted. Being a committer enables easier contribution to the project since there is no need to go via the patch submission process. This sho

[ANNOUNCE] New committer involved, welcome Jidi Zhang

2021-08-29 Thread heng du
Hi, The Project Management Committee (PMC) for Apache RocketMQ has invited Jidi Zhang to become a committer and we are pleased to announce that he has accepted. Being a committer enables easier contribution to the project since there is no need to go via the patch submission process. This should

[GitHub] [rocketmq] codecov-commenter commented on pull request #3302: [ISSUE] Add get stats and single queue stats for schedule topic

2021-08-29 Thread GitBox
codecov-commenter commented on pull request #3302: URL: https://github.com/apache/rocketmq/pull/3302#issuecomment-907974326 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3302?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Th

Re: [ANNOUNCE] New committer involved, welcome Jidi Zhang

2021-08-29 Thread Amber Liu
Congrats. heng du 于2021年8月30日周一 上午10:58写道: > Hi, > > The Project Management Committee (PMC) for Apache RocketMQ has invited > Jidi Zhang to become a committer and we are pleased to announce that he has > accepted. > > Being a committer enables easier contribution to the project since there is >

Re: [ANNOUNCE] New committer involved, welcome Xiaofeng Jiang

2021-08-29 Thread Amber Liu
Congrats. heng du 于2021年8月30日周一 上午10:57写道: > Hi, > > The Project Management Committee (PMC) for Apache RocketMQ has invited > Xiaofeng Jiang to become a committer and we are pleased > to announce that he has accepted. > > Being a committer enables easier contribution to the project since there i

Re: [ANNOUNCE] New committer involved, welcome Jidi Zhang

2021-08-29 Thread Yufei Zhang
Congrats! On Sun, Aug 29, 2021 at 8:07 PM Amber Liu wrote: > Congrats. > > heng du 于2021年8月30日周一 上午10:58写道: > > > Hi, > > > > The Project Management Committee (PMC) for Apache RocketMQ has invited > > Jidi Zhang to become a committer and we are pleased to announce that he > has > > accepted. >

[GitHub] [rocketmq-client-go] maqingxiang commented on pull request #720: (fix): set subversion when buildSubscriptionData

2021-08-29 Thread GitBox
maqingxiang commented on pull request #720: URL: https://github.com/apache/rocketmq-client-go/pull/720#issuecomment-907981481 > @superhx which version of your client and rmq server? Could you pls submit a issue to describe it https://github.com/apache/rocketmq-client-go/issues/718

Re:[ANNOUNCE] New committer involved, welcome Jidi Zhang

2021-08-29 Thread caigy
Congrats! At 2021-08-30 10:58:37, "heng du" wrote: >Hi, > >The Project Management Committee (PMC) for Apache RocketMQ has invited >Jidi Zhang to become a committer and we are pleased to announce that he has >accepted. > >Being a committer enables easier contribution to the project since there is

Re:[ANNOUNCE] New committer involved, welcome Xiaofeng Jiang

2021-08-29 Thread caigy
Congrats! At 2021-08-30 10:57:08, "heng du" wrote: >Hi, > >The Project Management Committee (PMC) for Apache RocketMQ has invited >Xiaofeng Jiang to become a committer and we are pleased >to announce that he has accepted. > >Being a committer enables easier contribution to the project since ther

[GitHub] [rocketmq-client-go] maqingxiang commented on issue #718: [bug] The Subscribe() interface not in effect with consumer.MessageSelector{}

2021-08-29 Thread GitBox
maqingxiang commented on issue #718: URL: https://github.com/apache/rocketmq-client-go/issues/718#issuecomment-907982521 https://github.com/apache/rocketmq-client-go/pull/720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

回复: [ANNOUNCE] New committer involved, welcome Jidi Zhang

2021-08-29 Thread Hu Zongtang
Congrats. 发件人: Amber Liu 发送时间: 2021年8月30日 11:07 收件人: dev@rocketmq.apache.org 主题: Re: [ANNOUNCE] New committer involved, welcome Jidi Zhang Congrats. heng du 于2021年8月30日周一 上午10:58写道: > Hi, > > The Project Management Committee (PMC) for Apache RocketMQ has invi

回复: [ANNOUNCE] New committer involved, welcome Xiaofeng Jiang

2021-08-29 Thread Hu Zongtang
Congrats. 发件人: heng du 发送时间: 2021年8月30日 10:57 收件人: dev 抄送: 蒋晓峰 主题: [ANNOUNCE] New committer involved, welcome Xiaofeng Jiang Hi, The Project Management Committee (PMC) for Apache RocketMQ has invited Xiaofeng Jiang to become a committer and we are pleased to a

[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #3302: [ISSUE] Add get stats and single queue stats for schedule topic

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #3302: URL: https://github.com/apache/rocketmq/pull/3302#issuecomment-907974326 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3302?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

[GitHub] [rocketmq-client-go] ShannonDing commented on issue #718: [bug] The Subscribe() interface not in effect with consumer.MessageSelector{}

2021-08-29 Thread GitBox
ShannonDing commented on issue #718: URL: https://github.com/apache/rocketmq-client-go/issues/718#issuecomment-907986786 see #720, set subversion when buildSubscriptionData -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [rocketmq-client-go] ShannonDing merged pull request #720: (fix): set subversion when buildSubscriptionData

2021-08-29 Thread GitBox
ShannonDing merged pull request #720: URL: https://github.com/apache/rocketmq-client-go/pull/720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: d

[GitHub] [rocketmq-client-go] ShannonDing closed issue #718: [bug] The Subscribe() interface not in effect with consumer.MessageSelector{}

2021-08-29 Thread GitBox
ShannonDing closed issue #718: URL: https://github.com/apache/rocketmq-client-go/issues/718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

Re: [ANNOUNCE] New committer involved, welcome Xiaofeng Jiang

2021-08-29 Thread 蒋晓峰
Thanks to the Apache RocketMQ community. I would like to keep contributing to the RocketMQ streams and Flink module. Best Regards, Nicholas Jiang On Mon, Aug 30, 2021 at 11:28 AM Hu Zongtang wrote: > Congrats. > > -- > *发件人:* heng du > *发送时间:* 2021年8月30日 10:57 > *收

[GitHub] [rocketmq-operator] caigy commented on issue #74: Add nodeAffinity for nameService pod

2021-08-29 Thread GitBox
caigy commented on issue #74: URL: https://github.com/apache/rocketmq-operator/issues/74#issuecomment-908029411 Is it duplicated with #38 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [rocketmq-site] SteNicholas opened a new pull request #96: Add new committer nicholasjiang

2021-08-29 Thread GitBox
SteNicholas opened a new pull request #96: URL: https://github.com/apache/rocketmq-site/pull/96 ## What is the purpose of the change Add new committer nicholasjiang to the `team.md`. ## Brief changelog Add new committer nicholasjiang to the `team.md`. ## Verifying

[GitHub] [rocketmq-externals] odbozhou commented on a change in pull request #800: Rocketmq connector sink for hudi

2021-08-29 Thread GitBox
odbozhou commented on a change in pull request #800: URL: https://github.com/apache/rocketmq-externals/pull/800#discussion_r698207363 ## File path: rocketmq-connect-hudi/src/main/java/org/apache/rocketmq/connect/hudi/config/CloneUtils.java ## @@ -0,0 +1,40 @@ +/* + * Licensed

[GitHub] [rocketmq-externals] odbozhou commented on pull request #800: Rocketmq connector sink for hudi

2021-08-29 Thread GitBox
odbozhou commented on pull request #800: URL: https://github.com/apache/rocketmq-externals/pull/800#issuecomment-908075911 Submit an issue, this pr is associated with this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu