[GitHub] [rocketmq] MatrixHB commented on issue #4425: how do i solve "broker busy"

2022-06-14 Thread GitBox
MatrixHB commented on issue #4425: URL: https://github.com/apache/rocketmq/issues/4425#issuecomment-1156050222 Or, you can increase the waiting time limit in send request queue. `sh mqadmin updateBrokerConfig -b {brokerIP:port} -k waitTimeMillsInSendQueue -v 3000` -- This is an aut

[GitHub] [rocketmq] tianliuliu commented on pull request #4441: [ISSUE #4421] Optimized some code style.

2022-06-14 Thread GitBox
tianliuliu commented on PR #4441: URL: https://github.com/apache/rocketmq/pull/4441#issuecomment-1156039501 ![image](https://user-images.githubusercontent.com/13758677/173757011-720d9ba4-2acf-406f-94a4-61166b28002b.png) It is better to describe like what problem was solved, what was done

[GitHub] [rocketmq] tsunghanjacktsai commented on a diff in pull request #4218: delete useless code

2022-06-14 Thread GitBox
tsunghanjacktsai commented on code in PR #4218: URL: https://github.com/apache/rocketmq/pull/4218#discussion_r897573080 ## broker/src/main/java/org/apache/rocketmq/broker/processor/PullMessageProcessor.java: ## @@ -246,12 +246,6 @@ private RemotingCommand processRequest(final Ch

[GitHub] [rocketmq] MatrixHB commented on pull request #4439: [ISSUE #4435] Code optimization for ConsumeQueue abstraction.

2022-06-14 Thread GitBox
MatrixHB commented on PR #4439: URL: https://github.com/apache/rocketmq/pull/4439#issuecomment-1156025177 Related to [https://github.com/apache/rocketmq/issues/4435]( ISSUE #4435) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [rocketmq] liuzongliang0202 opened a new issue, #4463: indexFile flush question

2022-06-14 Thread GitBox
liuzongliang0202 opened a new issue, #4463: URL: https://github.com/apache/rocketmq/issues/4463 Only when the rocketmq indexfile is full can the disk be flushed. If the indexfile is not full, may the data in the indexfile be lost after normal exit? For example, after rocketmq exits normally

[GitHub] [rocketmq] MatrixHB commented on issue #4451: Question about this.lock(mq) in updateProcessQueueTableInRebalance method

2022-06-14 Thread GitBox
MatrixHB commented on issue #4451: URL: https://github.com/apache/rocketmq/issues/4451#issuecomment-1155951974 When executing `if (isOrder && !this.lock(mq))`, the main purpose is to lock the messageQueue in the server-side, `processQueue.setLocked(true);` is secondary. ![image](https:/

[GitHub] [rocketmq] RongtongJin commented on pull request #4460: Update the logic of confirmOffset and recover topicQueueTable to prevent message loss when broker role change

2022-06-14 Thread GitBox
RongtongJin commented on PR #4460: URL: https://github.com/apache/rocketmq/pull/4460#issuecomment-1155943359 > Precise changes. Meanwhile, just a reminder, I found that the quality of some comments on this branch needs to be improved. We should make them more formal and understandable in th

[GitHub] [rocketmq-client-cpp] ShannonDing commented on issue #293: consumer stuck in rebalance and doesn't consume messsages

2022-06-14 Thread GitBox
ShannonDing commented on issue #293: URL: https://github.com/apache/rocketmq-client-cpp/issues/293#issuecomment-1155927539 see #300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [rocketmq-client-cpp] ShannonDing closed issue #293: consumer stuck in rebalance and doesn't consume messsages

2022-06-14 Thread GitBox
ShannonDing closed issue #293: consumer stuck in rebalance and doesn't consume messsages URL: https://github.com/apache/rocketmq-client-cpp/issues/293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [rocketmq-client-cpp] Jerlensu commented on issue #293: consumer stuck in rebalance and doesn't consume messsages

2022-06-14 Thread GitBox
Jerlensu commented on issue #293: URL: https://github.com/apache/rocketmq-client-cpp/issues/293#issuecomment-1155924105 请问这个问题解决了吗 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [ANNOUNCE]New Committers of Apache RocketMQ: Lin Shen(shenlin) and Yangkun Ai(aaronai)

2022-06-14 Thread heng du
Congrats yukon 于2022年6月15日周三 10:10写道: > Hi Apache RocketMQ Community, > > The Project Management Committee (PMC) for Apache RocketMQ has invited Lin > Shen (apache id: shenlin, github id: 2011shenlin) and Yangkun Ai (apache > id: aaronai, github id: aaron-ai) to become committers, and we are ple

[ANNOUNCE]New Committers of Apache RocketMQ: Lin Shen(shenlin) and Yangkun Ai(aaronai)

2022-06-14 Thread yukon
Hi Apache RocketMQ Community, The Project Management Committee (PMC) for Apache RocketMQ has invited Lin Shen (apache id: shenlin, github id: 2011shenlin) and Yangkun Ai (apache id: aaronai, github id: aaron-ai) to become committers, and we are pleased to announce that they have accepted. Congrat

[GitHub] [rocketmq-client-go] ShannonDing merged pull request #841: [ISSUE #823]fix: panic problem caused by json-iterator in go1.18

2022-06-14 Thread GitBox
ShannonDing merged PR #841: URL: https://github.com/apache/rocketmq-client-go/pull/841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@r

[GitHub] [rocketmq-client-go] ShannonDing closed issue #823: go1.18 consumer failed to start

2022-06-14 Thread GitBox
ShannonDing closed issue #823: go1.18 consumer failed to start URL: https://github.com/apache/rocketmq-client-go/issues/823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [rocketmq] hzh0425 commented on issue #4461: can‘t change the logger level dynamicly

2022-06-14 Thread GitBox
hzh0425 commented on issue #4461: URL: https://github.com/apache/rocketmq/issues/4461#issuecomment-1155890471 > IMO, after changing system properties, it's needed to restart process to take effect. yes it is inconvenient -- This is an automated message from the Apache Git Service.

[GitHub] [rocketmq] lizhiboo commented on issue #4461: can‘t change the logger level dynamicly

2022-06-14 Thread GitBox
lizhiboo commented on issue #4461: URL: https://github.com/apache/rocketmq/issues/4461#issuecomment-1155861314 IMO, after changing system properties, it's needed to restart process to take effect. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [rocketmq] mahaitao617 opened a new issue, #4462: where is the isOrderTopic used?

2022-06-14 Thread GitBox
mahaitao617 opened a new issue, #4462: URL: https://github.com/apache/rocketmq/issues/4462 public class TopicPublishInfo { private boolean orderTopic = false; private boolean haveTopicRouterInfo = false; private List messageQueueList = new ArrayList(); private

[GitHub] [rocketmq] hzh0425 commented on pull request #4424: [Summer of code] Let controller inform broker that role changed.

2022-06-14 Thread GitBox
hzh0425 commented on PR #4424: URL: https://github.com/apache/rocketmq/pull/4424#issuecomment-1155211679 问题场景: RoleChange (Controller 选出新的 Leader) 时, Broker 是通过定时任务来 Sync controller 得元数据, 也即会有一个时间间隔. 我们希望减少这个时间间隔, 所以当选出新的 Leader 后, 让 Controller 立即通知相应得 Broker. -- This is an automated mess

[GitHub] [rocketmq] hzh0425 commented on pull request #4460: Update the logic of confirmOffset and recover topicQueueTable to prevent message loss when broker role change

2022-06-14 Thread GitBox
hzh0425 commented on PR #4460: URL: https://github.com/apache/rocketmq/pull/4460#issuecomment-1155188478 Still have some problems that waiting to found~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [rocketmq] hzh0425 commented on issue #4445: Confusion about CN documents(design)

2022-06-14 Thread GitBox
hzh0425 commented on issue #4445: URL: https://github.com/apache/rocketmq/issues/4445#issuecomment-1155184135 感谢建议 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [rocketmq-connect] sunxiaojian opened a new pull request, #158: [ISSUE #155] Optimize the record converter parser

2022-06-14 Thread GitBox
sunxiaojian opened a new pull request, #158: URL: https://github.com/apache/rocketmq-connect/pull/158 ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your cont

[GitHub] [rocketmq] fulln opened a new issue, #4461: can‘t change the logger level dynamicly

2022-06-14 Thread GitBox
fulln opened a new issue, #4461: URL: https://github.com/apache/rocketmq/issues/4461 need to change the log level dynamicly, we can changed by system properties -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [rocketmq-apis] lizhanhui merged pull request #33: [ISSUE #32] add check_message_type to publishing setting.

2022-06-14 Thread GitBox
lizhanhui merged PR #33: URL: https://github.com/apache/rocketmq-apis/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.a

[GitHub] [rocketmq-client-go] ShannonDing closed issue #832: Client may submit wrong offset when network instability

2022-06-14 Thread GitBox
ShannonDing closed issue #832: Client may submit wrong offset when network instability URL: https://github.com/apache/rocketmq-client-go/issues/832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [rocketmq-client-go] ShannonDing merged pull request #833: [ISSUE #832] Client may submit wrong offset when network instability

2022-06-14 Thread GitBox
ShannonDing merged PR #833: URL: https://github.com/apache/rocketmq-client-go/pull/833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@r

[GitHub] [rocketmq] yuz10 merged pull request #4038: [ISSUE #4037] Add DeleteExpiredCommitLogSubCommand

2022-06-14 Thread GitBox
yuz10 merged PR #4038: URL: https://github.com/apache/rocketmq/pull/4038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache

[GitHub] [rocketmq] yuz10 closed issue #4037: Admin command to delete expired CommitLog

2022-06-14 Thread GitBox
yuz10 closed issue #4037: Admin command to delete expired CommitLog URL: https://github.com/apache/rocketmq/issues/4037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [rocketmq] coveralls commented on pull request #4460: Update the logic of confirmOffset and recover topicQueueTable to prevent message loss when broker role change

2022-06-14 Thread GitBox
coveralls commented on PR #4460: URL: https://github.com/apache/rocketmq/pull/4460#issuecomment-1154910694 [![Coverage Status](https://coveralls.io/builds/4638/badge)](https://coveralls.io/builds/4638) Coverage increased (+0.02%) to 47.477% when pulling **41ea3e67d6f648ad

[GitHub] [rocketmq-exporter] framctr opened a new issue, #105: Prometheus comments

2022-06-14 Thread GitBox
framctr opened a new issue, #105: URL: https://github.com/apache/rocketmq-exporter/issues/105 RocketMQ exporter does not show metrics comments and some metrics are not intuitive to understand. For example, what `rocketmq_brokeruntime_pmdt_0ms` stands for? **To Reproduce** St

[GitHub] [rocketmq-exporter] waney316 commented on issue #104: can't find rocketmq-exporter in hub.docker.com?

2022-06-14 Thread GitBox
waney316 commented on issue #104: URL: https://github.com/apache/rocketmq-exporter/issues/104#issuecomment-1154898971 you can clone this project and build to docker image -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [rocketmq] codecov-commenter commented on pull request #4460: Update the logic of confirmOffset and recover topicQueueTable to prevent message loss when broker role change

2022-06-14 Thread GitBox
codecov-commenter commented on PR #4460: URL: https://github.com/apache/rocketmq/pull/4460#issuecomment-1154897812 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4460?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [rocketmq] dongeforever commented on pull request #4383: [ISSUE #4382]Namesrv nearby route

2022-06-14 Thread GitBox
dongeforever commented on PR #4383: URL: https://github.com/apache/rocketmq/pull/4383#issuecomment-1154883293 @lwclover I have read all the code. This solution is simple and useful in some cases. And the same time, there are two potential problems. Firstly, in the public cloud

[GitHub] [rocketmq-eventbridge] 2011shenlin merged pull request #22: Add comments and delete redundant folders

2022-06-14 Thread GitBox
2011shenlin merged PR #22: URL: https://github.com/apache/rocketmq-eventbridge/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@r

[GitHub] [rocketmq-spring] xixingzhe opened a new issue, #464: namespace报错

2022-06-14 Thread GitBox
xixingzhe opened a new issue, #464: URL: https://github.com/apache/rocketmq-spring/issues/464 代码配置 `@RocketMQMessageListener(topic = "${mq.topic.test-topic}", consumerGroup = "${mq.topic.test-topic-consumer-group}", namespace = "${rocketmq.consumer.namespace}")` 报错: `[ERROR] 2022-0

[GitHub] [rocketmq-spring] xixingzhe closed issue #463: namespace报错

2022-06-14 Thread GitBox
xixingzhe closed issue #463: namespace报错 URL: https://github.com/apache/rocketmq-spring/issues/463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-u

[GitHub] [rocketmq-spring] xixingzhe opened a new issue, #463: namespace报错

2022-06-14 Thread GitBox
xixingzhe opened a new issue, #463: URL: https://github.com/apache/rocketmq-spring/issues/463 代码配置 `@RocketMQMessageListener(topic = "${mq.topic.test-topic}", consumerGroup = "${mq.topic.test-topic-consumer-group}", namespace = "${rocketmq.consumer.namespace}")` 报错: `[ERROR] 2022-0

[GitHub] [rocketmq] RongtongJin opened a new pull request, #4460: Update the logic of confirmOffset and recover topicQueueTable to prevent message loss

2022-06-14 Thread GitBox
RongtongJin opened a new pull request, #4460: URL: https://github.com/apache/rocketmq/pull/4460 ## What is the purpose of the change Controller模式在网络分区场景下,confirmOffset的更新,cq的构建,数据的节点要相互配合,否则会丢死后 ## Brief changelog Update the logic of confirmOffset and recover topicQueueTa

[GitHub] [rocketmq] zhouxinyu merged pull request #4459: Change PullMessageRequestHeader maxMsgNums to CFNullable

2022-06-14 Thread GitBox
zhouxinyu merged PR #4459: URL: https://github.com/apache/rocketmq/pull/4459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.ap

[GitHub] [rocketmq] zhouxinyu commented on pull request #4459: Change PullMessageRequestHeader maxMsgNums to CFNullable

2022-06-14 Thread GitBox
zhouxinyu commented on PR #4459: URL: https://github.com/apache/rocketmq/pull/4459#issuecomment-1154812196 LGTM~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr