[GitHub] [rocketmq] yanghaifeng5461 closed issue #4872: BROADCASTING mode in windows, create rocketmq_offsets file failed

2022-08-25 Thread GitBox
yanghaifeng5461 closed issue #4872: BROADCASTING mode in windows, create rocketmq_offsets file failed URL: https://github.com/apache/rocketmq/issues/4872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [rocketmq] yanghaifeng5461 commented on issue #4872: BROADCASTING mode in windows, create rocketmq_offsets file failed

2022-08-25 Thread GitBox
yanghaifeng5461 commented on issue #4872: URL: https://github.com/apache/rocketmq/issues/4872#issuecomment-1226867596 thank u -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [rocketmq-clients] codecov-commenter commented on pull request #184: Remove redundant sleep in ut

2022-08-25 Thread GitBox
codecov-commenter commented on PR #184: URL: https://github.com/apache/rocketmq-clients/pull/184#issuecomment-1226869176 # [Codecov](https://codecov.io/gh/apache/rocketmq-clients/pull/184?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term

[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #906: when queue dropped,should'not consume the process queue.(#905)

2022-08-25 Thread GitBox
codecov-commenter commented on PR #906: URL: https://github.com/apache/rocketmq-client-go/pull/906#issuecomment-1226874393 # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/906?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm

[GitHub] [rocketmq-clients] aaron-ai merged pull request #184: Remove redundant sleep in ut

2022-08-25 Thread GitBox
aaron-ai merged PR #184: URL: https://github.com/apache/rocketmq-clients/pull/184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocket

[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #908: fix:wrong stats log (#907)

2022-08-25 Thread GitBox
codecov-commenter commented on PR #908: URL: https://github.com/apache/rocketmq-client-go/pull/908#issuecomment-1226880965 # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/908?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm

[GitHub] [rocketmq-streams] ni-ze merged pull request #197: support join sql in rsqldb

2022-08-25 Thread GitBox
ni-ze merged PR #197: URL: https://github.com/apache/rocketmq-streams/pull/197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.

[GitHub] [rocketmq-connect] odbozhou commented on a diff in pull request #259: [ISSUE #255]Standardize configuration and update documentation

2022-08-25 Thread GitBox
odbozhou commented on code in PR #259: URL: https://github.com/apache/rocketmq-connect/pull/259#discussion_r954651555 ## rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/connectorwrapper/WorkerConnector.java: ## @@ -263,6 +264,10 @@ void doShutdown() {

[GitHub] [rocketmq-connect] odbozhou merged pull request #259: [ISSUE #255]Standardize configuration and update documentation

2022-08-25 Thread GitBox
odbozhou merged PR #259: URL: https://github.com/apache/rocketmq-connect/pull/259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocket

[GitHub] [rocketmq-connect] odbozhou merged pull request #281: [ISSUE #202]Debezium MySQL Source Connector datatime type column transform problem

2022-08-25 Thread GitBox
odbozhou merged PR #281: URL: https://github.com/apache/rocketmq-connect/pull/281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocket

[GitHub] [rocketmq] mxsm opened a new issue, #4889: Fix controller test:DLedgerControllerTest#testChangeControllerLeader

2022-08-25 Thread GitBox
mxsm opened a new issue, #4889: URL: https://github.com/apache/rocketmq/issues/4889 ![image](https://user-images.githubusercontent.com/15797831/186617602-e36cb7cd-2e55-41a2-8533-c622d28416c1.png) -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [rocketmq] lizhanhui opened a new issue, #4890: Binary binary search consume queue offset by timestamp

2022-08-25 Thread GitBox
lizhanhui opened a new issue, #4890: URL: https://github.com/apache/rocketmq/issues/4890 There are use cases, where we need to pinpoint offset in consume queue by the given timestamp—for example, count the number of messages for a given message queue in the given time range. Current

[GitHub] [rocketmq] lizhanhui opened a new pull request, #4891: [ISSUE 4890] BugFix: fix binary search consume offset by time

2022-08-25 Thread GitBox
lizhanhui opened a new pull request, #4891: URL: https://github.com/apache/rocketmq/pull/4891 **Make sure set the target branch to `develop`** ## What is the purpose of the change Fix https://github.com/apache/rocketmq/issues/4890 ## Brief changelog XX ## Ve

[GitHub] [rocketmq-clients] codecov-commenter commented on pull request #185: Reveal client index in each thread

2022-08-25 Thread GitBox
codecov-commenter commented on PR #185: URL: https://github.com/apache/rocketmq-clients/pull/185#issuecomment-1227055803 # [Codecov](https://codecov.io/gh/apache/rocketmq-clients/pull/185?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term

[GitHub] [rocketmq-clients] aaron-ai merged pull request #185: Reveal client index in each thread

2022-08-25 Thread GitBox
aaron-ai merged PR #185: URL: https://github.com/apache/rocketmq-clients/pull/185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocket

[GitHub] [rocketmq-streams] ni-ze closed issue #80: Pull Consumer integration

2022-08-25 Thread GitBox
ni-ze closed issue #80: Pull Consumer integration URL: https://github.com/apache/rocketmq-streams/issues/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [rocketmq-streams] ni-ze closed issue #149: There is no log output when rocketmq-streams running.

2022-08-25 Thread GitBox
ni-ze closed issue #149: There is no log output when rocketmq-streams running. URL: https://github.com/apache/rocketmq-streams/issues/149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [rocketmq-streams] ni-ze merged pull request #198: fix(left join) fix left join

2022-08-25 Thread GitBox
ni-ze merged PR #198: URL: https://github.com/apache/rocketmq-streams/pull/198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.

[GitHub] [rocketmq-streams] ni-ze closed issue #109: BatchSize is not settable from JoinWindow

2022-08-25 Thread GitBox
ni-ze closed issue #109: BatchSize is not settable from JoinWindow URL: https://github.com/apache/rocketmq-streams/issues/109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [rocketmq] zzw19990414 commented on issue #639: what's used for about unitMode of clientConfig?

2022-08-25 Thread GitBox
zzw19990414 commented on issue #639: URL: https://github.com/apache/rocketmq/issues/639#issuecomment-1227202264 亲,广播模式本地存储报错了,怎么设置自己的路径? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [rocketmq] mxsm opened a new pull request, #4892: [ISSUE #4889]Fix controller test:DLedgerControllerTest#testChangeControllerLeader

2022-08-25 Thread GitBox
mxsm opened a new pull request, #4892: URL: https://github.com/apache/rocketmq/pull/4892 **Make sure set the target branch to `develop`** ## What is the purpose of the change Fix #4889 ## Brief changelog -Fix controller test:DLedgerControllerTest#testChangeControl

[GitHub] [rocketmq-client-cpp] SRC-xiaojin commented on a diff in pull request #441: reduce unnecessary tmp copy

2022-08-25 Thread GitBox
SRC-xiaojin commented on code in PR #441: URL: https://github.com/apache/rocketmq-client-cpp/pull/441#discussion_r955050401 ## src/protocol/RemotingCommand.cpp: ## @@ -302,6 +302,10 @@ void RemotingCommand::setMsgBody(const string& body) { m_msgBody = body; } +void Remoti

[GitHub] [rocketmq] a-tony opened a new issue, #4893: nameserver启动后就挂了

2022-08-25 Thread GitBox
a-tony opened a new issue, #4893: URL: https://github.com/apache/rocketmq/issues/4893 ![QQ截图20220826085447](https://user-images.githubusercontent.com/30425455/186793788-34f4f274-4b40-44a5-a99a-4763535097f3.png) -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [rocketmq] RongtongJin merged pull request #4892: [ISSUE #4889]Fix controller test:DLedgerControllerTest#testChangeControllerLeader

2022-08-25 Thread GitBox
RongtongJin merged PR #4892: URL: https://github.com/apache/rocketmq/pull/4892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.

[GitHub] [rocketmq] RongtongJin closed issue #4889: Fix controller test:DLedgerControllerTest#testChangeControllerLeader

2022-08-25 Thread GitBox
RongtongJin closed issue #4889: Fix controller test:DLedgerControllerTest#testChangeControllerLeader URL: https://github.com/apache/rocketmq/issues/4889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [rocketmq] RongtongJin commented on issue #4893: The nameserver process failed after start

2022-08-25 Thread GitBox
RongtongJin commented on issue #4893: URL: https://github.com/apache/rocketmq/issues/4893#issuecomment-1227906927 Could you provide the version you used? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [rocketmq] a-tony commented on issue #4893: The nameserver process failed after start

2022-08-25 Thread GitBox
a-tony commented on issue #4893: URL: https://github.com/apache/rocketmq/issues/4893#issuecomment-1227907597 mqnamesrv mqbroker -n 10.36.219.169:9876 然后就没然后了,运行一段时间就宕机 -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [rocketmq] duhenglucky commented on issue #4893: The nameserver process failed after start

2022-08-25 Thread GitBox
duhenglucky commented on issue #4893: URL: https://github.com/apache/rocketmq/issues/4893#issuecomment-1227919727 > 是不是因为没有后台运行导致的,可以试下用下面的命令运行: nohup sh bin/mqnamesrv & nohup sh bin/mqbroker -n localhost:9876 & -- This is an automated message from the Apache Git Service. To

[GitHub] [rocketmq] duhenglucky closed issue #4893: The nameserver process failed after start

2022-08-25 Thread GitBox
duhenglucky closed issue #4893: The nameserver process failed after start URL: https://github.com/apache/rocketmq/issues/4893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[ANNOUNCE] New PMC member for Apache RocketMQ: Qingshan Lin

2022-08-25 Thread heng du
Hi Apache RocketMQ Community, The Project Management Committee (PMC) for Apache RocketMQ has invited Qingshan Lin[1][2] (apache id: linhill) to become PMC Member and we are pleased to announce that he has accepted. In RocketMQ 5.0, Qingshan innovatively proposed a new POP consumption model in RI

[GitHub] [rocketmq] duhenglucky closed issue #4858: Add consumer type check when call consumeMessageDirectly

2022-08-25 Thread GitBox
duhenglucky closed issue #4858: Add consumer type check when call consumeMessageDirectly URL: https://github.com/apache/rocketmq/issues/4858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [rocketmq-mqtt] pingww closed issue #137: cluster mode

2022-08-25 Thread GitBox
pingww closed issue #137: cluster mode URL: https://github.com/apache/rocketmq-mqtt/issues/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

[GitHub] [rocketmq-mqtt] pingww closed issue #111: mqtt demo consume error

2022-08-25 Thread GitBox
pingww closed issue #111: mqtt demo consume error URL: https://github.com/apache/rocketmq-mqtt/issues/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [rocketmq-mqtt] DongyuanPan commented on a diff in pull request #131: [ISSUE #70] Retained message based on raft state machine

2022-08-25 Thread GitBox
DongyuanPan commented on code in PR #131: URL: https://github.com/apache/rocketmq-mqtt/pull/131#discussion_r955588313 ## mqtt-common/src/main/proto/storeMessage.proto: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [rocketmq] zhouxinyu commented on a diff in pull request #4780: [ISSUE #4778] Design of optimize log transfer protocol

2022-08-25 Thread GitBox
zhouxinyu commented on code in PR #4780: URL: https://github.com/apache/rocketmq/pull/4780#discussion_r955596560 ## store/src/main/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHAClient.java: ## @@ -237,112 +207,177 @@ public long getTransferredByteInSecond() { @Ov

[GitHub] [rocketmq] innerpeacez commented on issue #1406: create helm chart for rocketmq

2022-08-25 Thread GitBox
innerpeacez commented on issue #1406: URL: https://github.com/apache/rocketmq/issues/1406#issuecomment-1228006720 I've done the rocketmq helm chart writing, but I'm now wondering which repo I should commit to? @wonderflow -- This is an automated message from the Apache Git Service. To res

[GitHub] [rocketmq-mqtt] pingww opened a new pull request, #139: removed meta kv which will be possible to implement directly using a …

2022-08-25 Thread GitBox
pingww opened a new pull request, #139: URL: https://github.com/apache/rocketmq-mqtt/pull/139 removed meta kv which will be possible to implement directly using a raft state machine -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [rocketmq-mqtt] pingww merged pull request #139: removed meta kv which will be possible to implement directly using a …

2022-08-25 Thread GitBox
pingww merged PR #139: URL: https://github.com/apache/rocketmq-mqtt/pull/139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.ap

[GitHub] [rocketmq-mqtt] dependabot[bot] commented on pull request #112: Bump protobuf-java from 3.5.1 to 3.16.1 in /meta

2022-08-25 Thread GitBox
dependabot[bot] commented on PR #112: URL: https://github.com/apache/rocketmq-mqtt/pull/112#issuecomment-1228043810 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.

[GitHub] [rocketmq-mqtt] dependabot[bot] commented on pull request #113: Bump commons-io from 2.4 to 2.7 in /meta

2022-08-25 Thread GitBox
dependabot[bot] commented on PR #113: URL: https://github.com/apache/rocketmq-mqtt/pull/113#issuecomment-1228043828 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.

[GitHub] [rocketmq-mqtt] pingww opened a new pull request, #140: fix #88

2022-08-25 Thread GitBox
pingww opened a new pull request, #140: URL: https://github.com/apache/rocketmq-mqtt/pull/140 fix #88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [rocketmq-mqtt] pingww closed issue #88: Wrong future completed condition

2022-08-25 Thread GitBox
pingww closed issue #88: Wrong future completed condition URL: https://github.com/apache/rocketmq-mqtt/issues/88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [rocketmq-mqtt] codecov-commenter commented on pull request #140: fix #88

2022-08-25 Thread GitBox
codecov-commenter commented on PR #140: URL: https://github.com/apache/rocketmq-mqtt/pull/140#issuecomment-1228071235 # [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/140?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [rocketmq-mqtt] pingww merged pull request #140: fix #88

2022-08-25 Thread GitBox
pingww merged PR #140: URL: https://github.com/apache/rocketmq-mqtt/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.ap

[GitHub] [rocketmq] ShannonDing commented on issue #1406: create helm chart for rocketmq

2022-08-25 Thread GitBox
ShannonDing commented on issue #1406: URL: https://github.com/apache/rocketmq/issues/1406#issuecomment-1228082260 > Operator:https://github.com/apache/rocketmq-operator DockerImage:https://github.com/apache/rocketmq-docker -- This is an automated message from the Apache Git Service.

[GitHub] [rocketmq] aaron-ai commented on pull request #4881: send async,time calculation rules Multiple method patches

2022-08-25 Thread GitBox
aaron-ai commented on PR #4881: URL: https://github.com/apache/rocketmq/pull/4881#issuecomment-1228084405 Hi, think you for contributing! You may need to rebase the develop branch to pass the residual status check because we re-defined the mergeability recently. -- This is an autom

[GitHub] [rocketmq-mqtt] QiAnXinCodeSafe opened a new issue, #141: There is a vulnerability in Spring Framework 4.3.16.RELEASE ,upgrade recommended

2022-08-25 Thread GitBox
QiAnXinCodeSafe opened a new issue, #141: URL: https://github.com/apache/rocketmq-mqtt/issues/141 https://github.com/apache/rocketmq-mqtt/blob/0fb52d19159fe1e2cd053165714ff6d694d589e2/pom.xml#L25 CVE-2018-1270 CVE-2016-127 CVE-2022-22965 CVE-2018-11040 CVE-2018-15756 Recom

[GitHub] [rocketmq] RongtongJin opened a new issue, #4894: Fix NPE in CommandUtil

2022-08-25 Thread GitBox
RongtongJin opened a new issue, #4894: URL: https://github.com/apache/rocketmq/issues/4894 The issue tracker is used for bug reporting purposes **ONLY** whereas feature request needs to follow the [RIP process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal). To avoi

[GitHub] [rocketmq] RongtongJin opened a new pull request, #4895: [ISSUE #4894] Fix NPE in CommandUtil

2022-08-25 Thread GitBox
RongtongJin opened a new pull request, #4895: URL: https://github.com/apache/rocketmq/pull/4895 **Make sure set the target branch to `develop`** ## What is the purpose of the change Fix NPE in CommandUtil ## Brief changelog Fix NPE in CommandUtil ## Verifyin

[GitHub] [rocketmq-mqtt] QiAnXinCodeSafe opened a new issue, #142: There is a vulnerability in Netty Project 4.1.43.Final ,upgrade recommended

2022-08-25 Thread GitBox
QiAnXinCodeSafe opened a new issue, #142: URL: https://github.com/apache/rocketmq-mqtt/issues/142 https://github.com/apache/rocketmq-mqtt/blob/0fb52d19159fe1e2cd053165714ff6d694d589e2/pom.xml#L57-L61 CVE-2019-20444 CVE-2019-20445 CVE-2020-11612 CVE-2020-7238 CVE-2021-37136 Rec

[GitHub] [rocketmq-mqtt] QiAnXinCodeSafe opened a new issue, #143: There is a vulnerability in Simple Logging Facade for Java (SLF4J) 1.7.15,upgrade recommended

2022-08-25 Thread GitBox
QiAnXinCodeSafe opened a new issue, #143: URL: https://github.com/apache/rocketmq-mqtt/issues/143 https://github.com/apache/rocketmq-mqtt/blob/0fb52d19159fe1e2cd053165714ff6d694d589e2/pom.xml#L87-L91 CVE-2018-8088 Recommended upgrade version:1.7.26 -- This is an automate

[GitHub] [rocketmq-mqtt] QiAnXinCodeSafe opened a new issue, #144: There is a vulnerability in Guava: Google Core Libraries for Java 19.0,upgrade recommended

2022-08-25 Thread GitBox
QiAnXinCodeSafe opened a new issue, #144: URL: https://github.com/apache/rocketmq-mqtt/issues/144 https://github.com/apache/rocketmq-mqtt/blob/0fb52d19159fe1e2cd053165714ff6d694d589e2/pom.xml#L143-L147 CVE-2018-10237 CVE-2020-8908 Recommended upgrade version:30.1.1-android --

[GitHub] [rocketmq] aaron-ai commented on a diff in pull request #4825: [ISSUE#4824] Support consumequeue, indexfile multiple directories storage mode

2022-08-25 Thread GitBox
aaron-ai commented on code in PR #4825: URL: https://github.com/apache/rocketmq/pull/4825#discussion_r955713918 ## broker/src/main/java/org/apache/rocketmq/broker/offset/ConsumerOrderInfoManager.java: ## @@ -266,6 +266,15 @@ public String configFilePath() { } } +