[GitHub] [rocketmq] 15712852007 commented on pull request #4881: send async,time calculation rules Multiple method patches

15712852007 commented on PR #4881: URL: https://github.com/apache/rocketmq/pull/4881#issuecomment-1228312867 > Hi, think you for contributing! > > You may need to rebase the develop branch to pass the residual status check because we re-defined the mergeability recently. The ch

[GitHub] [rocketmq] 15712852007 commented on pull request #4881: send async,time calculation rules Multiple method patches

15712852007 commented on PR #4881: URL: https://github.com/apache/rocketmq/pull/4881#issuecomment-1226703029 > @15712852007 It would be nice if you describe _smaller and more reasonable designs based on the current version_ in finer detail. @lizhanhui In my opinion, there are two mai

[GitHub] [rocketmq] 15712852007 commented on pull request #4881: send async,time calculation rules Multiple method patches

15712852007 commented on PR #4881: URL: https://github.com/apache/rocketmq/pull/4881#issuecomment-1226663708 > @15712852007 1, The synchronous path shall also be updated; 2, For async method, we should have a timer, helping to respect timeout specified by the method. For the async send, its

[GitHub] [rocketmq] 15712852007 commented on pull request #4881: send async,time calculation rules Multiple method patches

15712852007 commented on PR #4881: URL: https://github.com/apache/rocketmq/pull/4881#issuecomment-1225502609 @lizhanhui Please help to merge again, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab