[GitHub] [rocketmq-mqtt] DongyuanPan commented on a diff in pull request #131: [ISSUE #70] Retained message based on raft state machine

2022-08-25 Thread GitBox
DongyuanPan commented on code in PR #131: URL: https://github.com/apache/rocketmq-mqtt/pull/131#discussion_r955588313 ## mqtt-common/src/main/proto/storeMessage.proto: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [rocketmq-mqtt] DongyuanPan commented on a diff in pull request #131: [ISSUE #70] Retained message based on raft state machine

2022-08-24 Thread GitBox
DongyuanPan commented on code in PR #131: URL: https://github.com/apache/rocketmq-mqtt/pull/131#discussion_r954452956 ## mqtt-ds/src/main/java/org/apache/rocketmq/mqtt/ds/retain/RetainedMsgClient.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [rocketmq-mqtt] DongyuanPan commented on a diff in pull request #131: [ISSUE #70] Retained message based on raft state machine

2022-08-24 Thread GitBox
DongyuanPan commented on code in PR #131: URL: https://github.com/apache/rocketmq-mqtt/pull/131#discussion_r954452002 ## mqtt-ds/src/main/java/org/apache/rocketmq/mqtt/ds/retain/RetainedMsgClient.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [rocketmq-mqtt] DongyuanPan commented on a diff in pull request #131: [ISSUE #70] Retained message based on raft state machine

2022-08-16 Thread GitBox
DongyuanPan commented on code in PR #131: URL: https://github.com/apache/rocketmq-mqtt/pull/131#discussion_r947382051 ## mqtt-cs/src/test/java/org/apache/rocketmq/mqtt/cs/test/session/infly/TestPushAction.java: ## @@ -176,6 +178,10 @@ public void testPushWhenQosZero() {

[GitHub] [rocketmq-mqtt] DongyuanPan commented on a diff in pull request #131: [ISSUE #70] Retained message based on raft state machine

2022-08-15 Thread GitBox
DongyuanPan commented on code in PR #131: URL: https://github.com/apache/rocketmq-mqtt/pull/131#discussion_r946280026 ## mqtt-common/src/test/java/org/apache/rocketmq/mqtt/common/test/model/TestTrie.java: ## @@ -91,10 +91,54 @@ public void test() { }); Assert.a

[GitHub] [rocketmq-mqtt] DongyuanPan commented on a diff in pull request #131: [ISSUE #70] Retained message based on raft state machine

2022-08-15 Thread GitBox
DongyuanPan commented on code in PR #131: URL: https://github.com/apache/rocketmq-mqtt/pull/131#discussion_r946277452 ## mqtt-common/src/main/java/org/apache/rocketmq/mqtt/common/util/TrieUtil.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [rocketmq-mqtt] DongyuanPan commented on a diff in pull request #131: [ISSUE #70] Retained message based on raft state machine

2022-08-11 Thread GitBox
DongyuanPan commented on code in PR #131: URL: https://github.com/apache/rocketmq-mqtt/pull/131#discussion_r943256506 ## meta/src/test/java/org/apache/rocketmq/mqtt/meta/raft/RetainedMsgClientTest.java: ## @@ -0,0 +1,251 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [rocketmq-mqtt] DongyuanPan commented on a diff in pull request #131: [ISSUE #70] Retained message based on raft state machine

2022-08-09 Thread GitBox
DongyuanPan commented on code in PR #131: URL: https://github.com/apache/rocketmq-mqtt/pull/131#discussion_r941311943 ## meta/src/main/java/org/apache/rocketmq/mqtt/meta/raft/processor/RetainedMsgStateProcess.java: ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [rocketmq-mqtt] DongyuanPan commented on a diff in pull request #131: [ISSUE #70] Retained message based on raft state machine

2022-08-09 Thread GitBox
DongyuanPan commented on code in PR #131: URL: https://github.com/apache/rocketmq-mqtt/pull/131#discussion_r941302869 ## meta/src/main/java/org/apache/rocketmq/mqtt/meta/raft/processor/RetainedMsgStateProcess.java: ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [rocketmq-mqtt] DongyuanPan commented on a diff in pull request #131: [ISSUE #70] Retained message based on raft state machine

2022-08-08 Thread GitBox
DongyuanPan commented on code in PR #131: URL: https://github.com/apache/rocketmq-mqtt/pull/131#discussion_r939822740 ## conf/meta.conf: ## @@ -15,4 +15,5 @@ selfAddress= -membersAddress= \ No newline at end of file +membersAddress= +limitRetainedMessageCount= Review Comme

[GitHub] [rocketmq-mqtt] DongyuanPan commented on a diff in pull request #131: [ISSUE #70] Retained message based on raft state machine

2022-08-08 Thread GitBox
DongyuanPan commented on code in PR #131: URL: https://github.com/apache/rocketmq-mqtt/pull/131#discussion_r939822740 ## conf/meta.conf: ## @@ -15,4 +15,5 @@ selfAddress= -membersAddress= \ No newline at end of file +membersAddress= +limitRetainedMessageCount= Review Comme

[GitHub] [rocketmq-mqtt] DongyuanPan commented on a diff in pull request #131: [ISSUE #70] Retained message based on raft state machine

2022-08-03 Thread GitBox
DongyuanPan commented on code in PR #131: URL: https://github.com/apache/rocketmq-mqtt/pull/131#discussion_r936364091 ## meta/src/main/java/org/apache/rocketmq/mqtt/meta/raft/processor/RetainedMsgStateProcess.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [rocketmq-mqtt] DongyuanPan commented on a diff in pull request #131: [ISSUE #70] Retained message based on raft state machine

2022-08-03 Thread GitBox
DongyuanPan commented on code in PR #131: URL: https://github.com/apache/rocketmq-mqtt/pull/131#discussion_r936320241 ## meta/src/main/java/org/apache/rocketmq/mqtt/meta/raft/processor/RetainedMsgStateProcess.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Fou