[GitHub] incubator-rocketmq issue #40: [ROCKETMQ-40]Ack mode support for consume conc...

Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/40 Hi, please resolve the conflicts and follow the rocketmq [codestyle](), and IMO, we need more discuss if we intent to add new feature to rocketmq-client module. --- If your project i

[GitHub] incubator-rocketmq issue #41: 网络环境复杂时，会�� 成选择了不�...

Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/41 IMO, this feature is not necessary, clientIP is only used in bornHost. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-rocketmq-site pull request #4: Improved 'How to create a PR (contr...

Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/4#discussion_r95923375 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -73,11 +73,15 @@ Push your branch to Github: 6. When you are satisfied and want to

[GitHub] incubator-rocketmq-site pull request #5: Fix the typo of team members

Github user asfgit closed the pull request at: https://github.com/apache/incubator-rocketmq-site/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-rocketmq-site pull request #4: Improved 'How to create a PR (contr...

Github user zhouxinyu commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/4#discussion_r95922741 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -73,11 +73,15 @@ Push your branch to Github: 6. When you are satisfied and want

[GitHub] incubator-rocketmq-site pull request #5: Fix the typo of team members

GitHub user WillemJiang opened a pull request: https://github.com/apache/incubator-rocketmq-site/pull/5 Fix the typo of team members You can merge this pull request into a Git repository by running: $ git pull https://github.com/WillemJiang/incubator-rocketmq-site master Alte

[GitHub] incubator-rocketmq issue #41: 网络环境复杂时，会�� 成选择了不�...

Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/41 Please follow instructs [here](http://rocketmq.incubator.apache.org/docs/pull-request/). --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-rocketmq issue #41: 网络环境复杂时，会�� 成选择了不�...

Github user tain198127 commented on the issue: https://github.com/apache/incubator-rocketmq/pull/41 When the client to start the producer, the producer will use the last one ipv4 address as default ip.but if the os have more than one ipv4 address, it will get some unexpected result.

[GitHub] incubator-rocketmq pull request #41: 网络环境复杂时，会�� 成选择...

GitHub user tain198127 opened a pull request: https://github.com/apache/incubator-rocketmq/pull/41 网络环境复杂时，会造成选择了不正确的网络 ip 地址。 由于 clientconfig 在获å

[GitHub] incubator-rocketmq pull request #37: [ROCKETMQ-38] Some unit tests for rocke...

Github user iskl commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/37#discussion_r95756507 --- Diff: remoting/src/test/java/org/apache/rocketmq/remoting/protocol/RemotingCommandTest.java --- @@ -0,0 +1,227 @@ +/* + * Licensed to the

[GitHub] incubator-rocketmq pull request #37: [ROCKETMQ-38] Some unit tests for rocke...

Github user WillemJiang commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/37#discussion_r95748248 --- Diff: remoting/src/test/java/org/apache/rocketmq/remoting/protocol/RemotingCommandTest.java --- @@ -0,0 +1,227 @@ +/* + * Licensed