[DISCUSS] How to handle sub projects of RocketMQ

2017-02-22 Thread yukon
Dear mentors, As we know, RocketMQ has a GitHub organization off Apache[1], and there are three mini projects are currently going through rapid iterative. rocketmq-console-ng will provide a ops dashboard for RocketMQ, rocketmq-jms will provide a new client to support JMS 2, while rocketmq-flume-n

[GitHub] incubator-rocketmq pull request #68: [ROCKETMQ-107] fix possible concurrency...

2017-02-22 Thread Jaskey
GitHub user Jaskey opened a pull request: https://github.com/apache/incubator-rocketmq/pull/68 [ROCKETMQ-107] fix possible concurrency problem on ServiceState when consumer start/shutdown JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-107 You can merge this pull request into

Podling Report Reminder - March 2017

2017-02-22 Thread johndament
Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 15 March 2017, 10:30 am PDT. The report for your podling will form a

Re: Looking for contributors for sub-project RocketMQ-JMS

2017-02-22 Thread Willem Jiang
The new release announcement is out, we need to take this into the consideration. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Tue, Feb 21, 2017 at 10:10 AM, Von Gosling wrote: > Yep. we have not

Re: Accepting contributions with Javadoc comments

2017-02-22 Thread Willem Jiang
I think we need to set up a fast track to accept the PR of adding Javadoc or other comments. As those change would break the CI build and it should be safe if we review the comments after merging. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chine

Re: Accepting contributions with Javadoc comments

2017-02-22 Thread Luke Han
+1 to have more documentation. Best Regards! - Luke Han On Wed, Feb 22, 2017 at 4:32 PM, chandresh pancholi < chandreshpancholi...@gmail.com> wrote: > +1 > Completely agree with Roman, Sometimes it's hard to understand the > functionality of methods in codebase. > > > > On

Re: Accepting contributions with Javadoc comments

2017-02-22 Thread chandresh pancholi
+1 Completely agree with Roman, Sometimes it's hard to understand the functionality of methods in codebase. On Wed, Feb 22, 2017 at 1:48 PM, Roman Shtykh wrote: > Folks, > The current codebase has too few comments and not so many unit tests, and > therefore it is pretty hard to understand the

Accepting contributions with Javadoc comments

2017-02-22 Thread Roman Shtykh
Folks, The current codebase has too few comments and not so many unit tests, and therefore it is pretty hard to understand the intentions of developers on their code (and figure out if a fix/improvement is needed, and so on). I realize we cannot start commenting on all the code now, but how about