Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/66
All right. +1 now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/79#discussion_r108344089
--- Diff: distribution/pom.xml ---
@@ -0,0 +1,125 @@
+
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/79#discussion_r108344108
--- Diff: distribution/release.xml ---
@@ -1,19 +1,19 @@
Github user Jaskey closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/75
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/75
@vongosling
Now nothing special has been done unless remove the hard corded aliyun code
snippet.
I will close this pr after merge.
---
If your project is set up for it,
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/75
@Jaskey Thanks for your elaborative consideration about exception. Let it
go as you have changed. we will merge this PR.
---
If your project is set up for it, you can reply to this ema
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/66
[](https://coveralls.io/builds/10801812)
Coverage decreased (-0.03%) to 31.492% when pulling
**1d84be8b2807bb0
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/66
[](https://coveralls.io/builds/10801812)
Coverage decreased (-0.03%) to 31.492% when pulling
**1d84be8b2807bb0
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/66
@lizhanhui for your second point, we just disable the topic level flow
control by default will do the trick.
pullThresholdForTopic = Integer.MAX_VALUE;
max value
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/75
[](https://coveralls.io/builds/10801304)
Coverage increased (+0.08%) to 31.701% when pulling
**ce164ebb4dd624f
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/75
[](https://coveralls.io/builds/10801304)
Coverage increased (+0.08%) to 31.701% when pulling
**ce164ebb4dd624f
Github user Jaskey closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/63
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/79#discussion_r108325070
--- Diff: distribution/release.xml ---
@@ -1,19 +1,19 @@
`, instead of ``.
---
If your project is set up for it, you can reply to th
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/79#discussion_r108323945
--- Diff: distribution/pom.xml ---
@@ -0,0 +1,125 @@
+
GitHub user vesense opened a pull request:
https://github.com/apache/incubator-rocketmq-externals/pull/4
[ROCKETMQ-81] Add the RocketMq plugin for the Apache Spark
https://issues.apache.org/jira/browse/ROCKETMQ-81
This is the init version for code review.
features:
*
Dear podling,
This email was sent by an automated system on behalf of the Apache
Incubator PMC. It is an initial reminder to give you plenty of time to
prepare your quarterly board report.
The board meeting is scheduled for Wed, 19 April 2017, 10:30 am PDT.
The report for your podling will form a
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/79
@shroman @zhouxinyu any idea on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user vesense closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/83
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user vesense commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/83
Thanks & Closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/83
Merged to `develop` branch. Thanks @vesense. Please close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/83
+1 from me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user vesense closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user vesense commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/84
Thanks & Closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/83
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/84
@vesense Please close this issue at your convenient time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/84
This is quick fix of typo and we have collected three +1s. Now it's merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/66
What I intend to deliver is that it's always good to have simple API, but
it would be miserably unexpected to change semantics of a configuration
quietly. Further, it's best not to intro
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
Merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/75
If no special consideration for authentication errors is needed (which was
obviously the intention in the original code), +1 for just removing the
hard-coded snippet. No `AuthenticationExc
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/75
So do you mean we just remove the hard code snippet in the pr and just make
it log for that? Better solution will be introduced in 4.1.x in another patches?
---
If your project is set up
Hi,
I found the issue "we want to query producer info"[1] is still
unresolved, which was submitted 2 months ago , and located in
"4.1.0-incubating" stage. Did anybody work on it? if not, I want to pick it
up.
[1] https://issues.apache.org/jira/browse/ROCKETMQ-49
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/75
Could you remove the code snippet â (!(e instanceof
AuthenticationException)) {â and class AuthenticationException
---
If your project is set up for it, you can reply to this emai
GitHub user Jaskey reopened a pull request:
https://github.com/apache/incubator-rocketmq/pull/63
[ROCKETMQ-101]Fix possible NullPointerException when retry in send Async way
JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-101
You can merge this pull request into a Git repositor
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/75
@vongosling OK, look forward to that!
So when will this pr be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
[](https://coveralls.io/builds/10784736)
Coverage decreased (-0.5%) to 31.043% when pulling
**18de2995e5241351
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
[](https://coveralls.io/builds/10784736)
Coverage decreased (-0.5%) to 31.043% when pulling
**18de2995e5241351
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
[](https://coveralls.io/builds/10784736)
Coverage decreased (-0.5%) to 31.043% when pulling
**18de2995e5241351
I put the anther thread topic about the RocketMQ filter PR into this one, Let
us to resolve it together.
Thanks Eric, we will review it as far as possible :-)
> Hi,
>
> I have already create a PR(
> https://github.com/apache/incubator-rocketmq/pull/82) , to support message
> filtering based
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/75
If we remove it, all authentication fail will have one log, and this could
be possibly very often and fill up with the remoting log, which I do not think
it is good enough.
We
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/75
Do you guys really consider that is good enough?? @vongosling @lollipopjin
IMO, the origin design is OK, since the AuthenticationException is thrown
from the hook.
The dev
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
@lizhanhui @Jaskey we'd better close after merge :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user Jaskey closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/63
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
Thank you @vongosling @lizhanhui @zhouxinyu
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/66
@lizhanhui
> Can we maintain semantics of the original config and name this specific
config something like flowControlThresholdByTopic?
This already done in my current pr.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/63
@Jaskey I'll merge this PR soon. Please close this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/84
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if t
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/84
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Thanks vongosling. BTW, Integrating with Apache Avro is also in my TODO
list. Here[1] is the Jira created just now. Anyone who is interested in
this, please join me. And let my know yours progress.
[1] https://issues.apache.org/jira/browse/ROCKETMQ-157
- Xin Wang (vesense)
2017-03-27 14:36 GMT+0
48 matches
Mail list logo
